Fix enviroments seeding on certain branch names

Bit of a cryptic commit title, but our seeding will try to guard against branchnames being anything but alphanumerical. These charachters we gsub away but can't have an empty string as replacement. This change is less efficient, but given that the number of seeded MRs per project is very limited, this should be ok.

Fix enviroments seeding on certain branch names
43b0dddf · Zeger-Jan van de Weg · 91a3a4b5 · 43b0dddf
Unverified Commit 43b0dddf authored Apr 09, 2018 by Zeger-Jan van de Weg
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

19_environments.rb db/fixtures/development/19_environments.rb +5 -1

No files found.
--- a/db/fixtures/development/19_environments.rb
+++ b/db/fixtures/development/19_environments.rb
@@ -28,7 +28,11 @@ class Gitlab::Seeder::Environments
  end

  def create_merge_request_review_deployments!
-    @project.merge_requests.sample(4).map do |merge_request|
+    @project
+      .merge_requests
+      .select { |mr| mr.source_branch.match(/\p{Alnum}+/) }
+      .sample(4)
+      .each do |merge_request|
      next unless merge_request.diff_head_sha

      create_deployment!(