Merge branch '39831-warning-icon-in-jobs-dropdown-has-incorrect-style' into 'master'

lib/gitlab/ci/status/build/failed_allowed.rb

@@ -8,7 +8,7 @@ module Gitlab
           end
 
           def icon
-            'warning'
+            'status_warning'
           end
 
           def group

spec/lib/gitlab/ci/status/build/factory_spec.rb

@@ -84,7 +84,7 @@ describe Gitlab::Ci::Status::Build::Factory do
 
       it 'fabricates status with correct details' do
         expect(status.text).to eq 'failed'
-        expect(status.icon).to eq 'warning'
+        expect(status.icon).to eq 'status_warning'
         expect(status.favicon).to eq 'favicon_status_failed'
         expect(status.label).to eq 'failed (allowed to fail)'
         expect(status).to have_details

spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb

@@ -18,7 +18,7 @@ describe Gitlab::Ci::Status::Build::FailedAllowed do
 
   describe '#icon' do
     it 'returns a warning icon' do
-      expect(subject.icon).to eq 'warning'
+      expect(subject.icon).to eq 'status_warning'
     end
   end