Fix the protected branches factory.

1. Previously, we were using `after_create` to create access levels. 2. At the time of protected branch creation, there are _no_ access levels present, which is invalid, and creation fails. 3. Fixed by setting access levels before the protected branch is created.

Fix the protected branches factory.
37651d2f · Timothy Andrew · 4ddbbcd1 · 37651d2f
Commit 37651d2f authored Aug 16, 2016 by Timothy Andrew
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

protected_branches.rb spec/factories/protected_branches.rb +3 -3

No files found.
--- a/spec/factories/protected_branches.rb
+++ b/spec/factories/protected_branches.rb
@@ -3,9 +3,9 @@ FactoryGirl.define do
    name
    project

-    after(:create) do |protected_branch|
-      protected_branch.push_access_levels.create!(access_level: Gitlab::Access::MASTER)
-      protected_branch.merge_access_levels.create!(access_level: Gitlab::Access::MASTER)
+    before(:create) do |protected_branch|
+      protected_branch.push_access_levels.new(access_level: Gitlab::Access::MASTER)
+      protected_branch.merge_access_levels.new(access_level: Gitlab::Access::MASTER)
    end

    trait :developers_can_push do