BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
2d3fcf90
Commit
2d3fcf90
authored
Jan 23, 2017
by
Stan Hu
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'no-more-bosses' into 'master'
Rename endboss -> maintainer, miniboss -> reviewer See merge request !8719
parents
c24a2d32
e2585e64
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
10 deletions
+10
-10
code_review.md
doc/development/code_review.md
+6
-6
merge_request_performance_guidelines.md
doc/development/merge_request_performance_guidelines.md
+4
-4
No files found.
doc/development/code_review.md
View file @
2d3fcf90
...
...
@@ -9,7 +9,7 @@ code is effective, understandable, and maintainable.
Any developer can, and is encouraged to, perform code review on merge requests
of colleagues and contributors. However, the final decision to accept a merge
request is up to one
of our merge request "endbosses"
, denoted on the
request is up to one
the project's maintainers
, denoted on the
[
team page
](
https://about.gitlab.com/team
)
.
## Everyone
...
...
@@ -81,15 +81,15 @@ balance in how deep the reviewer can interfere with the code created by a
reviewee.
-
Learning how to find the right balance takes time; that is why we have
minibosses that become merge request endbosses after some time spent on
re
viewing merge re
quests.
reviewers that become maintainers after some time spent on reviewing merge
requests.
-
Finding bugs and improving code style is important, but thinking about good
design is important as well. Building abstractions and good design is what
makes it possible to hide complexity and makes future changes easier.
-
Asking the reviewee to change the design sometimes means the complete rewrite
of the contributed code. It's usually a good idea to ask another m
erge
re
quest endboss before doing it, but have the courage to do it when you
believe it is
important.
of the contributed code. It's usually a good idea to ask another m
aintainer or
re
viewer before doing it, but have the courage to do it when you believe it is
important.
-
There is a difference in doing things right and doing things right now.
Ideally, we should do the former, but in the real world we need the latter as
well. A good example is a security fix which should be released as soon as
...
...
doc/development/merge_request_performance_guidelines.md
View file @
2d3fcf90
...
...
@@ -3,7 +3,7 @@
To ensure a merge request does not negatively impact performance of GitLab
_every_
merge request
**must**
adhere to the guidelines outlined in this
document. There are no exceptions to this rule unless specifically discussed
with and agreed upon by
merge request endbosse
s and performance specialists.
with and agreed upon by
backend maintainer
s and performance specialists.
To measure the impact of a merge request you can use
[
Sherlock
](
profiling.md#sherlock
)
. It's also highly recommended that you read
...
...
@@ -40,9 +40,9 @@ section below for more information.
about the impact.
Sometimes it's hard to assess the impact of a merge request. In this case you
should ask one of the merge request
(mini) endbosses to review your changes. You
can find a list of these endbosses at
<https://about.gitlab.com/team/>
. An
endboss
in turn can request a performance specialist to review the changes.
should ask one of the merge request
reviewers to review your changes. You can
find a list of these reviewers at
<https://about.gitlab.com/team/>
. A reviewer
in turn can request a performance specialist to review the changes.
## Query Counts
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment