Merge branch 'winh-scope-haml-linter' into 'master'

Restrict InlineJavaScript for haml_lint to dev and test environment Closes omnibus-gitlab#2658 See merge request !13364

Merge branch 'winh-scope-haml-linter' into 'master'
2b781c78 · Grzegorz Bizon · 356c8b38 · b3537000 · 2b781c78
Commit 2b781c78 authored Aug 08, 2017 by Grzegorz Bizon
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 9 deletions

inline_javascript.rb lib/haml_lint/inline_javascript.rb +11 -9

No files found.
--- a/lib/haml_lint/inline_javascript.rb
+++ b/lib/haml_lint/inline_javascript.rb
-require 'haml_lint/haml_visitor'
+unless Rails.env.production?
-require 'haml_lint/linter'
+  require 'haml_lint/haml_visitor'
-require 'haml_lint/linter_registry'
+  require 'haml_lint/linter'
+  require 'haml_lint/linter_registry'
-module HamlLint
+  module HamlLint
-  class Linter::InlineJavaScript < Linter
+    class Linter::InlineJavaScript < Linter
-    include LinterRegistry
+      include LinterRegistry
-    def visit_filter(node)
+      def visit_filter(node)
-      return unless node.filter_type == 'javascript'
+        return unless node.filter_type == 'javascript'
-      record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)')
+        record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)')
+      end
    end
  end
 end