BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
299aad3d
Unverified
Commit
299aad3d
authored
Apr 05, 2018
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fixed staged content not updating
parent
26901470
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
25 additions
and
8 deletions
+25
-8
list_item.vue
...s/javascripts/ide/components/commit_sidebar/list_item.vue
+7
-1
repo_editor.vue
app/assets/javascripts/ide/components/repo_editor.vue
+7
-1
model.js
app/assets/javascripts/ide/lib/common/model.js
+7
-0
file.js
app/assets/javascripts/ide/stores/actions/file.js
+2
-5
file.js
app/assets/javascripts/ide/stores/mutations/file.js
+2
-1
No files found.
app/assets/javascripts/ide/components/commit_sidebar/list_item.vue
View file @
299aad3d
...
...
@@ -29,7 +29,13 @@ export default {
},
},
methods
:
{
...
mapActions
([
'discardFileChanges'
,
'updateViewer'
,
'openPendingTab'
]),
...
mapActions
([
'discardFileChanges'
,
'updateViewer'
,
'openPendingTab'
,
'unstageChange'
,
'stageChange'
,
]),
openFileInEditor
()
{
return
this
.
openPendingTab
({
file
:
this
.
file
,
...
...
app/assets/javascripts/ide/components/repo_editor.vue
View file @
299aad3d
...
...
@@ -69,7 +69,13 @@ export default {
path
:
this
.
file
.
path
,
baseSha
:
this
.
currentMergeRequest
?
this
.
currentMergeRequest
.
baseCommitSha
:
''
,
})
.
then
(()
=>
this
.
updateViewer
(
this
.
file
.
pending
?
'diff'
:
this
.
viewer
))
.
then
(()
=>
{
const
viewerPromise
=
this
.
delayViewerUpdated
?
this
.
updateViewer
(
'editor'
)
:
Promise
.
resolve
();
return
viewerPromise
;
})
.
then
(()
=>
{
this
.
updateDelayViewerUpdated
(
false
);
this
.
createEditorInstance
();
...
...
app/assets/javascripts/ide/lib/common/model.js
View file @
299aad3d
...
...
@@ -34,10 +34,12 @@ export default class Model {
this
.
events
=
new
Map
();
this
.
updateContent
=
this
.
updateContent
.
bind
(
this
);
this
.
updateNewContent
=
this
.
updateNewContent
.
bind
(
this
);
this
.
dispose
=
this
.
dispose
.
bind
(
this
);
eventHub
.
$on
(
`editor.update.model.dispose.
${
this
.
file
.
key
}
`
,
this
.
dispose
);
eventHub
.
$on
(
`editor.update.model.content.
${
this
.
file
.
key
}
`
,
this
.
updateContent
);
eventHub
.
$on
(
`editor.update.model.new.content.
${
this
.
file
.
key
}
`
,
this
.
updateNewContent
);
}
get
url
()
{
...
...
@@ -87,11 +89,16 @@ export default class Model {
}
}
updateNewContent
(
content
)
{
this
.
getModel
().
setValue
(
content
);
}
dispose
()
{
this
.
disposable
.
dispose
();
this
.
events
.
clear
();
eventHub
.
$off
(
`editor.update.model.dispose.
${
this
.
file
.
key
}
`
,
this
.
dispose
);
eventHub
.
$off
(
`editor.update.model.content.
${
this
.
file
.
key
}
`
,
this
.
updateContent
);
eventHub
.
$off
(
`editor.update.model.new.content.
${
this
.
file
.
key
}
`
,
this
.
updateNewContent
);
}
}
app/assets/javascripts/ide/stores/actions/file.js
View file @
299aad3d
...
...
@@ -174,10 +174,7 @@ export const stageChange = ({ commit, state }, path) => {
commit
(
types
.
STAGE_CHANGE
,
path
);
if
(
stagedFile
)
{
eventHub
.
$emit
(
`editor.update.model.content.staged-
${
stagedFile
.
key
}
`
,
{
content
:
stagedFile
.
content
,
changed
:
false
,
});
eventHub
.
$emit
(
`editor.update.model.new.content.staged-
${
stagedFile
.
key
}
`
,
stagedFile
.
content
);
}
};
...
...
@@ -186,7 +183,7 @@ export const unstageChange = ({ commit }, path) => {
};
export
const
openPendingTab
=
({
commit
,
getters
,
dispatch
,
state
},
{
file
,
keyPrefix
})
=>
{
if
(
getters
.
activeFile
&&
getters
.
activeFile
.
path
===
file
.
path
&&
state
.
viewer
===
'diff'
)
{
if
(
getters
.
activeFile
&&
getters
.
activeFile
===
file
&&
state
.
viewer
===
'diff'
)
{
return
false
;
}
...
...
app/assets/javascripts/ide/stores/mutations/file.js
View file @
299aad3d
...
...
@@ -156,7 +156,7 @@ export default {
[
types
.
ADD_PENDING_TAB
](
state
,
{
file
,
keyPrefix
=
'pending'
})
{
const
pendingTab
=
state
.
openFiles
.
find
(
f
=>
f
.
path
===
file
.
path
&&
f
.
pending
);
let
openFiles
=
state
.
openFiles
.
map
(
f
=>
Object
.
assign
(
f
,
{
active
:
f
.
path
===
file
.
path
,
opened
:
false
}),
Object
.
assign
(
f
,
{
active
:
f
.
path
===
file
.
path
,
opened
:
false
,
active
:
false
}),
);
if
(
!
pendingTab
)
{
...
...
@@ -168,6 +168,7 @@ export default {
if
(
f
.
path
===
file
.
path
)
{
return
acc
.
concat
({
...
f
,
content
:
file
.
content
,
active
:
true
,
pending
:
true
,
opened
:
true
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment