BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 294ab0ff by Stan Hu
Options

Fix local storage not being cleared after creating a new issue

Creating a new issue will always result in a 302 redirect to the newly-created issue. This reverts the change introduced in https://gitlab.com/gitlab-org/gitlab-ce/commit/7684217d6806408cd338260119364419260d1720 to handle the case where a user is in the middle of creating a new form and redirected to accepting the terms of service. Closes #37162
parent d3b39a83
Showing with 8 additions and 2 deletions
app/assets/javascripts/issuable_form.js
......@@ -30,7 +30,7 @@ export default class IssuableForm {
}
this.initAutosave();
this.form.on('submit:success', this.handleSubmit);
this.form.on('submit', this.handleSubmit);
this.form.on('click', '.btn-cancel', this.resetAutosave);
this.initWip();
......
changelogs/unreleased/sh-fix-submit-not-clearing-local-storage.yml 0 → 100644
---
title: Fix local storage not being cleared after creating a new issue
merge_request:
author:
type: fixed
spec/features/users/terms_spec.rb
......@@ -62,7 +62,8 @@ describe 'Users > Terms' do
expect(current_path).to eq(project_issues_path(project))
end
it 'redirects back to the page the user was trying to save' do
# Disabled until https://gitlab.com/gitlab-org/gitlab-ce/issues/37162 is solved properly
xit 'redirects back to the page the user was trying to save' do
visit new_project_issue_path(project)
fill_in :issue_title, with: 'Hello world, a new issue'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment