Merge branch 'sh-optimize-label-finder' into 'master'

Reduce overhead of LabelFinder by avoiding #presence call Some users experienced 502 timeouts when viewing group labels. Labels#open_issues_count and Label#open_merge_requests_count were taking a long time to load because they were loading every ActiveRecord of the user-accessible projects into memory. This change modifies so that only the IDs are loaded into memory. Closes #23684 See merge request !7094

Merge branch 'sh-optimize-label-finder' into 'master'
279ffe7b · Stan Hu · 9c7b371a · ed47f4a3 · 279ffe7b · 279ffe7b
Commit 279ffe7b authored Oct 25, 2016 by Stan Hu
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

CHANGELOG.md CHANGELOG.md +1 -0

labels_finder.rb app/finders/labels_finder.rb +1 -1

No files found.
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,7 @@ Please view this file on the master branch, on stable branches it's out of date.
  - Fix reply-by-email not working due to queue name mismatch
  - Fixed hidden pipeline graph on commit and MR page !6895
  - Expire and build repository cache after project import
+  - Reduce overhead of LabelFinder by avoiding #presence call !7094
  - Fix 404 for group pages when GitLab setup uses relative url
  - Simpler arguments passed to named_route on toggle_award_url helper method
  - Fix unauthorized users dragging on issue boards

--- a/app/finders/labels_finder.rb
+++ b/app/finders/labels_finder.rb
@@ -50,7 +50,7 @@ class LabelsFinder < UnionFinder
  end

  def projects_ids
-    params[:project_ids].presence
+    params[:project_ids]
  end

  def title