BigW Consortium Gitlab

Commit 26af4b5a by Lin Jen-Shin

Also check blob path from source branch

parent e5acebd9
...@@ -738,19 +738,11 @@ class Repository ...@@ -738,19 +738,11 @@ class Repository
message:, branch_name:, message:, branch_name:,
author_email: nil, author_name: nil, author_email: nil, author_name: nil,
source_branch_name: nil, source_project: project) source_branch_name: nil, source_project: project)
if branch_exists?(branch_name) check_tree_entry_for_dir(branch_name, path)
# tree_entry is private
entry = raw_repository.send(:tree_entry, commit(branch_name), path) if source_branch_name
source_project.repository.
if entry check_tree_entry_for_dir(source_branch_name, path)
if entry[:type] == :blob
raise Gitlab::Git::Repository::InvalidBlobName.new(
"Directory already exists as a file")
else
raise Gitlab::Git::Repository::InvalidBlobName.new(
"Directory already exists")
end
end
end end
commit_file( commit_file(
...@@ -773,11 +765,16 @@ class Repository ...@@ -773,11 +765,16 @@ class Repository
message:, branch_name:, update: true, message:, branch_name:, update: true,
author_email: nil, author_name: nil, author_email: nil, author_name: nil,
source_branch_name: nil, source_project: project) source_branch_name: nil, source_project: project)
if branch_exists?(branch_name) && update == false unless update
# tree_entry is private error_message = "Filename already exists; update not allowed"
if raw_repository.send(:tree_entry, commit(branch_name), path)
raise Gitlab::Git::Repository::InvalidBlobName.new( if tree_entry_at(branch_name, path)
"Filename already exists; update not allowed") raise Gitlab::Git::Repository::InvalidBlobName.new(error_message)
end
if source_branch_name &&
source_project.repository.tree_entry_at(source_branch_name, path)
raise Gitlab::Git::Repository::InvalidBlobName.new(error_message)
end end
end end
...@@ -1140,6 +1137,30 @@ class Repository ...@@ -1140,6 +1137,30 @@ class Repository
end end
end end
protected
def tree_entry_at(branch_name, path)
branch_exists?(branch_name) &&
# tree_entry is private
raw_repository.send(:tree_entry, commit(branch_name), path)
end
def check_tree_entry_for_dir(branch_name, path)
return unless branch_exists?(branch_name)
entry = tree_entry_at(branch_name, path)
return unless entry
if entry[:type] == :blob
raise Gitlab::Git::Repository::InvalidBlobName.new(
"Directory already exists as a file")
else
raise Gitlab::Git::Repository::InvalidBlobName.new(
"Directory already exists")
end
end
private private
def git_action(index, action) def git_action(index, action)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment