BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 26678d8e by Patricio Cano
Options

Fix race condition that can be triggered if the token expires right after we…

Fix race condition that can be triggered if the token expires right after we retrieve it, but before we can set the new expiry time.
parent 33d1f590
Showing with 2 additions and 7 deletions
lib/gitlab/lfs_token.rb
...@@ -20,13 +20,8 @@ module Gitlab ...@@ -20,13 +20,8 @@ module Gitlab
def token def token
Gitlab::Redis.with do |redis| Gitlab::Redis.with do |redis|
token = redis.get(redis_key) token = redis.get(redis_key)
token ||= Devise.friendly_token(TOKEN_LENGTH)
if token redis.set(redis_key, token, ex: EXPIRY_TIME)
redis.expire(redis_key, EXPIRY_TIME)
else
token = Devise.friendly_token(TOKEN_LENGTH)
redis.set(redis_key, token, ex: EXPIRY_TIME)
end
token token
end end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment