BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
1b55e5af
Commit
1b55e5af
authored
Jul 13, 2016
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed dropdown enter key when searching
Closes #19741
parent
c1f0b7fc
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
0 deletions
+6
-0
CHANGELOG
CHANGELOG
+1
-0
gl_dropdown.js.coffee
app/assets/javascripts/gl_dropdown.js.coffee
+5
-0
No files found.
CHANGELOG
View file @
1b55e5af
...
@@ -37,6 +37,7 @@ v 8.10.0 (unreleased)
...
@@ -37,6 +37,7 @@ v 8.10.0 (unreleased)
- Make images fit to the size of the viewport !4810
- Make images fit to the size of the viewport !4810
- Fix check for New Branch button on Issue page !4630 (winniehell)
- Fix check for New Branch button on Issue page !4630 (winniehell)
- Fix GFM autocomplete not working on wiki pages
- Fix GFM autocomplete not working on wiki pages
- Fixed enter key not triggering click on first row when searching in a dropdown
- Fix MR-auto-close text added to description. !4836
- Fix MR-auto-close text added to description. !4836
- Support U2F devices in Firefox. !5177
- Support U2F devices in Firefox. !5177
- Fix issue, preventing users w/o push access to sort tags !5105 (redetection)
- Fix issue, preventing users w/o push access to sort tags !5105 (redetection)
...
...
app/assets/javascripts/gl_dropdown.js.coffee
View file @
1b55e5af
...
@@ -35,6 +35,8 @@ class GitLabDropdownFilter
...
@@ -35,6 +35,8 @@ class GitLabDropdownFilter
$inputContainer
.
removeClass
HAS_VALUE_CLASS
$inputContainer
.
removeClass
HAS_VALUE_CLASS
if
keyCode
is
13
if
keyCode
is
13
if
@
input
.
val
()
isnt
""
and
@
options
.
enterCallback
@
options
.
enterCallback
(
e
)
return
false
return
false
# Only filter asynchronously only if option remote is set
# Only filter asynchronously only if option remote is set
...
@@ -212,6 +214,9 @@ class GitLabDropdown
...
@@ -212,6 +214,9 @@ class GitLabDropdown
callback
:
(
data
)
=>
callback
:
(
data
)
=>
currentIndex
=
-
1
currentIndex
=
-
1
@
parseData
data
@
parseData
data
enterCallback
:
(
e
)
=>
@
selectRowAtIndex
(
e
,
0
)
# Event listeners
# Event listeners
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment