BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
1a09c207
Commit
1a09c207
authored
Aug 28, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'group-mr-search-bar' into 'master'
Add filtered search to group merge requests dashboard Closes #36703 See merge request !13688
parents
df677647
5e0b1442
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
27 additions
and
3 deletions
+27
-3
dispatcher.js
app/assets/javascripts/dispatcher.js
+2
-2
merge_requests.html.haml
app/views/groups/merge_requests.html.haml
+5
-1
group-mr-search-bar.yml
changelogs/unreleased/group-mr-search-bar.yml
+5
-0
merge_requests_spec.rb
spec/features/groups/merge_requests_spec.rb
+15
-0
No files found.
app/assets/javascripts/dispatcher.js
View file @
1a09c207
...
...
@@ -184,13 +184,13 @@ import initChangesDropdown from './init_changes_dropdown';
break
;
case
'dashboard:issues'
:
case
'dashboard:merge_requests'
:
case
'groups:merge_requests'
:
new
ProjectSelect
();
initLegacyFilters
();
break
;
case
'groups:issues'
:
case
'groups:merge_requests'
:
if
(
filteredSearchEnabled
)
{
const
filteredSearchManager
=
new
gl
.
FilteredSearchManager
(
'issue
s'
);
const
filteredSearchManager
=
new
gl
.
FilteredSearchManager
(
page
===
'groups:issues'
?
'issues'
:
'merge_request
s'
);
filteredSearchManager
.
setup
();
}
new
ProjectSelect
();
...
...
app/views/groups/merge_requests.html.haml
View file @
1a09c207
-
page_title
"Merge Requests"
-
content_for
:page_specific_javascripts
do
=
webpack_bundle_tag
'common_vue'
=
webpack_bundle_tag
'filtered_search'
-
if
show_new_nav?
&&
current_user
-
content_for
:breadcrumbs_extra
do
=
render
'shared/new_project_item_select'
,
path:
'merge_requests/new'
,
label:
"New merge request"
,
type: :merge_requests
...
...
@@ -13,7 +17,7 @@
.nav-controls
{
class:
(
"visible-xs"
if
show_new_nav?
)
}
=
render
'shared/new_project_item_select'
,
path:
'merge_requests/new'
,
label:
"New merge request"
,
type: :merge_requests
=
render
'shared/issuable/
filte
r'
,
type: :merge_requests
=
render
'shared/issuable/
search_ba
r'
,
type: :merge_requests
.row-content-block.second-block
Only merge requests from
...
...
changelogs/unreleased/group-mr-search-bar.yml
0 → 100644
View file @
1a09c207
---
title
:
Add filtered search to group merge requests dashboard
merge_request
:
13688
author
:
Hiroyuki Sato
type
:
changed
spec/features/groups/merge_requests_spec.rb
View file @
1a09c207
require
'spec_helper'
feature
'Group merge requests page'
do
include
FilteredSearchHelpers
let
(
:path
)
{
merge_requests_group_path
(
group
)
}
let
(
:issuable
)
{
create
(
:merge_request
,
source_project:
project
,
target_project:
project
,
title:
'this is my created issuable'
)
}
...
...
@@ -33,4 +35,17 @@ feature 'Group merge requests page' do
expect
(
page
.
find
(
'#state-all span.badge'
).
text
).
to
eq
(
"1"
)
end
end
context
'group filtered search'
,
:js
do
let
(
:access_level
)
{
ProjectFeature
::
ENABLED
}
let
(
:user
)
{
user_in_group
}
let
(
:user2
)
{
user_outside_group
}
it
'filters by assignee only group users'
do
filtered_search
.
set
(
'assignee:'
)
expect
(
find
(
'#js-dropdown-assignee .filter-dropdown'
)).
to
have_content
(
user
.
name
)
expect
(
find
(
'#js-dropdown-assignee .filter-dropdown'
)).
not_to
have_content
(
user2
.
name
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment