Fix note highlight being added to new notes

Always use a explicit true/false value to set highlight because jQuery assumes `null` means toggle from whatever state and doesn't force false. Regressed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12098

Fix note highlight being added to new notes
19e12aac · Eric Eastwood · 025cbc2a · 19e12aac · 19e12aac
Commit 19e12aac authored Jun 19, 2017 by Eric Eastwood
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

notes.js app/assets/javascripts/notes.js +3 -1

notes_spec.js spec/javascripts/notes_spec.js +1 -1

No files found.
--- a/app/assets/javascripts/notes.js
+++ b/app/assets/javascripts/notes.js
@@ -322,7 +322,9 @@ const normalizeNewlines = function(str) {
    Notes.updateNoteTargetSelector = function($note) {
      const hash = gl.utils.getLocationHash();
-      $note.toggleClass('target', hash && $note.filter(`#${hash}`).length > 0);
+      // Needs to be an explicit true/false for the jQuery `toggleClass(force)`
+      const addTargetClass = Boolean(hash && $note.filter(`#${hash}`).length > 0);
+      $note.toggleClass('target', addTargetClass);
    };
    /*

--- a/spec/javascripts/notes_spec.js
+++ b/spec/javascripts/notes_spec.js
@@ -176,7 +176,7 @@ import '~/notes';
        Notes.updateNoteTargetSelector($note);
-        expect($note.toggleClass).toHaveBeenCalledWith('target', null);
+        expect($note.toggleClass).toHaveBeenCalledWith('target', false);
      });
    });