Faulty LDAP DN name escaping removed

The Net::LDAP::Filter.escape function can not be used to escape the DN name because the backslash is required to escape special chars in the DN name. This leads to the error message "Access denied for your LDAP account." and prevents the user from logging in to gitlab. Example DN: CN=Test\, User,OU=Organization,DC=Company CN=Test User,OU=Organization,DC=Company http://www.ietf.org/rfc/rfc4514.txt

Faulty LDAP DN name escaping removed
1502fed7 · Michael Alt · 63da396f · 1502fed7
Commit 1502fed7 authored Mar 21, 2015 by Michael Alt
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 1 deletion

person.rb lib/gitlab/ldap/person.rb +0 -1

No files found.
--- a/lib/gitlab/ldap/person.rb
+++ b/lib/gitlab/ldap/person.rb
@@ -14,7 +14,6 @@ module Gitlab
      end

      def self.find_by_dn(dn, adapter)
-        dn = Net::LDAP::Filter.escape(dn)
        adapter.user('dn', dn)
      end