Add a comment to explain why newrev should be updated

Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_20301332

Add a comment to explain why newrev should be updated
14c4db2a · Lin Jen-Shin · 104bac3d · 14c4db2a
Commit 14c4db2a authored Jan 04, 2017 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

git_operation_service.rb app/services/git_operation_service.rb +3 -1

No files found.
--- a/app/services/git_operation_service.rb
+++ b/app/services/git_operation_service.rb
-
 class GitOperationService
  attr_reader :user, :repository

@@ -28,6 +27,9 @@ class GitOperationService

    with_hooks(ref, newrev, oldrev) do |service|
      raw_tag = repository.rugged.tags.create(tag_name, newrev, options)
+
+      # If raw_tag is an annotated tag, we'll need to update newrev to point
+      # to the new revision.
      service.newrev = raw_tag.target_id
    end
  end