BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 0b1cf500 by Ali Tavakoli
Options

Added .closest() to find Reply button on click; fixes #401

This is to fix the issue where the icon-comment icon is clicked in the Reply button of a note; the icon is used as the target and incorrectly assumed to be the button itself, which causes the reply form to spawn inside the button.
parent 1f3261ac
Showing with 2 additions and 1 deletion
CHANGELOG
...@@ -19,6 +19,7 @@ v 7.1.0 ...@@ -19,6 +19,7 @@ v 7.1.0
- Fix LDAP TLS authentication (Boris HUISGEN) - Fix LDAP TLS authentication (Boris HUISGEN)
- Show VERSION information on project sidebar - Show VERSION information on project sidebar
- Improve branch removal logic when accept MR - Improve branch removal logic when accept MR
- Fix bug where comment form is spawned inside the Reply button
v 7.0.0 v 7.0.0
- The CPU no longer overheats when you hold down the spacebar - The CPU no longer overheats when you hold down the spacebar
......
app/assets/javascripts/notes.js.coffee
...@@ -376,7 +376,7 @@ class Notes ...@@ -376,7 +376,7 @@ class Notes
### ###
replyToDiscussionNote: (e) => replyToDiscussionNote: (e) =>
form = $(".js-new-note-form") form = $(".js-new-note-form")
replyLink = $(e.target) replyLink = $(e.target).closest(".js-discussion-reply-button")
replyLink.hide() replyLink.hide()
# insert the form after the button # insert the form after the button
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment