Added .closest() to find Reply button on click; fixes #401

This is to fix the issue where the icon-comment icon is clicked in the Reply button of a note; the icon is used as the target and incorrectly assumed to be the button itself, which causes the reply form to spawn inside the button.

Added .closest() to find Reply button on click; fixes #401
0b1cf500 · Ali Tavakoli · 1f3261ac · 0b1cf500 · 0b1cf500
Commit 0b1cf500 authored Jul 09, 2014 by Ali Tavakoli
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

CHANGELOG CHANGELOG +1 -0

notes.js.coffee app/assets/javascripts/notes.js.coffee +1 -1

No files found.
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -19,6 +19,7 @@ v 7.1.0
  - Fix LDAP TLS authentication (Boris HUISGEN)
  - Show VERSION information on project sidebar
  - Improve branch removal logic when accept MR
+  - Fix bug where comment form is spawned inside the Reply button

 v 7.0.0
  - The CPU no longer overheats when you hold down the spacebar

--- a/app/assets/javascripts/notes.js.coffee
+++ b/app/assets/javascripts/notes.js.coffee
@@ -376,7 +376,7 @@ class Notes
  ###
  replyToDiscussionNote: (e) =>
    form = $(".js-new-note-form")
-    replyLink = $(e.target)
+    replyLink = $(e.target).closest(".js-discussion-reply-button")
    replyLink.hide()

    # insert the form after the button