Initialize @statuses in status rather than constructor

Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17742312

Initialize @statuses in status rather than constructor
0902ba52 · Lin Jen-Shin · 1ae557c1 · 0902ba52
Commit 0902ba52 authored Nov 03, 2016 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

commit.rb app/models/commit.rb +2 -1

No files found.
--- a/app/models/commit.rb
+++ b/app/models/commit.rb
@@ -57,7 +57,6 @@ class Commit

    @raw = raw_commit
    @project = project
-    @statuses = {}
  end

  def id
@@ -231,6 +230,8 @@ class Commit
  end

  def status(ref = nil)
+    @statuses ||= {}
+
    if @statuses.key?(ref)
      @statuses[ref]
    elsif ref