Merge branch 'follow-on-mr376' into 'master'

Follow on to MR 376 Follow-on to MR 376 from @haynes . Remove unnecessary fetch of commit messages for initial push. This will reduce the memory usage significantly. See merge request !387

Merge branch 'follow-on-mr376' into 'master'
07f9a3f9 · Hannes Rosenögger · 48036751 · 9bb5986d · 07f9a3f9 · 07f9a3f9
Commit 07f9a3f9 authored Mar 13, 2015 by Hannes Rosenögger
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

CHANGELOG CHANGELOG +1 -0

git_push_service.rb app/services/git_push_service.rb +0 -3

No files found.
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -2,6 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date.

 v 7.9.0 (unreleased)
  - Update documentation for object_kind field in Webhook push and tag push Webhooks (Stan Hu)
+  - Remove unnecessary fetch of commit messages on initial push (Perforce Software)
  - Fix broken email images (Hannes Rosenögger)
  - Fix mass SQL statements on initial push (Hannes Rosenögger)
  - Add tag push notifications and normalize HipChat and Slack messages to be consistent (Stan Hu)

--- a/app/services/git_push_service.rb
+++ b/app/services/git_push_service.rb
@@ -29,9 +29,6 @@ class GitPushService
      elsif push_to_new_branch?(ref, oldrev)
        # Re-find the pushed commits.
        if is_default_branch?(ref)
-          # Initial push to the default branch. Take the full history of that branch as "newly pushed".
-          @push_commits = project.repository.commits(newrev)
-
          # Set protection on the default branch if configured
          if (current_application_settings.default_branch_protection != PROTECTION_NONE)
            developers_can_push = current_application_settings.default_branch_protection == PROTECTION_DEV_CAN_PUSH ? true : false