Don't bother going through an entire Banzai pipeline for empty text

This bails out of `cacheless_render` immediately unless the provided text is present, since there's no point. This is a slight improvement in our test performance. Across the creation of 1,000 `Namespace` records, which caches the `description` field and which is blank by default in its factory, this saves about four seconds, which... sure. Why not.

Don't bother going through an entire Banzai pipeline for empty text
01dc8e6d · Robert Speicher · 93e96c3f · 01dc8e6d
Commit 01dc8e6d authored Aug 03, 2017 by Robert Speicher
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

renderer.rb lib/banzai/renderer.rb +2 -0

No files found.
--- a/lib/banzai/renderer.rb
+++ b/lib/banzai/renderer.rb
@@ -132,6 +132,8 @@ module Banzai
    end

    def self.cacheless_render(text, context = {})
+      return text.to_s unless text.present?
+
      Gitlab::Metrics.measure(:banzai_cacheless_render) do
        result = render_result(text, context)