BigW Consortium Gitlab

issuable_list_spec.rb 2.37 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32
require 'rails_helper'

describe 'issuable list', feature: true do
  let(:project) { create(:empty_project) }
  let(:user)    { create(:user) }

  issuable_types = [:issue, :merge_request]

  before do
    project.add_user(user, :developer)
    login_as(user)
    issuable_types.each { |type| create_issuables(type) }
  end

  issuable_types.each do |issuable_type|
    it "avoids N+1 database queries for #{issuable_type.to_s.humanize.pluralize}" do
      control_count = ActiveRecord::QueryRecorder.new { visit_issuable_list(issuable_type) }.count

      create_issuables(issuable_type)

      expect { visit_issuable_list(issuable_type) }.not_to exceed_query_limit(control_count)
    end

    it "counts upvotes, downvotes and notes count for each #{issuable_type.to_s.humanize}" do
      visit_issuable_list(issuable_type)

      expect(first('.fa-thumbs-up').find(:xpath, '..')).to have_content(1)
      expect(first('.fa-thumbs-down').find(:xpath, '..')).to have_content(1)
      expect(first('.fa-comments').find(:xpath, '..')).to have_content(2)
    end
  end

blackst0ne committed
33 34
  it "counts merge requests closing issues icons for each issue" do
    visit_issuable_list(:issue)
blackst0ne committed
35

blackst0ne committed
36
    expect(page).to have_selector('.icon-merge-request-unmerged', count: 1)
blackst0ne committed
37 38
    expect(first('.icon-merge-request-unmerged').find(:xpath, '..')).to have_content(1)
  end
blackst0ne committed
39

40 41 42 43 44 45 46 47 48
  def visit_issuable_list(issuable_type)
    if issuable_type == :issue
      visit namespace_project_issues_path(project.namespace, project)
    else
      visit namespace_project_merge_requests_path(project.namespace, project)
    end
  end

  def create_issuables(issuable_type)
49
    3.times do |n|
Douwe Maan committed
50 51 52 53
      issuable =
        if issuable_type == :issue
          create(:issue, project: project, author: user)
        else
Rémy Coutable committed
54
          create(:merge_request, source_project: project, source_branch: generate(:branch))
Douwe Maan committed
55
        end
56 57

      2.times do
58
        create(:note_on_issue, noteable: issuable, project: project)
59 60 61 62
      end

      create(:award_emoji, :downvote, awardable: issuable)
      create(:award_emoji, :upvote, awardable: issuable)
blackst0ne committed
63
    end
blackst0ne committed
64

blackst0ne committed
65 66 67 68
    if issuable_type == :issue
      issue = Issue.reorder(:iid).first
      merge_request = create(:merge_request,
                              source_project: project,
Rémy Coutable committed
69
                              source_branch: generate(:branch))
blackst0ne committed
70

blackst0ne committed
71
      MergeRequestsClosingIssues.create!(issue: issue, merge_request: merge_request)
72 73 74
    end
  end
end