BigW Consortium Gitlab

extracts_path_spec.rb 5.73 KB
Newer Older
1 2
require 'spec_helper'

Douwe Maan committed
3
describe ExtractsPath, lib: true do
4
  include ExtractsPath
5
  include RepoHelpers
6
  include Gitlab::Routing.url_helpers
7 8

  let(:project) { double('project') }
9
  let(:request) { double('request') }
10 11 12

  before do
    @project = project
13

14 15
    repo = double(ref_names: ['master', 'foo/bar/baz', 'v1.0.0', 'v2.0.0',
                              'release/app', 'release/app/v1.0.0'])
16 17 18
    allow(project).to receive(:repository).and_return(repo)
    allow(project).to receive(:path_with_namespace).
      and_return('gitlab/gitlab-ci')
19
    allow(request).to receive(:format=)
20 21
  end

22
  describe '#assign_ref_vars' do
23
    let(:ref) { sample_commit[:id] }
24
    let(:params) { { path: sample_commit[:line_code_path], ref: ref } }
25 26

    before do
27
      @project = create(:project, :repository)
28 29
    end

30
    it "log tree path has no escape sequences" do
31 32 33
      assign_ref_vars
      expect(@logs_path).to eq("/#{@project.path_with_namespace}/refs/#{ref}/logs_tree/files/ruby/popen.rb")
    end
34

35 36 37 38 39 40 41 42 43 44 45
    context 'ref contains %20' do
      let(:ref) { 'foo%20bar' }

      it 'is not converted to a space in @id' do
        @project.repository.add_branch(@project.owner, 'foo%20bar', 'master')

        assign_ref_vars

        expect(@id).to start_with('foo%20bar/')
      end
    end
46 47 48 49 50 51 52 53 54 55

    context 'path contains space' do
      let(:params) { { path: 'with space', ref: '38008cb17ce1466d8fec2dfa6f6ab8dcfe5cf49e' } }

      it 'is not converted to %20 in @path' do
        assign_ref_vars

        expect(@path).to eq(params[:path])
      end
    end
56 57 58 59 60 61 62 63 64 65

    context 'subclass overrides get_id' do
      it 'uses ref returned by get_id' do
        allow_any_instance_of(self.class).to receive(:get_id){ '38008cb17ce1466d8fec2dfa6f6ab8dcfe5cf49e' }

        assign_ref_vars

        expect(@id).to eq(get_id)
      end
    end
66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134

    context 'ref only exists without .atom suffix' do
      context 'with a path' do
        let(:params) { { ref: 'v1.0.0.atom', path: 'README.md' } }

        it 'renders a 404' do
          expect(self).to receive(:render_404)

          assign_ref_vars
        end
      end

      context 'without a path' do
        let(:params) { { ref: 'v1.0.0.atom' } }
        before { assign_ref_vars }

        it 'sets the un-suffixed version as @ref' do
          expect(@ref).to eq('v1.0.0')
        end

        it 'sets the request format to Atom' do
          expect(request).to have_received(:format=).with(:atom)
        end
      end
    end

    context 'ref exists with .atom suffix' do
      context 'with a path' do
        let(:params) { { ref: 'master.atom', path: 'README.md' } }

        before do
          repository = @project.repository
          allow(repository).to receive(:commit).and_call_original
          allow(repository).to receive(:commit).with('master.atom').and_return(repository.commit('master'))

          assign_ref_vars
        end

        it 'sets the suffixed version as @ref' do
          expect(@ref).to eq('master.atom')
        end

        it 'does not change the request format' do
          expect(request).not_to have_received(:format=)
        end
      end

      context 'without a path' do
        let(:params) { { ref: 'master.atom' } }

        before do
          repository = @project.repository
          allow(repository).to receive(:commit).and_call_original
          allow(repository).to receive(:commit).with('master.atom').and_return(repository.commit('master'))
        end

        it 'sets the suffixed version as @ref' do
          assign_ref_vars

          expect(@ref).to eq('master.atom')
        end

        it 'does not change the request format' do
          expect(request).not_to receive(:format=)

          assign_ref_vars
        end
      end
    end
135 136
  end

137 138 139
  describe '#extract_ref' do
    it "returns an empty pair when no @project is set" do
      @project = nil
140
      expect(extract_ref('master/CHANGELOG')).to eq(['', ''])
141 142 143 144
    end

    context "without a path" do
      it "extracts a valid branch" do
145
        expect(extract_ref('master')).to eq(['master', ''])
146 147 148
      end

      it "extracts a valid tag" do
149
        expect(extract_ref('v2.0.0')).to eq(['v2.0.0', ''])
150 151 152
      end

      it "extracts a valid commit ref without a path" do
153
        expect(extract_ref('f4b14494ef6abf3d144c28e4af0c20143383e062')).to eq(
154
          ['f4b14494ef6abf3d144c28e4af0c20143383e062', '']
155
        )
156 157 158
      end

      it "falls back to a primitive split for an invalid ref" do
159
        expect(extract_ref('stable')).to eq(['stable', ''])
160
      end
161 162 163 164 165

      it "extracts the longest matching ref" do
        expect(extract_ref('release/app/v1.0.0/README.md')).to eq(
          ['release/app/v1.0.0', 'README.md'])
      end
166 167 168 169
    end

    context "with a path" do
      it "extracts a valid branch" do
170 171
        expect(extract_ref('foo/bar/baz/CHANGELOG')).to eq(
          ['foo/bar/baz', 'CHANGELOG'])
172 173 174
      end

      it "extracts a valid tag" do
175
        expect(extract_ref('v2.0.0/CHANGELOG')).to eq(['v2.0.0', 'CHANGELOG'])
176 177 178
      end

      it "extracts a valid commit SHA" do
179
        expect(extract_ref('f4b14494ef6abf3d144c28e4af0c20143383e062/CHANGELOG')).to eq(
180
          ['f4b14494ef6abf3d144c28e4af0c20143383e062', 'CHANGELOG']
181
        )
182 183 184
      end

      it "falls back to a primitive split for an invalid ref" do
185
        expect(extract_ref('stable/CHANGELOG')).to eq(['stable', 'CHANGELOG'])
186 187 188
      end
    end
  end
189 190 191 192 193 194 195 196 197 198 199 200 201 202

  describe '#extract_ref_without_atom' do
    it 'ignores any matching refs suffixed with atom' do
      expect(extract_ref_without_atom('master.atom')).to eq('master')
    end

    it 'returns the longest matching ref' do
      expect(extract_ref_without_atom('release/app/v1.0.0.atom')).to eq('release/app/v1.0.0')
    end

    it 'returns nil if there are no matching refs' do
      expect(extract_ref_without_atom('foo.atom')).to eq(nil)
    end
  end
203
end