BigW Consortium Gitlab

commit_status_spec.rb 11 KB
Newer Older
1 2
require 'spec_helper'

3
describe CommitStatus, :models do
4
  let(:project) { create(:project, :repository) }
5 6 7 8 9

  let(:pipeline) do
    create(:ci_pipeline, project: project, sha: project.commit.id)
  end

10 11 12 13 14
  let(:commit_status) { create_status }

  def create_status(args = {})
    create(:commit_status, args.merge(pipeline: pipeline))
  end
15

16
  it { is_expected.to belong_to(:pipeline) }
17
  it { is_expected.to belong_to(:user) }
Kamil Trzcinski committed
18
  it { is_expected.to belong_to(:project) }
19
  it { is_expected.to belong_to(:auto_canceled_by) }
Kamil Trzcinski committed
20

21 22 23
  it { is_expected.to validate_presence_of(:name) }
  it { is_expected.to validate_inclusion_of(:status).in_array(%w(pending running failed success canceled)) }

24 25
  it { is_expected.to delegate_method(:sha).to(:pipeline) }
  it { is_expected.to delegate_method(:short_sha).to(:pipeline) }
26

27 28 29 30 31
  it { is_expected.to respond_to :success? }
  it { is_expected.to respond_to :failed? }
  it { is_expected.to respond_to :running? }
  it { is_expected.to respond_to :pending? }

32
  describe '#author' do
33 34 35 36 37 38
    subject { commit_status.author }
    before { commit_status.author = User.new }

    it { is_expected.to eq(commit_status.user) }
  end

39 40 41 42 43 44 45 46 47 48
  describe 'status state machine' do
    let!(:commit_status) { create(:commit_status, :running, project: project) }

    it 'invalidates the cache after a transition' do
      expect(ExpireJobCacheWorker).to receive(:perform_async).with(commit_status.id)

      commit_status.success!
    end
  end

49
  describe '#started?' do
50 51 52 53 54 55 56 57
    subject { commit_status.started? }

    context 'without started_at' do
      before { commit_status.started_at = nil }

      it { is_expected.to be_falsey }
    end

Lin Jen-Shin committed
58
    %w[running success failed].each do |status|
59 60 61 62 63 64 65
      context "if commit status is #{status}" do
        before { commit_status.status = status }

        it { is_expected.to be_truthy }
      end
    end

Lin Jen-Shin committed
66
    %w[pending canceled].each do |status|
67 68 69 70 71 72 73 74
      context "if commit status is #{status}" do
        before { commit_status.status = status }

        it { is_expected.to be_falsey }
      end
    end
  end

75
  describe '#active?' do
76 77
    subject { commit_status.active? }

Lin Jen-Shin committed
78
    %w[pending running].each do |state|
79 80 81 82 83 84 85
      context "if commit_status.status is #{state}" do
        before { commit_status.status = state }

        it { is_expected.to be_truthy }
      end
    end

Lin Jen-Shin committed
86
    %w[success failed canceled].each do |state|
87 88 89 90 91 92 93 94
      context "if commit_status.status is #{state}" do
        before { commit_status.status = state }

        it { is_expected.to be_falsey }
      end
    end
  end

95
  describe '#complete?' do
96 97
    subject { commit_status.complete? }

Lin Jen-Shin committed
98
    %w[success failed canceled].each do |state|
99 100 101 102 103 104 105
      context "if commit_status.status is #{state}" do
        before { commit_status.status = state }

        it { is_expected.to be_truthy }
      end
    end

Lin Jen-Shin committed
106
    %w[pending running].each do |state|
107 108 109 110 111 112 113 114
      context "if commit_status.status is #{state}" do
        before { commit_status.status = state }

        it { is_expected.to be_falsey }
      end
    end
  end

115 116 117 118 119
  describe '#auto_canceled?' do
    subject { commit_status.auto_canceled? }

    context 'when it is canceled' do
      before do
120
        commit_status.update(status: 'canceled')
121 122 123 124
      end

      context 'when there is auto_canceled_by' do
        before do
Lin Jen-Shin committed
125
          commit_status.update(auto_canceled_by: create(:ci_empty_pipeline))
126 127 128 129 130 131 132 133 134 135 136 137 138 139 140
        end

        it 'is auto canceled' do
          is_expected.to be_truthy
        end
      end

      context 'when there is no auto_canceled_by' do
        it 'is not auto canceled' do
          is_expected.to be_falsey
        end
      end
    end
  end

141
  describe '#duration' do
142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
    subject { commit_status.duration }

    it { is_expected.to eq(120.0) }

    context 'if the building process has not started yet' do
      before do
        commit_status.started_at = nil
        commit_status.finished_at = nil
      end

      it { is_expected.to be_nil }
    end

    context 'if the building process has started' do
      before do
        commit_status.started_at = Time.now - 1.minute
        commit_status.finished_at = nil
      end

      it { is_expected.to be_a(Float) }
      it { is_expected.to be > 0.0 }
    end
  end
165

166
  describe '.latest' do
167
    subject { described_class.latest.order(:id) }
168

169
    let(:statuses) do
170 171 172
      [create_status(name: 'aa', ref: 'bb', status: 'running', retried: true),
       create_status(name: 'cc', ref: 'cc', status: 'pending', retried: true),
       create_status(name: 'aa', ref: 'cc', status: 'success', retried: true),
173 174
       create_status(name: 'cc', ref: 'bb', status: 'success'),
       create_status(name: 'aa', ref: 'bb', status: 'success')]
175 176
    end

177
    it 'returns unique statuses' do
178
      is_expected.to eq(statuses.values_at(3, 4))
179 180 181
    end
  end

182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197
  describe '.retried' do
    subject { described_class.retried.order(:id) }

    let(:statuses) do
      [create_status(name: 'aa', ref: 'bb', status: 'running', retried: true),
       create_status(name: 'cc', ref: 'cc', status: 'pending', retried: true),
       create_status(name: 'aa', ref: 'cc', status: 'success', retried: true),
       create_status(name: 'cc', ref: 'bb', status: 'success'),
       create_status(name: 'aa', ref: 'bb', status: 'success')]
    end

    it 'returns unique statuses' do
      is_expected.to contain_exactly(*statuses.values_at(0, 1, 2))
    end
  end

198
  describe '.running_or_pending' do
199
    subject { described_class.running_or_pending.order(:id) }
200

201 202 203 204 205 206
    let(:statuses) do
      [create_status(name: 'aa', ref: 'bb', status: 'running'),
       create_status(name: 'cc', ref: 'cc', status: 'pending'),
       create_status(name: 'aa', ref: nil, status: 'success'),
       create_status(name: 'dd', ref: nil, status: 'failed'),
       create_status(name: 'ee', ref: nil, status: 'canceled')]
207 208
    end

209
    it 'returns statuses that are running or pending' do
210
      is_expected.to contain_exactly(*statuses.values_at(0, 1))
211 212 213
    end
  end

214
  describe '.after_stage' do
215 216 217 218 219 220 221 222 223 224 225 226 227 228 229
    subject { described_class.after_stage(0) }

    let(:statuses) do
      [create_status(name: 'aa', stage_idx: 0),
       create_status(name: 'cc', stage_idx: 1),
       create_status(name: 'aa', stage_idx: 2)]
    end

    it 'returns statuses from second and third stage' do
      is_expected.to eq(statuses.values_at(1, 2))
    end
  end

  describe '.exclude_ignored' do
    subject { described_class.exclude_ignored.order(:id) }
230 231 232 233 234 235 236 237 238 239 240

    let(:statuses) do
      [create_status(when: 'manual', status: 'skipped'),
       create_status(when: 'manual', status: 'success'),
       create_status(when: 'manual', status: 'failed'),
       create_status(when: 'on_failure', status: 'skipped'),
       create_status(when: 'on_failure', status: 'success'),
       create_status(when: 'on_failure', status: 'failed'),
       create_status(allow_failure: true, status: 'success'),
       create_status(allow_failure: true, status: 'failed'),
       create_status(allow_failure: false, status: 'success'),
241 242 243
       create_status(allow_failure: false, status: 'failed'),
       create_status(allow_failure: true, status: 'manual'),
       create_status(allow_failure: false, status: 'manual')]
244 245 246
    end

    it 'returns statuses without what we want to ignore' do
247
      is_expected.to eq(statuses.values_at(0, 1, 2, 3, 4, 5, 6, 8, 9, 11))
248 249
    end
  end
250

251 252 253 254
  describe '.failed_but_allowed' do
    subject { described_class.failed_but_allowed.order(:id) }

    let(:statuses) do
255 256 257 258 259 260 261 262
      [create_status(allow_failure: true, status: 'success'),
       create_status(allow_failure: true, status: 'failed'),
       create_status(allow_failure: false, status: 'success'),
       create_status(allow_failure: false, status: 'failed'),
       create_status(allow_failure: true, status: 'canceled'),
       create_status(allow_failure: false, status: 'canceled'),
       create_status(allow_failure: true, status: 'manual'),
       create_status(allow_failure: false, status: 'manual')]
263 264 265 266 267 268 269
    end

    it 'returns statuses without what we want to ignore' do
      is_expected.to eq(statuses.values_at(1, 4))
    end
  end

270 271 272
  describe '#before_sha' do
    subject { commit_status.before_sha }

273 274
    context 'when no before_sha is set for pipeline' do
      before { pipeline.before_sha = nil }
275

276
      it 'returns blank sha' do
277 278 279 280
        is_expected.to eq(Gitlab::Git::BLANK_SHA)
      end
    end

281
    context 'for before_sha set for pipeline' do
282
      let(:value) { '1234' }
283
      before { pipeline.before_sha = value }
284

285
      it 'returns the set value' do
286 287 288 289 290
        is_expected.to eq(value)
      end
    end
  end

291 292 293 294 295
  describe '#commit' do
    it 'returns commit pipeline has been created for' do
      expect(commit_status.commit).to eq project.commit
    end
  end
Kamil Trzcinski committed
296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312

  describe '#group_name' do
    subject { commit_status.group_name }

    tests = {
      'rspec:windows' => 'rspec:windows',
      'rspec:windows 0' => 'rspec:windows 0',
      'rspec:windows 0 test' => 'rspec:windows 0 test',
      'rspec:windows 0 1' => 'rspec:windows',
      'rspec:windows 0 1 name' => 'rspec:windows name',
      'rspec:windows 0/1' => 'rspec:windows',
      'rspec:windows 0/1 name' => 'rspec:windows name',
      'rspec:windows 0:1' => 'rspec:windows',
      'rspec:windows 0:1 name' => 'rspec:windows name',
      'rspec:windows 10000 20000' => 'rspec:windows',
      'rspec:windows 0 : / 1' => 'rspec:windows',
      'rspec:windows 0 : / 1 name' => 'rspec:windows name',
313 314
      '0 1 name ruby' => 'name ruby',
      '0 :/ 1 name ruby' => 'name ruby'
Kamil Trzcinski committed
315 316 317 318 319 320 321 322 323 324
    }

    tests.each do |name, group_name|
      it "'#{name}' puts in '#{group_name}'" do
        commit_status.name = name

        is_expected.to eq(group_name)
      end
    end
  end
325 326 327 328 329 330 331 332 333

  describe '#detailed_status' do
    let(:user) { create(:user) }

    it 'returns a detailed status' do
      expect(commit_status.detailed_status(user))
        .to be_a Gitlab::Ci::Status::Success
    end
  end
334 335 336 337 338 339 340 341 342 343 344 345 346 347 348

  describe '#sortable_name' do
    tests = {
      'karma' => ['karma'],
      'karma 0 20' => ['karma ', 0, ' ', 20],
      'karma 10 20' => ['karma ', 10, ' ', 20],
      'karma 50:100' => ['karma ', 50, ':', 100],
      'karma 1.10' => ['karma ', 1, '.', 10],
      'karma 1.5.1' => ['karma ', 1, '.', 5, '.', 1],
      'karma 1 a' => ['karma ', 1, ' a']
    }

    tests.each do |name, sortable_name|
      it "'#{name}' sorts as '#{sortable_name}'" do
        commit_status.name = name
349
        expect(commit_status.sortable_name).to eq(sortable_name)
350 351 352
      end
    end
  end
353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388

  describe '#locking_enabled?' do
    before do
      commit_status.lock_version = 100
    end

    subject { commit_status.locking_enabled? }

    context "when changing status" do
      before do
        commit_status.status = "running"
      end

      it "lock" do
        is_expected.to be true
      end

      it "raise exception when trying to update" do
        expect{ commit_status.save }.to raise_error(ActiveRecord::StaleObjectError)
      end
    end

    context "when changing description" do
      before do
        commit_status.description = "test"
      end

      it "do not lock" do
        is_expected.to be false
      end

      it "save correctly" do
        expect(commit_status.save).to be true
      end
    end
  end
389
end