BigW Consortium Gitlab

issues_spec.rb 17.5 KB
Newer Older
gitlabhq committed
1 2
require 'spec_helper'

3
describe 'Issues', feature: true do
4
  include IssueHelpers
Dmitriy Zaporozhets committed
5 6
  include SortingHelper

7
  let(:project) { create(:project) }
gitlabhq committed
8

Nihad Abbasov committed
9
  before do
gitlabhq committed
10
    login_as :user
Riyad Preukschas committed
11
    user2 = create(:user)
gitlabhq committed
12

13
    project.team << [[@user, user2], :developer]
gitlabhq committed
14 15
  end

16
  describe 'Edit issue' do
Riyad Preukschas committed
17 18 19 20 21 22 23
    let!(:issue) do
      create(:issue,
             author: @user,
             assignee: @user,
             project: project)
    end

Nihad Abbasov committed
24
    before do
25
      visit edit_namespace_project_issue_path(project.namespace, project, issue)
Jacob Schatz committed
26
      find('.js-zen-enter').click
gitlabhq committed
27 28
    end

29
    it 'opens new issue popup' do
30
      expect(page).to have_content("Issue ##{issue.iid}")
gitlabhq committed
31 32
    end

33
    describe 'fill in' do
gitlabhq committed
34
      before do
35 36
        fill_in 'issue_title', with: 'bug 345'
        fill_in 'issue_description', with: 'bug description'
gitlabhq committed
37 38
      end
    end
39 40
  end

41
  describe 'Editing issue assignee' do
42 43 44 45 46 47 48
    let!(:issue) do
      create(:issue,
             author: @user,
             assignee: @user,
             project: project)
    end

49
    it 'allows user to select unassigned', js: true do
Vinnie Okada committed
50
      visit edit_namespace_project_issue_path(project.namespace, project, issue)
51

52
      expect(page).to have_content "Assignee #{@user.name}"
53

54 55 56
      first('#s2id_issue_assignee_id').click
      sleep 2 # wait for ajax stuff to complete
      first('.user-result').click
57

58
      click_button 'Save changes'
59

60
      page.within('.assignee') do
61
        expect(page).to have_content 'No assignee - assign yourself'
62 63
      end

64
      expect(issue.reload.assignee).to be_nil
65
    end
gitlabhq committed
66
  end
67

Phil Hughes committed
68 69 70 71 72 73
  describe 'due date', js: true do
    context 'on new form' do
      before do
        visit new_namespace_project_issue_path(project.namespace, project)
      end

74
      it 'saves with due date' do
Phil Hughes committed
75 76 77 78
        date = Date.today.at_beginning_of_month

        fill_in 'issue_title', with: 'bug 345'
        fill_in 'issue_description', with: 'bug description'
Phil Hughes committed
79
        find('#issuable-due-date').click
Phil Hughes committed
80

Phil Hughes committed
81
        page.within '.ui-datepicker' do
Phil Hughes committed
82 83 84
          click_link date.day
        end

Phil Hughes committed
85
        expect(find('#issuable-due-date').value).to eq date.to_s
Phil Hughes committed
86 87 88 89 90 91 92 93 94 95

        click_button 'Submit issue'

        page.within '.issuable-sidebar' do
          expect(page).to have_content date.to_s(:medium)
        end
      end
    end

    context 'on edit form' do
96
      let(:issue) { create(:issue, author: @user, project: project, due_date: Date.today.at_beginning_of_month.to_s) }
Phil Hughes committed
97 98 99 100 101

      before do
        visit edit_namespace_project_issue_path(project.namespace, project, issue)
      end

102
      it 'saves with due date' do
Phil Hughes committed
103 104
        date = Date.today.at_beginning_of_month

Phil Hughes committed
105
        expect(find('#issuable-due-date').value).to eq date.to_s
Phil Hughes committed
106 107 108 109 110

        date = date.tomorrow

        fill_in 'issue_title', with: 'bug 345'
        fill_in 'issue_description', with: 'bug description'
Phil Hughes committed
111
        find('#issuable-due-date').click
Phil Hughes committed
112

Phil Hughes committed
113
        page.within '.ui-datepicker' do
Phil Hughes committed
114 115 116
          click_link date.day
        end

Phil Hughes committed
117
        expect(find('#issuable-due-date').value).to eq date.to_s
Phil Hughes committed
118 119 120 121 122 123 124 125 126 127

        click_button 'Save changes'

        page.within '.issuable-sidebar' do
          expect(page).to have_content date.to_s(:medium)
        end
      end
    end
  end

128 129 130
  describe 'Issue info' do
    it 'excludes award_emoji from comment count' do
      issue = create(:issue, author: @user, assignee: @user, project: project, title: 'foobar')
131
      create(:award_emoji, awardable: issue)
132 133 134 135 136 137 138 139

      visit namespace_project_issues_path(project.namespace, project, assignee_id: @user.id)

      expect(page).to have_content 'foobar'
      expect(page.all('.issue-no-comments').first.text).to eq "0"
    end
  end

140
  describe 'Filter issue' do
141 142
    before do
      ['foobar', 'barbaz', 'gitlab'].each do |title|
Riyad Preukschas committed
143 144 145 146 147
        create(:issue,
               author: @user,
               assignee: @user,
               project: project,
               title: title)
148 149
      end

Dmitriy Zaporozhets committed
150
      @issue = Issue.find_by(title: 'foobar')
151 152 153
      @issue.milestone = create(:milestone, project: project)
      @issue.assignee = nil
      @issue.save
154 155
    end

156
    let(:issue) { @issue }
Riyad Preukschas committed
157

158
    it 'allows filtering by issues with no specified assignee' do
159
      visit namespace_project_issues_path(project.namespace, project, assignee_id: IssuableFinder::NONE)
160

161 162 163
      expect(page).to have_content 'foobar'
      expect(page).not_to have_content 'barbaz'
      expect(page).not_to have_content 'gitlab'
164 165
    end

166
    it 'allows filtering by a specified assignee' do
Vinnie Okada committed
167
      visit namespace_project_issues_path(project.namespace, project, assignee_id: @user.id)
168

169 170 171
      expect(page).not_to have_content 'foobar'
      expect(page).to have_content 'barbaz'
      expect(page).to have_content 'gitlab'
172
    end
173
  end
174 175

  describe 'filter issue' do
Rémy Coutable committed
176
    titles = %w[foo bar baz]
177
    titles.each_with_index do |title, index|
178 179 180 181 182
      let!(title.to_sym) do
        create(:issue, title: title,
                       project: project,
                       created_at: Time.now - (index * 60))
      end
183
    end
184 185
    let(:newer_due_milestone) { create(:milestone, due_date: '2013-12-11') }
    let(:later_due_milestone) { create(:milestone, due_date: '2013-12-12') }
186 187

    it 'sorts by newest' do
Vinnie Okada committed
188
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_recently_created)
189

190 191
      expect(first_issue).to include('foo')
      expect(last_issue).to include('baz')
192 193 194
    end

    it 'sorts by oldest' do
Vinnie Okada committed
195
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_oldest_created)
196

197 198
      expect(first_issue).to include('baz')
      expect(last_issue).to include('foo')
199 200 201 202 203
    end

    it 'sorts by most recently updated' do
      baz.updated_at = Time.now + 100
      baz.save
Vinnie Okada committed
204
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_recently_updated)
205

206
      expect(first_issue).to include('baz')
207 208 209 210 211
    end

    it 'sorts by least recently updated' do
      baz.updated_at = Time.now - 100
      baz.save
Vinnie Okada committed
212
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_oldest_updated)
213

214
      expect(first_issue).to include('baz')
215 216
    end

217
    describe 'sorting by due date' do
218
      before do
Rémy Coutable committed
219 220
        foo.update(due_date: 1.day.from_now)
        bar.update(due_date: 6.days.from_now)
221 222 223 224
      end

      it 'sorts by recently due date' do
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_soon)
Rémy Coutable committed
225

226 227 228 229 230
        expect(first_issue).to include('foo')
      end

      it 'sorts by least recently due date' do
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_later)
Rémy Coutable committed
231

232 233 234 235 236
        expect(first_issue).to include('bar')
      end

      it 'sorts by least recently due date by excluding nil due dates' do
        bar.update(due_date: nil)
Rémy Coutable committed
237

238
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_later)
Rémy Coutable committed
239

240 241
        expect(first_issue).to include('foo')
      end
242 243 244 245 246 247 248 249 250 251 252 253 254

      context 'with a filter on labels' do
        let(:label) { create(:label, project: project) }
        before { create(:label_link, label: label, target: foo) }

        it 'sorts by least recently due date by excluding nil due dates' do
          bar.update(due_date: nil)

          visit namespace_project_issues_path(project.namespace, project, label_names: [label.name], sort: sort_value_due_date_later)

          expect(first_issue).to include('foo')
        end
      end
255 256 257
    end

    describe 'filtering by due date' do
Rémy Coutable committed
258 259 260
      before do
        foo.update(due_date: 1.day.from_now)
        bar.update(due_date: 6.days.from_now)
261 262 263
      end

      it 'filters by none' do
264
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::NoDueDate.name)
Rémy Coutable committed
265 266 267 268

        expect(page).not_to have_content('foo')
        expect(page).not_to have_content('bar')
        expect(page).to have_content('baz')
269 270 271
      end

      it 'filters by any' do
272
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::AnyDueDate.name)
Rémy Coutable committed
273 274 275 276

        expect(page).to have_content('foo')
        expect(page).to have_content('bar')
        expect(page).to have_content('baz')
277 278
      end

279 280 281 282
      it 'filters by due this week' do
        foo.update(due_date: Date.today.beginning_of_week + 2.days)
        bar.update(due_date: Date.today.end_of_week)
        baz.update(due_date: Date.today - 8.days)
Rémy Coutable committed
283

284
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::DueThisWeek.name)
Rémy Coutable committed
285 286 287 288

        expect(page).to have_content('foo')
        expect(page).to have_content('bar')
        expect(page).not_to have_content('baz')
289 290
      end

291 292 293 294
      it 'filters by due this month' do
        foo.update(due_date: Date.today.beginning_of_month + 2.days)
        bar.update(due_date: Date.today.end_of_month)
        baz.update(due_date: Date.today - 50.days)
Rémy Coutable committed
295

296
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::DueThisMonth.name)
Rémy Coutable committed
297 298 299 300

        expect(page).to have_content('foo')
        expect(page).to have_content('bar')
        expect(page).not_to have_content('baz')
301 302
      end

303 304 305 306 307
      it 'filters by overdue' do
        foo.update(due_date: Date.today + 2.days)
        bar.update(due_date: Date.today + 20.days)
        baz.update(due_date: Date.yesterday)

Rémy Coutable committed
308 309 310 311 312 313
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::Overdue.name)

        expect(page).not_to have_content('foo')
        expect(page).not_to have_content('bar')
        expect(page).to have_content('baz')
      end
314 315
    end

316
    describe 'sorting by milestone' do
Rémy Coutable committed
317
      before do
318 319 320 321 322 323 324
        foo.milestone = newer_due_milestone
        foo.save
        bar.milestone = later_due_milestone
        bar.save
      end

      it 'sorts by recently due milestone' do
Vinnie Okada committed
325
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_milestone_soon)
326

327
        expect(first_issue).to include('foo')
328
        expect(last_issue).to include('baz')
329 330 331
      end

      it 'sorts by least recently due milestone' do
Vinnie Okada committed
332
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_milestone_later)
333

334
        expect(first_issue).to include('bar')
335
        expect(last_issue).to include('baz')
336 337 338 339 340 341
      end
    end

    describe 'combine filter and sort' do
      let(:user2) { create(:user) }

Rémy Coutable committed
342
      before do
343 344 345 346 347 348 349
        foo.assignee = user2
        foo.save
        bar.assignee = user2
        bar.save
      end

      it 'sorts with a filter applied' do
Vinnie Okada committed
350 351 352
        visit namespace_project_issues_path(project.namespace, project,
                                            sort: sort_value_oldest_created,
                                            assignee_id: user2.id)
353

354 355
        expect(first_issue).to include('bar')
        expect(last_issue).to include('foo')
356
        expect(page).not_to have_content 'baz'
357 358 359
      end
    end
  end
360

361
  describe 'update assignee from issue#show' do
362
    let(:issue) { create(:issue, project: project, author: @user, assignee: @user) }
363

364
    context 'by authorized user' do
365
      it 'allows user to select unassigned', js: true do
Vinnie Okada committed
366
        visit namespace_project_issue_path(project.namespace, project, issue)
367

368 369 370
        page.within('.assignee') do
          expect(page).to have_content "#{@user.name}"

Phil Hughes committed
371 372
          click_link 'Edit'
          click_link 'Unassigned'
373 374
          expect(page).to have_content 'No assignee'
        end
375

376
        expect(issue.reload.assignee).to be_nil
377
      end
378 379 380 381 382 383 384 385 386 387 388 389

      it 'allows user to select an assignee', js: true do
        issue2 = create(:issue, project: project, author: @user)
        visit namespace_project_issue_path(project.namespace, project, issue2)

        page.within('.assignee') do
          expect(page).to have_content "No assignee"
        end

        page.within '.assignee' do
          click_link 'Edit'
        end
Phil Hughes committed
390

391 392 393 394 395 396 397 398
        page.within '.dropdown-menu-user' do
          click_link @user.name
        end

        page.within('.assignee') do
          expect(page).to have_content @user.name
        end
      end
399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419

      it 'allows user to unselect themselves', js: true do
        issue2 = create(:issue, project: project, author: @user)
        visit namespace_project_issue_path(project.namespace, project, issue2)

        page.within '.assignee' do
          click_link 'Edit'
          click_link @user.name

          page.within '.value' do
            expect(page).to have_content @user.name
          end

          click_link 'Edit'
          click_link @user.name

          page.within '.value' do
            expect(page).to have_content "No assignee"
          end
        end
      end
420 421 422 423
    end

    context 'by unauthorized user' do
      let(:guest) { create(:user) }
Dmitriy Zaporozhets committed
424

Rémy Coutable committed
425
      before do
426 427 428
        project.team << [[guest], :guest]
      end

429
      it 'shows assignee text', js: true do
430 431 432
        logout
        login_with guest

Vinnie Okada committed
433
        visit namespace_project_issue_path(project.namespace, project, issue)
434
        expect(page).to have_content issue.assignee.name
435 436 437 438 439 440 441 442 443
      end
    end
  end

  describe 'update milestone from issue#show' do
    let!(:issue) { create(:issue, project: project, author: @user) }
    let!(:milestone) { create(:milestone, project: project) }

    context 'by authorized user' do
444 445
      it 'allows user to select unassigned', js: true do
        visit namespace_project_issue_path(project.namespace, project, issue)
446

447 448 449
        page.within('.milestone') do
          expect(page).to have_content "None"
        end
450

451 452 453 454
        find('.block.milestone .edit-link').click
        sleep 2 # wait for ajax stuff to complete
        first('.dropdown-content li').click
        sleep 2
455
        page.within('.milestone') do
456
          expect(page).to have_content 'None'
457 458
        end

459
        expect(issue.reload.milestone).to be_nil
460
      end
461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480

      it 'allows user to de-select milestone', js: true do
        visit namespace_project_issue_path(project.namespace, project, issue)

        page.within('.milestone') do
          click_link 'Edit'
          click_link milestone.title

          page.within '.value' do
            expect(page).to have_content milestone.title
          end

          click_link 'Edit'
          click_link milestone.title

          page.within '.value' do
            expect(page).to have_content 'None'
          end
        end
      end
481 482 483 484
    end

    context 'by unauthorized user' do
      let(:guest) { create(:user) }
Dmitriy Zaporozhets committed
485

Rémy Coutable committed
486
      before do
Dmitriy Zaporozhets committed
487
        project.team << [guest, :guest]
488 489 490 491
        issue.milestone = milestone
        issue.save
      end

492
      it 'shows milestone text', js: true do
493 494 495
        logout
        login_with guest

Vinnie Okada committed
496
        visit namespace_project_issue_path(project.namespace, project, issue)
497
        expect(page).to have_content milestone.title
498 499
      end
    end
500 501 502 503

    describe 'removing assignee' do
      let(:user2) { create(:user) }

Rémy Coutable committed
504
      before do
505 506 507 508
        issue.assignee = user2
        issue.save
      end
    end
509 510
  end

511 512 513 514 515 516
  describe 'new issue' do
    context 'dropzone upload file', js: true do
      before do
        visit new_namespace_project_issue_path(project.namespace, project)
      end

517
      it 'uploads file when dragging into textarea' do
518 519 520 521 522 523 524 525 526 527
        drop_in_dropzone test_image_file

        # Wait for the file to upload
        sleep 1

        expect(page.find_field("issue_description").value).to have_content 'banana_sample'
      end
    end
  end

528
  describe 'new issue by email' do
529
    shared_examples 'show the email in the modal' do
530 531 532 533 534 535 536
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")

        visit namespace_project_issues_path(project.namespace, project)
        click_button('Email a new issue')
      end

537
      it 'click the button to show modal for the new email' do
538 539 540 541 542 543 544
        page.within '#issue-email-modal' do
          email = project.new_issue_address(@user)

          expect(page).to have_selector("input[value='#{email}']")
        end
      end
    end
545 546 547 548 549 550 551 552 553 554

    context 'with existing issues' do
      let!(:issue) { create(:issue, project: project, author: @user) }

      it_behaves_like 'show the email in the modal'
    end

    context 'without existing issues' do
      it_behaves_like 'show the email in the modal'
    end
555 556
  end

Phil Hughes committed
557 558 559 560 561 562 563 564
  describe 'due date' do
    context 'update due on issue#show', js: true do
      let(:issue) { create(:issue, project: project, author: @user, assignee: @user) }

      before do
        visit namespace_project_issue_path(project.namespace, project, issue)
      end

565
      it 'adds due date to issue' do
Phil Hughes committed
566 567 568 569 570 571 572 573 574 575 576
        page.within '.due_date' do
          click_link 'Edit'

          page.within '.ui-datepicker-calendar' do
            first('.ui-state-default').click
          end

          expect(page).to have_no_content 'None'
        end
      end

577
      it 'removes due date from issue' do
Phil Hughes committed
578 579 580 581 582 583 584
        page.within '.due_date' do
          click_link 'Edit'

          page.within '.ui-datepicker-calendar' do
            first('.ui-state-default').click
          end

Phil Hughes committed
585
          expect(page).to have_no_content 'No due date'
Phil Hughes committed
586 587

          click_link 'remove due date'
Phil Hughes committed
588
          expect(page).to have_content 'No due date'
Phil Hughes committed
589 590 591 592 593
        end
      end
    end
  end

594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613
  def drop_in_dropzone(file_path)
    # Generate a fake input selector
    page.execute_script <<-JS
      var fakeFileInput = window.$('<input/>').attr(
        {id: 'fakeFileInput', type: 'file'}
      ).appendTo('body');
    JS
    # Attach the file to the fake input selector with Capybara
    attach_file("fakeFileInput", file_path)
    # Add the file to a fileList array and trigger the fake drop event
    page.execute_script <<-JS
      var fileList = [$('#fakeFileInput')[0].files[0]];
      var e = jQuery.Event('drop', { dataTransfer : { files : fileList } });
      $('.div-dropzone')[0].dropzone.listeners[0].events.drop(e);
    JS
  end

  def test_image_file
    File.join(Rails.root, 'spec', 'fixtures', 'banana_sample.gif')
  end
Dmitriy Zaporozhets committed
614
end