BigW Consortium Gitlab

issues_finder_spec.rb 16 KB
Newer Older
1 2
require 'spec_helper'

3
describe IssuesFinder do
4 5
  set(:user) { create(:user) }
  set(:user2) { create(:user) }
6 7
  set(:project1) { create(:project) }
  set(:project2) { create(:project) }
8 9
  set(:milestone) { create(:milestone, project: project1) }
  set(:label) { create(:label, project: project2) }
10
  set(:issue1) { create(:issue, author: user, assignees: [user], project: project1, milestone: milestone, title: 'gitlab', created_at: 1.week.ago) }
11
  set(:issue2) { create(:issue, author: user, assignees: [user], project: project2, description: 'gitlab') }
12
  set(:issue3) { create(:issue, author: user2, assignees: [user2], project: project2, title: 'tanuki', description: 'tanuki', created_at: 1.week.from_now) }
13 14 15
  set(:award_emoji1) { create(:award_emoji, name: 'thumbsup', user: user, awardable: issue1) }
  set(:award_emoji2) { create(:award_emoji, name: 'thumbsup', user: user2, awardable: issue2) }
  set(:award_emoji3) { create(:award_emoji, name: 'thumbsdown', user: user, awardable: issue3) }
16

17
  describe '#execute' do
18 19
    let!(:closed_issue) { create(:issue, author: user2, assignees: [user2], project: project2, state: 'closed') }
    let!(:label_link) { create(:label_link, label: label, target: issue2) }
20 21
    let(:search_user) { user }
    let(:params) { {} }
22
    let(:issues) { described_class.new(search_user, params.reverse_merge(scope: scope, state: 'opened')).execute }
23

24
    before(:context) do
25 26 27
      project1.add_master(user)
      project2.add_developer(user)
      project2.add_developer(user2)
28 29 30 31

      issue1
      issue2
      issue3
32 33 34 35

      award_emoji1
      award_emoji2
      award_emoji3
36 37
    end

38
    context 'scope: all' do
39
      let(:scope) { 'all' }
40

41 42
      it 'returns all issues' do
        expect(issues).to contain_exactly(issue1, issue2, issue3)
43
      end
44

45 46 47 48 49 50
      context 'filtering by assignee ID' do
        let(:params) { { assignee_id: user.id } }

        it 'returns issues assigned to that user' do
          expect(issues).to contain_exactly(issue1, issue2)
        end
51
      end
52

53 54 55 56 57 58
      context 'filtering by author ID' do
        let(:params) { { author_id: user2.id } }

        it 'returns issues created by that user' do
          expect(issues).to contain_exactly(issue3)
        end
59 60
      end

61 62 63 64 65 66
      context 'filtering by milestone' do
        let(:params) { { milestone_title: milestone.title } }

        it 'returns issues assigned to that milestone' do
          expect(issues).to contain_exactly(issue1)
        end
67 68
      end

Felipe Artur committed
69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85
      context 'filtering by group milestone' do
        let!(:group) { create(:group, :public) }
        let(:group_milestone) { create(:milestone, group: group) }
        let!(:group_member) { create(:group_member, group: group, user: user) }
        let(:params) { { milestone_title: group_milestone.title } }

        before do
          project2.update(namespace: group)
          issue2.update(milestone: group_milestone)
          issue3.update(milestone: group_milestone)
        end

        it 'returns issues assigned to that group milestone' do
          expect(issues).to contain_exactly(issue2, issue3)
        end
      end

86 87 88 89 90 91
      context 'filtering by no milestone' do
        let(:params) { { milestone_title: Milestone::None.title } }

        it 'returns issues with no milestone' do
          expect(issues).to contain_exactly(issue2, issue3)
        end
92 93
      end

94 95 96
      context 'filtering by upcoming milestone' do
        let(:params) { { milestone_title: Milestone::Upcoming.name } }

97 98 99
        let(:project_no_upcoming_milestones) { create(:project, :public) }
        let(:project_next_1_1) { create(:project, :public) }
        let(:project_next_8_8) { create(:project, :public) }
100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117

        let(:yesterday) { Date.today - 1.day }
        let(:tomorrow) { Date.today + 1.day }
        let(:two_days_from_now) { Date.today + 2.days }
        let(:ten_days_from_now) { Date.today + 10.days }

        let(:milestones) do
          [
            create(:milestone, :closed, project: project_no_upcoming_milestones),
            create(:milestone, project: project_next_1_1, title: '1.1', due_date: two_days_from_now),
            create(:milestone, project: project_next_1_1, title: '8.8', due_date: ten_days_from_now),
            create(:milestone, project: project_next_8_8, title: '1.1', due_date: yesterday),
            create(:milestone, project: project_next_8_8, title: '8.8', due_date: tomorrow)
          ]
        end

        before do
          milestones.each do |milestone|
118
            create(:issue, project: milestone.project, milestone: milestone, author: user, assignees: [user])
119 120 121 122 123 124 125 126 127
          end
        end

        it 'returns issues in the upcoming milestone for each project' do
          expect(issues.map { |issue| issue.milestone.title }).to contain_exactly('1.1', '8.8')
          expect(issues.map { |issue| issue.milestone.due_date }).to contain_exactly(tomorrow, two_days_from_now)
        end
      end

128 129 130
      context 'filtering by started milestone' do
        let(:params) { { milestone_title: Milestone::Started.name } }

131 132 133
        let(:project_no_started_milestones) { create(:project, :public) }
        let(:project_started_1_and_2) { create(:project, :public) }
        let(:project_started_8) { create(:project, :public) }
134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152

        let(:yesterday) { Date.today - 1.day }
        let(:tomorrow) { Date.today + 1.day }
        let(:two_days_ago) { Date.today - 2.days }

        let(:milestones) do
          [
            create(:milestone, project: project_no_started_milestones, start_date: tomorrow),
            create(:milestone, project: project_started_1_and_2, title: '1.0', start_date: two_days_ago),
            create(:milestone, project: project_started_1_and_2, title: '2.0', start_date: yesterday),
            create(:milestone, project: project_started_1_and_2, title: '3.0', start_date: tomorrow),
            create(:milestone, project: project_started_8, title: '7.0'),
            create(:milestone, project: project_started_8, title: '8.0', start_date: yesterday),
            create(:milestone, project: project_started_8, title: '9.0', start_date: tomorrow)
          ]
        end

        before do
          milestones.each do |milestone|
153
            create(:issue, project: milestone.project, milestone: milestone, author: user, assignees: [user])
154 155 156 157 158 159 160 161 162
          end
        end

        it 'returns issues in the started milestones for each project' do
          expect(issues.map { |issue| issue.milestone.title }).to contain_exactly('1.0', '2.0', '8.0')
          expect(issues.map { |issue| issue.milestone.start_date }).to contain_exactly(two_days_ago, yesterday, yesterday)
        end
      end

163 164
      context 'filtering by label' do
        let(:params) { { label_name: label.title } }
165

166 167 168 169
        it 'returns issues with that label' do
          expect(issues).to contain_exactly(issue2)
        end
      end
170

171 172 173
      context 'filtering by multiple labels' do
        let(:params) { { label_name: [label.title, label2.title].join(',') } }
        let(:label2) { create(:label, project: project2) }
174

175 176 177
        before do
          create(:label_link, label: label2, target: issue2)
        end
178

179 180 181
        it 'returns the unique issues with any of those labels' do
          expect(issues).to contain_exactly(issue2)
        end
182 183
      end

184 185 186 187 188 189
      context 'filtering by no label' do
        let(:params) { { label_name: Label::None.title } }

        it 'returns issues with no labels' do
          expect(issues).to contain_exactly(issue1, issue3)
        end
190 191
      end

barthc committed
192 193 194 195 196 197 198 199
      context 'filtering by issue term' do
        let(:params) { { search: 'git' } }

        it 'returns issues with title and description match for search term' do
          expect(issues).to contain_exactly(issue1, issue2)
        end
      end

200 201
      context 'filtering by issues iids' do
        let(:params) { { iids: issue3.iid } }
barthc committed
202

203
        it 'returns issues with iids match' do
barthc committed
204 205 206 207
          expect(issues).to contain_exactly(issue3)
        end
      end

208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241
      context 'filtering by state' do
        context 'with opened' do
          let(:params) { { state: 'opened' } }

          it 'returns only opened issues' do
            expect(issues).to contain_exactly(issue1, issue2, issue3)
          end
        end

        context 'with closed' do
          let(:params) { { state: 'closed' } }

          it 'returns only closed issues' do
            expect(issues).to contain_exactly(closed_issue)
          end
        end

        context 'with all' do
          let(:params) { { state: 'all' } }

          it 'returns all issues' do
            expect(issues).to contain_exactly(issue1, issue2, issue3, closed_issue)
          end
        end

        context 'with invalid state' do
          let(:params) { { state: 'invalid_state' } }

          it 'returns all issues' do
            expect(issues).to contain_exactly(issue1, issue2, issue3, closed_issue)
          end
        end
      end

242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259
      context 'filtering by created_at' do
        context 'through created_after' do
          let(:params) { { created_after: issue3.created_at } }

          it 'returns issues created on or after the given date' do
            expect(issues).to contain_exactly(issue3)
          end
        end

        context 'through created_before' do
          let(:params) { { created_before: issue1.created_at + 1.second } }

          it 'returns issues created on or before the given date' do
            expect(issues).to contain_exactly(issue1)
          end
        end
      end

260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287
      context 'filtering by reaction name' do
        context 'user searches by "thumbsup" reaction' do
          let(:params) { { my_reaction_emoji: 'thumbsup' } }

          it 'returns issues that the user thumbsup to' do
            expect(issues).to contain_exactly(issue1)
          end
        end

        context 'user2 searches by "thumbsup" reaction' do
          let(:search_user) { user2 }

          let(:params) { { my_reaction_emoji: 'thumbsup' } }

          it 'returns issues that the user2 thumbsup to' do
            expect(issues).to contain_exactly(issue2)
          end
        end

        context 'user searches by "thumbsdown" reaction' do
          let(:params) { { my_reaction_emoji: 'thumbsdown' } }

          it 'returns issues that the user thumbsdown to' do
            expect(issues).to contain_exactly(issue3)
          end
        end
      end

288 289 290 291 292 293
      context 'when the user is unauthorized' do
        let(:search_user) { nil }

        it 'returns no results' do
          expect(issues).to be_empty
        end
294 295
      end

296 297 298 299 300 301
      context 'when the user can see some, but not all, issues' do
        let(:search_user) { user2 }

        it 'returns only issues they can see' do
          expect(issues).to contain_exactly(issue2, issue3)
        end
302
      end
303 304 305

      it 'finds issues user can access due to group' do
        group = create(:group)
306
        project = create(:project, group: group)
307 308 309 310 311
        issue = create(:issue, project: project)
        group.add_user(user, :owner)

        expect(issues).to include(issue)
      end
312 313
    end

314
    context 'personal scope' do
315 316 317 318
      let(:scope) { 'assigned-to-me' }

      it 'returns issue assigned to the user' do
        expect(issues).to contain_exactly(issue1, issue2)
319 320
      end

321 322 323 324 325 326
      context 'filtering by project' do
        let(:params) { { project_id: project1.id } }

        it 'returns issues assigned to the user in that project' do
          expect(issues).to contain_exactly(issue1)
        end
327
      end
328
    end
329 330 331 332 333

    context 'when project restricts issues' do
      let(:scope) { nil }

      it "doesn't return team-only issues to non team members" do
334
        project = create(:project, :public, :issues_private)
335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
        issue = create(:issue, project: project)

        expect(issues).not_to include(issue)
      end

      it "doesn't return issues if feature disabled" do
        [project1, project2].each do |project|
          project.project_feature.update!(issues_access_level: ProjectFeature::DISABLED)
        end

        expect(issues.count).to eq 0
      end
    end
  end

350 351 352 353 354 355 356 357 358 359 360 361 362 363
  describe '#row_count', :request_store do
    it 'returns the number of rows for the default state' do
      finder = described_class.new(user)

      expect(finder.row_count).to eq(3)
    end

    it 'returns the number of rows for a given state' do
      finder = described_class.new(user, state: 'closed')

      expect(finder.row_count).to be_zero
    end
  end

364
  describe '#with_confidentiality_access_check' do
365 366
    let(:guest) { create(:user) }
    set(:authorized_user) { create(:user) }
367
    set(:project) { create(:project, namespace: authorized_user.namespace) }
368 369 370 371 372 373 374
    set(:public_issue) { create(:issue, project: project) }
    set(:confidential_issue) { create(:issue, project: project, confidential: true) }

    context 'when no project filter is given' do
      let(:params) { {} }

      context 'for an anonymous user' do
375
        subject { described_class.new(nil, params).with_confidentiality_access_check }
376 377 378 379 380 381 382 383

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end
      end

      context 'for a user without project membership' do
384
        subject { described_class.new(user, params).with_confidentiality_access_check }
385 386 387 388 389 390 391 392

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end
      end

      context 'for a guest user' do
393
        subject { described_class.new(guest, params).with_confidentiality_access_check }
394 395 396 397 398 399 400 401 402 403 404 405

        before do
          project.add_guest(guest)
        end

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end
      end

      context 'for a project member with access to view confidential issues' do
406
        subject { described_class.new(authorized_user, params).with_confidentiality_access_check }
407

408 409 410 411
        it 'returns all issues' do
          expect(subject).to include(public_issue, confidential_issue)
        end
      end
412 413
    end

414 415 416 417
    context 'when searching within a specific project' do
      let(:params) { { project_id: project.id } }

      context 'for an anonymous user' do
418
        subject { described_class.new(nil, params).with_confidentiality_access_check }
419 420 421 422 423 424 425 426 427 428 429 430 431 432

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end

        it 'does not filter by confidentiality' do
          expect(Issue).not_to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end

      context 'for a user without project membership' do
433
        subject { described_class.new(user, params).with_confidentiality_access_check }
434 435 436 437 438 439 440 441 442 443 444 445 446 447

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end

        it 'filters by confidentiality' do
          expect(Issue).to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end

      context 'for a guest user' do
448
        subject { described_class.new(guest, params).with_confidentiality_access_check }
449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466

        before do
          project.add_guest(guest)
        end

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end

        it 'filters by confidentiality' do
          expect(Issue).to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end

      context 'for a project member with access to view confidential issues' do
467
        subject { described_class.new(authorized_user, params).with_confidentiality_access_check }
468 469 470 471 472 473 474 475 476 477 478

        it 'returns all issues' do
          expect(subject).to include(public_issue, confidential_issue)
        end

        it 'does not filter by confidentiality' do
          expect(Issue).not_to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end
479
    end
480 481
  end
end