BigW Consortium Gitlab

lfs_http_spec.rb 38.7 KB
Newer Older
1 2
require 'spec_helper'

Jacob Vosmaer committed
3
describe 'Git LFS API and storage' do
4
  include WorkhorseHelpers
5
  include ProjectForksHelper
6

7 8 9 10 11 12 13 14 15 16 17
  let(:user) { create(:user) }
  let!(:lfs_object) { create(:lfs_object, :with_file) }

  let(:headers) do
    {
      'Authorization' => authorization,
      'X-Sendfile-Type' => sendfile
    }.compact
  end
  let(:authorization) { }
  let(:sendfile) { }
18
  let(:pipeline) { create(:ci_empty_pipeline, project: project) }
19 20 21 22 23

  let(:sample_oid) { lfs_object.oid }
  let(:sample_size) { lfs_object.size }

  describe 'when lfs is disabled' do
24
    let(:project) { create(:project) }
25 26 27 28
    let(:body) do
      {
        'objects' => [
          { 'oid' => '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897',
29
            'size' => 1575078 },
30
          { 'oid' => sample_oid,
31
            'size' => sample_size }
32 33 34 35
        ],
        'operation' => 'upload'
      }
    end
Jacob Vosmaer committed
36
    let(:authorization) { authorize_user }
37 38 39

    before do
      allow(Gitlab.config.lfs).to receive(:enabled).and_return(false)
40
      post_lfs_json "#{project.http_url_to_repo}/info/lfs/objects/batch", body, headers
41 42 43
    end

    it 'responds with 501' do
44
      expect(response).to have_gitlab_http_status(501)
45 46 47 48
      expect(json_response).to include('message' => 'Git LFS is not enabled on this GitLab server, contact your admin.')
    end
  end

49
  context 'project specific LFS settings' do
50
    let(:project) { create(:project) }
51 52 53 54
    let(:body) do
      {
        'objects' => [
          { 'oid' => '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897',
55
            'size' => 1575078 },
56
          { 'oid' => sample_oid,
57
            'size' => sample_size }
58 59 60 61 62 63 64 65
        ],
        'operation' => 'upload'
      }
    end
    let(:authorization) { authorize_user }

    context 'with LFS disabled globally' do
      before do
66
        project.add_master(user)
67 68 69 70 71
        allow(Gitlab.config.lfs).to receive(:enabled).and_return(false)
      end

      describe 'LFS disabled in project' do
        before do
72
          project.update_attribute(:lfs_enabled, false)
73 74 75 76 77
        end

        it 'responds with a 501 message on upload' do
          post_lfs_json "#{project.http_url_to_repo}/info/lfs/objects/batch", body, headers

78
          expect(response).to have_gitlab_http_status(501)
79 80 81 82 83
        end

        it 'responds with a 501 message on download' do
          get "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}", nil, headers

84
          expect(response).to have_gitlab_http_status(501)
85 86 87 88 89
        end
      end

      describe 'LFS enabled in project' do
        before do
90
          project.update_attribute(:lfs_enabled, true)
91 92 93 94 95
        end

        it 'responds with a 501 message on upload' do
          post_lfs_json "#{project.http_url_to_repo}/info/lfs/objects/batch", body, headers

96
          expect(response).to have_gitlab_http_status(501)
97 98 99 100 101
        end

        it 'responds with a 501 message on download' do
          get "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}", nil, headers

102
          expect(response).to have_gitlab_http_status(501)
103 104 105 106 107 108
        end
      end
    end

    context 'with LFS enabled globally' do
      before do
109
        project.add_master(user)
110 111 112 113 114
        enable_lfs
      end

      describe 'LFS disabled in project' do
        before do
115
          project.update_attribute(:lfs_enabled, false)
116 117 118 119 120
        end

        it 'responds with a 403 message on upload' do
          post_lfs_json "#{project.http_url_to_repo}/info/lfs/objects/batch", body, headers

121
          expect(response).to have_gitlab_http_status(403)
122 123 124 125 126 127
          expect(json_response).to include('message' => 'Access forbidden. Check your access level.')
        end

        it 'responds with a 403 message on download' do
          get "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}", nil, headers

128
          expect(response).to have_gitlab_http_status(403)
129 130 131 132 133 134
          expect(json_response).to include('message' => 'Access forbidden. Check your access level.')
        end
      end

      describe 'LFS enabled in project' do
        before do
135
          project.update_attribute(:lfs_enabled, true)
136 137 138 139 140
        end

        it 'responds with a 200 message on upload' do
          post_lfs_json "#{project.http_url_to_repo}/info/lfs/objects/batch", body, headers

141
          expect(response).to have_gitlab_http_status(200)
142 143 144 145 146 147
          expect(json_response['objects'].first['size']).to eq(1575078)
        end

        it 'responds with a 200 message on download' do
          get "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}", nil, headers

148
          expect(response).to have_gitlab_http_status(200)
149 150 151 152 153
        end
      end
    end
  end

154
  describe 'deprecated API' do
155
    let(:project) { create(:project) }
156 157 158 159 160 161 162

    before do
      enable_lfs
    end

    shared_examples 'a deprecated' do
      it 'responds with 501' do
163
        expect(response).to have_gitlab_http_status(501)
164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181
      end

      it 'returns deprecated message' do
        expect(json_response).to include('message' => 'Server supports batch API only, please update your Git LFS client to version 1.0.1 and up.')
      end
    end

    context 'when fetching lfs object using deprecated API' do
      let(:authorization) { authorize_user }

      before do
        get "#{project.http_url_to_repo}/info/lfs/objects/#{sample_oid}", nil, headers
      end

      it_behaves_like 'a deprecated'
    end

    context 'when handling lfs request using deprecated API' do
Jacob Vosmaer committed
182
      let(:authorization) { authorize_user }
183
      before do
184
        post_lfs_json "#{project.http_url_to_repo}/info/lfs/objects", nil, headers
185 186 187 188 189 190 191
      end

      it_behaves_like 'a deprecated'
    end
  end

  describe 'when fetching lfs object' do
192
    let(:project) { create(:project) }
193 194 195 196 197 198 199 200 201 202 203
    let(:update_permissions) { }

    before do
      enable_lfs
      update_permissions
      get "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}", nil, headers
    end

    context 'and request comes from gitlab-workhorse' do
      context 'without user being authorized' do
        it 'responds with status 401' do
204
          expect(response).to have_gitlab_http_status(401)
205 206 207 208 209
        end
      end

      context 'with required headers' do
        shared_examples 'responds with a file' do
210 211
          let(:sendfile) { 'X-Sendfile' }

212
          it 'responds with status 200' do
213
            expect(response).to have_gitlab_http_status(200)
214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229
          end

          it 'responds with the file location' do
            expect(response.headers['Content-Type']).to eq('application/octet-stream')
            expect(response.headers['X-Sendfile']).to eq(lfs_object.file.path)
          end
        end

        context 'with user is authorized' do
          let(:authorization) { authorize_user }

          context 'and does not have project access' do
            let(:update_permissions) do
              project.lfs_objects << lfs_object
            end

Jacob Vosmaer committed
230
            it 'responds with status 404' do
231
              expect(response).to have_gitlab_http_status(404)
232 233 234 235 236
            end
          end

          context 'and does have project access' do
            let(:update_permissions) do
237
              project.add_master(user)
238 239 240 241 242 243 244
              project.lfs_objects << lfs_object
            end

            it_behaves_like 'responds with a file'
          end
        end

245 246 247 248 249 250 251 252 253 254 255 256
        context 'when deploy key is authorized' do
          let(:key) { create(:deploy_key) }
          let(:authorization) { authorize_deploy_key }

          let(:update_permissions) do
            project.deploy_keys << key
            project.lfs_objects << lfs_object
          end

          it_behaves_like 'responds with a file'
        end

257 258 259 260 261
        describe 'when using a user key' do
          let(:authorization) { authorize_user_key }

          context 'when user allowed' do
            let(:update_permissions) do
262
              project.add_master(user)
263 264 265 266 267 268 269 270 271 272 273 274
              project.lfs_objects << lfs_object
            end

            it_behaves_like 'responds with a file'
          end

          context 'when user not allowed' do
            let(:update_permissions) do
              project.lfs_objects << lfs_object
            end

            it 'responds with status 404' do
275
              expect(response).to have_gitlab_http_status(404)
276 277 278 279
            end
          end
        end

280
        context 'when build is authorized as' do
281 282
          let(:authorization) { authorize_ci_project }

283
          shared_examples 'can download LFS only from own projects' do
284
            context 'for owned project' do
285
              let(:project) { create(:project, namespace: user.namespace) }
286 287 288 289 290 291 292 293 294

              let(:update_permissions) do
                project.lfs_objects << lfs_object
              end

              it_behaves_like 'responds with a file'
            end

            context 'for member of project' do
295 296 297
              let(:pipeline) { create(:ci_empty_pipeline, project: project) }

              let(:update_permissions) do
298
                project.add_reporter(user)
299 300 301 302 303 304 305
                project.lfs_objects << lfs_object
              end

              it_behaves_like 'responds with a file'
            end

            context 'for other project' do
306
              let(:other_project) { create(:project) }
307 308 309 310 311 312 313
              let(:pipeline) { create(:ci_empty_pipeline, project: other_project) }

              let(:update_permissions) do
                project.lfs_objects << lfs_object
              end

              it 'rejects downloading code' do
314
                expect(response).to have_gitlab_http_status(other_project_status)
315 316
              end
            end
317 318
          end

319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342
          context 'administrator' do
            let(:user) { create(:admin) }
            let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

            it_behaves_like 'can download LFS only from own projects' do
              # We render 403, because administrator does have normally access
              let(:other_project_status) { 403 }
            end
          end

          context 'regular user' do
            let(:user) { create(:user) }
            let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

            it_behaves_like 'can download LFS only from own projects' do
              # We render 404, to prevent data leakage about existence of the project
              let(:other_project_status) { 404 }
            end
          end

          context 'does not have user' do
            let(:build) { create(:ci_build, :running, pipeline: pipeline) }

            it_behaves_like 'can download LFS only from own projects' do
343 344
              # We render 404, to prevent data leakage about existence of the project
              let(:other_project_status) { 404 }
345 346
            end
          end
347 348 349 350 351 352
        end
      end

      context 'without required headers' do
        let(:authorization) { authorize_user }

Jacob Vosmaer committed
353
        it 'responds with status 404' do
354
          expect(response).to have_gitlab_http_status(404)
355 356 357 358 359 360 361 362 363 364 365 366 367
        end
      end
    end
  end

  describe 'when handling lfs batch request' do
    let(:update_lfs_permissions) { }
    let(:update_user_permissions) { }

    before do
      enable_lfs
      update_lfs_permissions
      update_user_permissions
368
      post_lfs_json "#{project.http_url_to_repo}/info/lfs/objects/batch", body, headers
369 370 371
    end

    describe 'download' do
372
      let(:project) { create(:project) }
373
      let(:body) do
374 375
        {
          'operation' => 'download',
376 377
          'objects' => [
            { 'oid' => sample_oid,
378
              'size' => sample_size }
379
          ]
380 381 382 383 384 385 386 387 388 389
        }
      end

      shared_examples 'an authorized requests' do
        context 'when downloading an lfs object that is assigned to our project' do
          let(:update_lfs_permissions) do
            project.lfs_objects << lfs_object
          end

          it 'responds with status 200' do
390
            expect(response).to have_gitlab_http_status(200)
391 392 393
          end

          it 'with href to download' do
394 395
            expect(json_response).to eq({
              'objects' => [
396 397
                {
                  'oid' => sample_oid,
398 399 400 401 402 403
                  'size' => sample_size,
                  'actions' => {
                    'download' => {
                      'href' => "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}",
                      'header' => { 'Authorization' => authorization }
                    }
404 405
                  }
                }
406 407
              ]
            })
408 409 410 411
          end
        end

        context 'when downloading an lfs object that is assigned to other project' do
412
          let(:other_project) { create(:project) }
413 414 415 416 417
          let(:update_lfs_permissions) do
            other_project.lfs_objects << lfs_object
          end

          it 'responds with status 200' do
418
            expect(response).to have_gitlab_http_status(200)
419 420 421
          end

          it 'with href to download' do
422 423
            expect(json_response).to eq({
              'objects' => [
424 425
                {
                  'oid' => sample_oid,
426 427 428
                  'size' => sample_size,
                  'error' => {
                    'code' => 404,
429
                    'message' => "Object does not exist on the server or you don't have permissions to access it"
430
                  }
431
                }
432 433
              ]
            })
434 435 436 437 438
          end
        end

        context 'when downloading a lfs object that does not exist' do
          let(:body) do
439 440
            {
              'operation' => 'download',
441 442
              'objects' => [
                { 'oid' => '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897',
443
                  'size' => 1575078 }
444
              ]
445 446 447 448
            }
          end

          it 'responds with status 200' do
449
            expect(response).to have_gitlab_http_status(200)
450 451 452
          end

          it 'with an 404 for specific object' do
453 454
            expect(json_response).to eq({
              'objects' => [
455 456
                {
                  'oid' => '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897',
457 458 459
                  'size' => 1575078,
                  'error' => {
                    'code' => 404,
460
                    'message' => "Object does not exist on the server or you don't have permissions to access it"
461
                  }
462
                }
463 464
              ]
            })
465 466 467 468 469
          end
        end

        context 'when downloading one new and one existing lfs object' do
          let(:body) do
470 471
            {
              'operation' => 'download',
472 473
              'objects' => [
                { 'oid' => '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897',
474
                  'size' => 1575078 },
475
                { 'oid' => sample_oid,
476
                  'size' => sample_size }
477 478 479 480 481 482 483 484 485
              ]
            }
          end

          let(:update_lfs_permissions) do
            project.lfs_objects << lfs_object
          end

          it 'responds with status 200' do
486
            expect(response).to have_gitlab_http_status(200)
487 488 489
          end

          it 'responds with upload hypermedia link for the new object' do
490 491 492 493 494 495 496
            expect(json_response).to eq({
              'objects' => [
                {
                  'oid' => '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897',
                  'size' => 1575078,
                  'error' => {
                    'code' => 404,
497
                    'message' => "Object does not exist on the server or you don't have permissions to access it"
498 499 500 501 502 503 504 505 506 507
                  }
                },
                {
                  'oid' => sample_oid,
                  'size' => sample_size,
                  'actions' => {
                    'download' => {
                      'href' => "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}",
                      'header' => { 'Authorization' => authorization }
                    }
508 509
                  }
                }
510 511
              ]
            })
512 513 514 515 516 517 518 519
          end
        end
      end

      context 'when user is authenticated' do
        let(:authorization) { authorize_user }

        let(:update_user_permissions) do
520
          project.add_role(user, role)
521 522 523 524 525 526 527
        end

        it_behaves_like 'an authorized requests' do
          let(:role) { :reporter }
        end

        context 'when user does is not member of the project' do
Jacob Vosmaer committed
528
          let(:update_user_permissions) { nil }
529

Jacob Vosmaer committed
530
          it 'responds with 404' do
531
            expect(response).to have_gitlab_http_status(404)
532 533 534 535 536 537 538
          end
        end

        context 'when user does not have download access' do
          let(:role) { :guest }

          it 'responds with 403' do
539
            expect(response).to have_gitlab_http_status(403)
540 541 542 543
          end
        end
      end

544
      context 'when build is authorized as' do
545 546
        let(:authorization) { authorize_ci_project }

547 548 549 550 551 552 553 554 555
        let(:update_lfs_permissions) do
          project.lfs_objects << lfs_object
        end

        shared_examples 'can download LFS only from own projects' do
          context 'for own project' do
            let(:pipeline) { create(:ci_empty_pipeline, project: project) }

            let(:update_user_permissions) do
556
              project.add_reporter(user)
557 558 559 560 561 562
            end

            it_behaves_like 'an authorized requests'
          end

          context 'for other project' do
563
            let(:other_project) { create(:project) }
564 565 566
            let(:pipeline) { create(:ci_empty_pipeline, project: other_project) }

            it 'rejects downloading code' do
567
              expect(response).to have_gitlab_http_status(other_project_status)
568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595
            end
          end
        end

        context 'administrator' do
          let(:user) { create(:admin) }
          let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

          it_behaves_like 'can download LFS only from own projects' do
            # We render 403, because administrator does have normally access
            let(:other_project_status) { 403 }
          end
        end

        context 'regular user' do
          let(:user) { create(:user) }
          let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

          it_behaves_like 'can download LFS only from own projects' do
            # We render 404, to prevent data leakage about existence of the project
            let(:other_project_status) { 404 }
          end
        end

        context 'does not have user' do
          let(:build) { create(:ci_build, :running, pipeline: pipeline) }

          it_behaves_like 'can download LFS only from own projects' do
596 597
            # We render 404, to prevent data leakage about existence of the project
            let(:other_project_status) { 404 }
598 599
          end
        end
600 601 602 603
      end

      context 'when user is not authenticated' do
        describe 'is accessing public project' do
604
          let(:project) { create(:project, :public) }
605 606 607 608 609 610

          let(:update_lfs_permissions) do
            project.lfs_objects << lfs_object
          end

          it 'responds with status 200 and href to download' do
611
            expect(response).to have_gitlab_http_status(200)
612 613 614
          end

          it 'responds with status 200 and href to download' do
615 616
            expect(json_response).to eq({
              'objects' => [
617 618
                {
                  'oid' => sample_oid,
619 620 621 622 623 624 625
                  'size' => sample_size,
                  'authenticated' => true,
                  'actions' => {
                    'download' => {
                      'href' => "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}",
                      'header' => {}
                    }
626 627
                  }
                }
628 629
              ]
            })
630 631 632 633 634 635 636 637 638
          end
        end

        describe 'is accessing non-public project' do
          let(:update_lfs_permissions) do
            project.lfs_objects << lfs_object
          end

          it 'responds with authorization required' do
639
            expect(response).to have_gitlab_http_status(401)
640 641 642 643 644 645
          end
        end
      end
    end

    describe 'upload' do
646
      let(:project) { create(:project, :public) }
647
      let(:body) do
648 649
        {
          'operation' => 'upload',
650 651
          'objects' => [
            { 'oid' => sample_oid,
652
              'size' => sample_size }
653
          ]
654 655 656
        }
      end

657 658 659 660 661 662 663 664 665 666 667 668 669 670
      shared_examples 'pushes new LFS objects' do
        let(:sample_size) { 150.megabytes }
        let(:sample_oid) { '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897' }

        it 'responds with upload hypermedia link' do
          expect(response).to have_gitlab_http_status(200)
          expect(json_response['objects']).to be_kind_of(Array)
          expect(json_response['objects'].first['oid']).to eq(sample_oid)
          expect(json_response['objects'].first['size']).to eq(sample_size)
          expect(json_response['objects'].first['actions']['upload']['href']).to eq("#{Gitlab.config.gitlab.url}/#{project.full_path}.git/gitlab-lfs/objects/#{sample_oid}/#{sample_size}")
          expect(json_response['objects'].first['actions']['upload']['header']).to eq('Authorization' => authorization)
        end
      end

671 672 673 674 675
      describe 'when request is authenticated' do
        describe 'when user has project push access' do
          let(:authorization) { authorize_user }

          let(:update_user_permissions) do
676
            project.add_developer(user)
677 678 679
          end

          context 'when pushing an lfs object that already exists' do
680
            let(:other_project) { create(:project) }
681 682 683 684 685
            let(:update_lfs_permissions) do
              other_project.lfs_objects << lfs_object
            end

            it 'responds with status 200' do
686
              expect(response).to have_gitlab_http_status(200)
687 688 689 690 691 692 693 694 695 696 697 698 699 700
            end

            it 'responds with links the object to the project' do
              expect(json_response['objects']).to be_kind_of(Array)
              expect(json_response['objects'].first['oid']).to eq(sample_oid)
              expect(json_response['objects'].first['size']).to eq(sample_size)
              expect(lfs_object.projects.pluck(:id)).not_to include(project.id)
              expect(lfs_object.projects.pluck(:id)).to include(other_project.id)
              expect(json_response['objects'].first['actions']['upload']['href']).to eq("#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}/#{sample_size}")
              expect(json_response['objects'].first['actions']['upload']['header']).to eq('Authorization' => authorization)
            end
          end

          context 'when pushing a lfs object that does not exist' do
701
            it_behaves_like 'pushes new LFS objects'
702 703 704 705
          end

          context 'when pushing one new and one existing lfs object' do
            let(:body) do
706 707
              {
                'operation' => 'upload',
708 709
                'objects' => [
                  { 'oid' => '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897',
710
                    'size' => 1575078 },
711
                  { 'oid' => sample_oid,
712
                    'size' => sample_size }
713 714 715 716 717 718 719 720 721
                ]
              }
            end

            let(:update_lfs_permissions) do
              project.lfs_objects << lfs_object
            end

            it 'responds with status 200' do
722
              expect(response).to have_gitlab_http_status(200)
723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743
            end

            it 'responds with upload hypermedia link for the new object' do
              expect(json_response['objects']).to be_kind_of(Array)

              expect(json_response['objects'].first['oid']).to eq("91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897")
              expect(json_response['objects'].first['size']).to eq(1575078)
              expect(json_response['objects'].first['actions']['upload']['href']).to eq("#{project.http_url_to_repo}/gitlab-lfs/objects/91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897/1575078")
              expect(json_response['objects'].first['actions']['upload']['header']).to eq("Authorization" => authorization)

              expect(json_response['objects'].last['oid']).to eq(sample_oid)
              expect(json_response['objects'].last['size']).to eq(sample_size)
              expect(json_response['objects'].last).not_to have_key('actions')
            end
          end
        end

        context 'when user does not have push access' do
          let(:authorization) { authorize_user }

          it 'responds with 403' do
744
            expect(response).to have_gitlab_http_status(403)
745 746 747
          end
        end

748
        context 'when build is authorized' do
749 750
          let(:authorization) { authorize_ci_project }

751 752 753 754 755 756
          context 'build has an user' do
            let(:user) { create(:user) }

            context 'tries to push to own project' do
              let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

757
              it 'responds with 403 (not 404 because project is public)' do
758
                expect(response).to have_gitlab_http_status(403)
759 760 761 762
              end
            end

            context 'tries to push to other project' do
763
              let(:other_project) { create(:project) }
764 765 766
              let(:pipeline) { create(:ci_empty_pipeline, project: other_project) }
              let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

767 768
              # I'm not sure what this tests that is different from the previous test
              it 'responds with 403 (not 404 because project is public)' do
769
                expect(response).to have_gitlab_http_status(403)
770 771 772 773 774 775 776
              end
            end
          end

          context 'does not have user' do
            let(:build) { create(:ci_build, :running, pipeline: pipeline) }

777
            it 'responds with 403 (not 404 because project is public)' do
778
              expect(response).to have_gitlab_http_status(403)
779
            end
780 781
          end
        end
782 783

        context 'when deploy key has project push access' do
784
          let(:key) { create(:deploy_key) }
785 786 787
          let(:authorization) { authorize_deploy_key }

          let(:update_user_permissions) do
788
            project.deploy_keys_projects.create(deploy_key: key, can_push: true)
789 790 791 792
          end

          it_behaves_like 'pushes new LFS objects'
        end
793 794 795 796 797
      end

      context 'when user is not authenticated' do
        context 'when user has push access' do
          let(:update_user_permissions) do
798
            project.add_master(user)
799 800 801
          end

          it 'responds with status 401' do
802
            expect(response).to have_gitlab_http_status(401)
803 804 805 806 807
          end
        end

        context 'when user does not have push access' do
          it 'responds with status 401' do
808
            expect(response).to have_gitlab_http_status(401)
809 810 811 812 813 814
          end
        end
      end
    end

    describe 'unsupported' do
815
      let(:project) { create(:project) }
Jacob Vosmaer committed
816
      let(:authorization) { authorize_user }
817
      let(:body) do
818 819
        {
          'operation' => 'other',
820 821
          'objects' => [
            { 'oid' => sample_oid,
822
              'size' => sample_size }
823
          ]
824 825 826 827
        }
      end

      it 'responds with status 404' do
828
        expect(response).to have_gitlab_http_status(404)
829 830 831 832
      end
    end
  end

833 834 835 836 837 838 839 840 841 842
  describe 'when handling lfs batch request on a read-only GitLab instance' do
    let(:authorization) { authorize_user }
    let(:project) { create(:project) }
    let(:path) { "#{project.http_url_to_repo}/info/lfs/objects/batch" }
    let(:body) do
      { 'objects' => [{ 'oid' => sample_oid, 'size' => sample_size }] }
    end

    before do
      allow(Gitlab::Database).to receive(:read_only?) { true }
843
      project.add_master(user)
844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860
      enable_lfs
    end

    it 'responds with a 200 message on download' do
      post_lfs_json path, body.merge('operation' => 'download'), headers

      expect(response).to have_gitlab_http_status(200)
    end

    it 'responds with a 403 message on upload' do
      post_lfs_json path, body.merge('operation' => 'upload'), headers

      expect(response).to have_gitlab_http_status(403)
      expect(json_response).to include('message' => 'You cannot write to this read-only GitLab instance.')
    end
  end

861 862 863 864 865 866 867 868 869 870 871 872
  describe 'when pushing a lfs object' do
    before do
      enable_lfs
    end

    shared_examples 'unauthorized' do
      context 'and request is sent by gitlab-workhorse to authorize the request' do
        before do
          put_authorize
        end

        it 'responds with status 401' do
873
          expect(response).to have_gitlab_http_status(401)
874 875 876 877 878 879 880 881 882
        end
      end

      context 'and request is sent by gitlab-workhorse to finalize the upload' do
        before do
          put_finalize
        end

        it 'responds with status 401' do
883
          expect(response).to have_gitlab_http_status(401)
884 885 886 887 888
        end
      end

      context 'and request is sent with a malformed headers' do
        before do
889
          put_finalize('/etc/passwd')
890 891 892
        end

        it 'does not recognize it as a valid lfs command' do
893
          expect(response).to have_gitlab_http_status(401)
894 895 896 897 898 899 900 901 902 903 904
        end
      end
    end

    shared_examples 'forbidden' do
      context 'and request is sent by gitlab-workhorse to authorize the request' do
        before do
          put_authorize
        end

        it 'responds with 403' do
905
          expect(response).to have_gitlab_http_status(403)
906 907 908 909 910 911 912 913 914
        end
      end

      context 'and request is sent by gitlab-workhorse to finalize the upload' do
        before do
          put_finalize
        end

        it 'responds with 403' do
915
          expect(response).to have_gitlab_http_status(403)
916 917
        end
      end
Jacob Vosmaer committed
918 919 920

      context 'and request is sent with a malformed headers' do
        before do
921
          put_finalize('/etc/passwd')
Jacob Vosmaer committed
922 923 924
        end

        it 'does not recognize it as a valid lfs command' do
925
          expect(response).to have_gitlab_http_status(403)
Jacob Vosmaer committed
926 927
        end
      end
928 929 930
    end

    describe 'to one project' do
931
      let(:project) { create(:project) }
932 933 934 935 936 937

      describe 'when user is authenticated' do
        let(:authorization) { authorize_user }

        describe 'when user has push access to the project' do
          before do
938
            project.add_developer(user)
939 940
          end

941 942 943 944 945 946
          context 'and the request bypassed workhorse' do
            it 'raises an exception' do
              expect { put_authorize(verified: false) }.to raise_error JWT::DecodeError
            end
          end

947 948 949 950 951 952
          context 'and request is sent by gitlab-workhorse to authorize the request' do
            before do
              put_authorize
            end

            it 'responds with status 200' do
953
              expect(response).to have_gitlab_http_status(200)
954 955
            end

956 957 958 959
            it 'uses the gitlab-workhorse content type' do
              expect(response.content_type.to_s).to eq(Gitlab::Workhorse::INTERNAL_API_CONTENT_TYPE)
            end

960 961 962 963 964 965 966 967 968 969 970 971 972
            it 'responds with status 200, location of lfs store and object details' do
              expect(json_response['StoreLFSPath']).to eq("#{Gitlab.config.shared.path}/lfs-objects/tmp/upload")
              expect(json_response['LfsOid']).to eq(sample_oid)
              expect(json_response['LfsSize']).to eq(sample_size)
            end
          end

          context 'and request is sent by gitlab-workhorse to finalize the upload' do
            before do
              put_finalize
            end

            it 'responds with status 200' do
973
              expect(response).to have_gitlab_http_status(200)
974 975 976 977 978
            end

            it 'lfs object is linked to the project' do
              expect(lfs_object.projects.pluck(:id)).to include(project.id)
            end
Jacob Vosmaer committed
979
          end
980 981 982 983

          context 'invalid tempfiles' do
            it 'rejects slashes in the tempfile name (path traversal' do
              put_finalize('foo/bar')
984
              expect(response).to have_gitlab_http_status(403)
985 986 987 988
            end

            it 'rejects tempfile names that do not start with the oid' do
              put_finalize("foo#{sample_oid}")
989
              expect(response).to have_gitlab_http_status(403)
990
            end
991 992 993 994
          end
        end

        describe 'and user does not have push access' do
Jacob Vosmaer committed
995
          before do
996
            project.add_reporter(user)
Jacob Vosmaer committed
997 998
          end

999 1000 1001 1002
          it_behaves_like 'forbidden'
        end
      end

1003
      context 'when build is authorized' do
1004 1005
        let(:authorization) { authorize_ci_project }

1006 1007 1008 1009 1010 1011 1012
        context 'build has an user' do
          let(:user) { create(:user) }

          context 'tries to push to own project' do
            let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

            before do
1013
              project.add_developer(user)
1014 1015 1016
              put_authorize
            end

1017
            it 'responds with 403 (not 404 because the build user can read the project)' do
1018
              expect(response).to have_gitlab_http_status(403)
1019 1020 1021 1022
            end
          end

          context 'tries to push to other project' do
1023
            let(:other_project) { create(:project) }
1024 1025 1026 1027 1028 1029 1030
            let(:pipeline) { create(:ci_empty_pipeline, project: other_project) }
            let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

            before do
              put_authorize
            end

1031
            it 'responds with 404 (do not leak non-public project existence)' do
1032
              expect(response).to have_gitlab_http_status(404)
1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043
            end
          end
        end

        context 'does not have user' do
          let(:build) { create(:ci_build, :running, pipeline: pipeline) }

          before do
            put_authorize
          end

1044
          it 'responds with 404 (do not leak non-public project existence)' do
1045
            expect(response).to have_gitlab_http_status(404)
1046 1047
          end
        end
1048 1049 1050 1051 1052 1053 1054 1055
      end

      context 'for unauthenticated' do
        it_behaves_like 'unauthorized'
      end
    end

    describe 'to a forked project' do
1056
      let(:upstream_project) { create(:project, :public) }
1057 1058 1059 1060 1061 1062 1063 1064
      let(:project_owner) { create(:user) }
      let(:project) { fork_project(upstream_project, project_owner) }

      describe 'when user is authenticated' do
        let(:authorization) { authorize_user }

        describe 'when user has push access to the project' do
          before do
1065
            project.add_developer(user)
1066 1067 1068 1069 1070 1071 1072 1073
          end

          context 'and request is sent by gitlab-workhorse to authorize the request' do
            before do
              put_authorize
            end

            it 'responds with status 200' do
1074
              expect(response).to have_gitlab_http_status(200)
1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089
            end

            it 'with location of lfs store and object details' do
              expect(json_response['StoreLFSPath']).to eq("#{Gitlab.config.shared.path}/lfs-objects/tmp/upload")
              expect(json_response['LfsOid']).to eq(sample_oid)
              expect(json_response['LfsSize']).to eq(sample_size)
            end
          end

          context 'and request is sent by gitlab-workhorse to finalize the upload' do
            before do
              put_finalize
            end

            it 'responds with status 200' do
1090
              expect(response).to have_gitlab_http_status(200)
1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103
            end

            it 'lfs object is linked to the source project' do
              expect(lfs_object.projects.pluck(:id)).to include(upstream_project.id)
            end
          end
        end

        describe 'and user does not have push access' do
          it_behaves_like 'forbidden'
        end
      end

1104
      context 'when build is authorized' do
1105 1106
        let(:authorization) { authorize_ci_project }

1107 1108 1109 1110 1111 1112 1113 1114 1115 1116
        before do
          put_authorize
        end

        context 'build has an user' do
          let(:user) { create(:user) }

          context 'tries to push to own project' do
            let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

1117
            it 'responds with 403 (not 404 because project is public)' do
1118
              expect(response).to have_gitlab_http_status(403)
1119 1120 1121 1122
            end
          end

          context 'tries to push to other project' do
1123
            let(:other_project) { create(:project) }
1124 1125 1126
            let(:pipeline) { create(:ci_empty_pipeline, project: other_project) }
            let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }

1127 1128
            # I'm not sure what this tests that is different from the previous test
            it 'responds with 403 (not 404 because project is public)' do
1129
              expect(response).to have_gitlab_http_status(403)
1130 1131 1132 1133 1134 1135 1136
            end
          end
        end

        context 'does not have user' do
          let(:build) { create(:ci_build, :running, pipeline: pipeline) }

1137
          it 'responds with 403 (not 404 because project is public)' do
1138
            expect(response).to have_gitlab_http_status(403)
1139 1140
          end
        end
1141 1142 1143 1144 1145 1146 1147
      end

      context 'for unauthenticated' do
        it_behaves_like 'unauthorized'
      end

      describe 'and second project not related to fork or a source project' do
1148
        let(:second_project) { create(:project) }
1149 1150 1151
        let(:authorization) { authorize_user }

        before do
1152
          second_project.add_master(user)
1153 1154 1155 1156 1157 1158 1159 1160 1161 1162
          upstream_project.lfs_objects << lfs_object
        end

        context 'when pushing the same lfs object to the second project' do
          before do
            put "#{second_project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}/#{sample_size}", nil,
                headers.merge('X-Gitlab-Lfs-Tmp' => lfs_tmp_file).compact
          end

          it 'responds with status 200' do
1163
            expect(response).to have_gitlab_http_status(200)
1164 1165 1166 1167 1168 1169 1170 1171 1172
          end

          it 'links the lfs object to the project' do
            expect(lfs_object.projects.pluck(:id)).to include(second_project.id, upstream_project.id)
          end
        end
      end
    end

1173 1174 1175 1176 1177
    def put_authorize(verified: true)
      authorize_headers = headers
      authorize_headers.merge!(workhorse_internal_api_request_header) if verified

      put "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}/#{sample_size}/authorize", nil, authorize_headers
1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194
    end

    def put_finalize(lfs_tmp = lfs_tmp_file)
      put "#{project.http_url_to_repo}/gitlab-lfs/objects/#{sample_oid}/#{sample_size}", nil,
          headers.merge('X-Gitlab-Lfs-Tmp' => lfs_tmp).compact
    end

    def lfs_tmp_file
      "#{sample_oid}012345678"
    end
  end

  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end

  def authorize_ci_project
Kamil Trzcinski committed
1195
    ActionController::HttpAuthentication::Basic.encode_credentials('gitlab-ci-token', build.token)
1196 1197 1198 1199 1200 1201
  end

  def authorize_user
    ActionController::HttpAuthentication::Basic.encode_credentials(user.username, user.password)
  end

1202
  def authorize_deploy_key
1203
    ActionController::HttpAuthentication::Basic.encode_credentials("lfs+deploy-key-#{key.id}", Gitlab::LfsToken.new(key).token)
1204 1205
  end

1206
  def authorize_user_key
1207
    ActionController::HttpAuthentication::Basic.encode_credentials(user.username, Gitlab::LfsToken.new(user).token)
1208 1209
  end

1210 1211
  def post_lfs_json(url, body = nil, headers = nil)
    post(url, body.try(:to_json), (headers || {}).merge('Content-Type' => 'application/vnd.git-lfs+json'))
1212 1213 1214 1215 1216 1217
  end

  def json_response
    @json_response ||= JSON.parse(response.body)
  end
end