BigW Consortium Gitlab

users_controller_spec.rb 9.84 KB
Newer Older
1 2 3
require 'spec_helper'

describe UsersController do
4
  let(:user) { create(:user) }
5

6
  describe 'GET #show' do
7 8 9
    context 'with rendered views' do
      render_views

10 11 12 13
      describe 'when logged in' do
        before do
          sign_in(user)
        end
14

15 16
        it 'renders the show template' do
          get :show, username: user.username
17

18 19 20 21 22 23 24 25 26
          expect(response).to be_success
          expect(response).to render_template('show')
        end
      end

      describe 'when logged out' do
        it 'renders the show template' do
          get :show, username: user.username

27
          expect(response).to have_http_status(200)
28 29
          expect(response).to render_template('show')
        end
30
      end
31
    end
Felipe Artur committed
32

Felipe Artur committed
33
    context 'when public visibility level is restricted' do
Felipe Artur committed
34 35 36 37 38
      before do
        stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
      end

      context 'when logged out' do
39
        it 'redirects to login page' do
Felipe Artur committed
40
          get :show, username: user.username
41
          expect(response).to redirect_to new_user_session_path
Felipe Artur committed
42 43 44 45
        end
      end

      context 'when logged in' do
46 47 48
        before do
          sign_in(user)
        end
Felipe Artur committed
49

Felipe Artur committed
50
        it 'renders show' do
Felipe Artur committed
51
          get :show, username: user.username
52
          expect(response).to have_http_status(200)
Felipe Artur committed
53
          expect(response).to render_template('show')
Felipe Artur committed
54 55 56
        end
      end
    end
57

Michael Kozono committed
58 59
    context 'when a user by that username does not exist' do
      context 'when logged out' do
60
        it 'redirects to login page' do
Michael Kozono committed
61
          get :show, username: 'nonexistent'
62
          expect(response).to redirect_to new_user_session_path
Michael Kozono committed
63 64 65 66
        end
      end

      context 'when logged in' do
67 68 69
        before do
          sign_in(user)
        end
Michael Kozono committed
70 71 72 73 74 75 76

        it 'renders 404' do
          get :show, username: 'nonexistent'
          expect(response).to have_http_status(404)
        end
      end
    end
77
  end
78

79 80
  describe 'GET #calendar' do
    it 'renders calendar' do
81 82
      sign_in(user)

Mike Greiling committed
83
      get :calendar, username: user.username, format: :json
84

Mike Greiling committed
85
      expect(response).to have_http_status(200)
86
    end
87 88

    context 'forked project' do
89
      let(:project) { create(:project) }
90
      let(:forked_project) { Projects::ForkService.new(project, user).execute }
91 92 93 94

      before do
        sign_in(user)
        project.team << [user, :developer]
95 96 97 98 99 100 101 102

        push_data = Gitlab::DataBuilder::Push.build_sample(project, user)

        fork_push_data = Gitlab::DataBuilder::Push
          .build_sample(forked_project, user)

        EventCreateService.new.push(project, user, push_data)
        EventCreateService.new.push(forked_project, user, fork_push_data)
103 104 105 106 107 108 109
      end

      it 'includes forked projects' do
        get :calendar, username: user.username
        expect(assigns(:contributions_calendar).projects.count).to eq(2)
      end
    end
110 111
  end

112
  describe 'GET #calendar_activities' do
113
    let!(:project) { create(:project) }
114
    let(:user) { create(:user) }
115 116 117

    before do
      allow_any_instance_of(User).to receive(:contributed_projects_ids).and_return([project.id])
118 119

      sign_in(user)
120 121 122 123
      project.team << [user, :developer]
    end

    it 'assigns @calendar_date' do
124
      get :calendar_activities, username: user.username, date: '2014-07-31'
125 126 127 128
      expect(assigns(:calendar_date)).to eq(Date.parse('2014-07-31'))
    end

    it 'renders calendar_activities' do
129
      get :calendar_activities, username: user.username
130 131 132
      expect(response).to render_template('calendar_activities')
    end
  end
133 134 135 136 137 138 139 140 141

  describe 'GET #snippets' do
    before do
      sign_in(user)
    end

    context 'format html' do
      it 'renders snippets page' do
        get :snippets, username: user.username
142
        expect(response).to have_http_status(200)
143 144 145 146 147 148 149
        expect(response).to render_template('show')
      end
    end

    context 'format json' do
      it 'response with snippets json data' do
        get :snippets, username: user.username, format: :json
150
        expect(response).to have_http_status(200)
151 152 153
        expect(JSON.parse(response.body)).to have_key('html')
      end
    end
154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199
  end

  describe 'GET #exists' do
    before do
      sign_in(user)
    end

    context 'when user exists' do
      it 'returns JSON indicating the user exists' do
        get :exists, username: user.username

        expected_json = { exists: true }.to_json
        expect(response.body).to eq(expected_json)
      end

      context 'when the casing is different' do
        let(:user) { create(:user, username: 'CamelCaseUser') }

        it 'returns JSON indicating the user exists' do
          get :exists, username: user.username.downcase

          expected_json = { exists: true }.to_json
          expect(response.body).to eq(expected_json)
        end
      end
    end

    context 'when the user does not exist' do
      it 'returns JSON indicating the user does not exist' do
        get :exists, username: 'foo'

        expected_json = { exists: false }.to_json
        expect(response.body).to eq(expected_json)
      end

      context 'when a user changed their username' do
        let(:redirect_route) { user.namespace.redirect_routes.create(path: 'old-username') }

        it 'returns JSON indicating a user by that username does not exist' do
          get :exists, username: 'old-username'

          expected_json = { exists: false }.to_json
          expect(response.body).to eq(expected_json)
        end
      end
    end
200
  end
201

202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322
  describe '#ensure_canonical_path' do
    before do
      sign_in(user)
    end

    context 'for a GET request' do
      context 'when requesting users at the root path' do
        context 'when requesting the canonical path' do
          let(:user) { create(:user, username: 'CamelCaseUser') }

          context 'with exactly matching casing' do
            it 'responds with success' do
              get :show, username: user.username

              expect(response).to be_success
            end
          end

          context 'with different casing' do
            it 'redirects to the correct casing' do
              get :show, username: user.username.downcase

              expect(response).to redirect_to(user)
              expect(controller).not_to set_flash[:notice]
            end
          end
        end

        context 'when requesting a redirected path' do
          let(:redirect_route) { user.namespace.redirect_routes.create(path: 'old-path') }

          it 'redirects to the canonical path' do
            get :show, username: redirect_route.path

            expect(response).to redirect_to(user)
            expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
          end

          context 'when the old path is a substring of the scheme or host' do
            let(:redirect_route) { user.namespace.redirect_routes.create(path: 'http') }

            it 'does not modify the requested host' do
              get :show, username: redirect_route.path

              expect(response).to redirect_to(user)
              expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
            end
          end

          context 'when the old path is substring of users' do
            let(:redirect_route) { user.namespace.redirect_routes.create(path: 'ser') }

            it 'redirects to the canonical path' do
              get :show, username: redirect_route.path

              expect(response).to redirect_to(user)
              expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
            end
          end
        end
      end

      context 'when requesting users under the /users path' do
        context 'when requesting the canonical path' do
          let(:user) { create(:user, username: 'CamelCaseUser') }

          context 'with exactly matching casing' do
            it 'responds with success' do
              get :projects, username: user.username

              expect(response).to be_success
            end
          end

          context 'with different casing' do
            it 'redirects to the correct casing' do
              get :projects, username: user.username.downcase

              expect(response).to redirect_to(user_projects_path(user))
              expect(controller).not_to set_flash[:notice]
            end
          end
        end

        context 'when requesting a redirected path' do
          let(:redirect_route) { user.namespace.redirect_routes.create(path: 'old-path') }

          it 'redirects to the canonical path' do
            get :projects, username: redirect_route.path

            expect(response).to redirect_to(user_projects_path(user))
            expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
          end

          context 'when the old path is a substring of the scheme or host' do
            let(:redirect_route) { user.namespace.redirect_routes.create(path: 'http') }

            it 'does not modify the requested host' do
              get :projects, username: redirect_route.path

              expect(response).to redirect_to(user_projects_path(user))
              expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
            end
          end

          context 'when the old path is substring of users' do
            let(:redirect_route) { user.namespace.redirect_routes.create(path: 'ser') }

            # I.e. /users/ser should not become /ufoos/ser
            it 'does not modify the /users part of the path' do
              get :projects, username: redirect_route.path

              expect(response).to redirect_to(user_projects_path(user))
              expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
            end
          end
        end
      end
    end
  end

323 324 325
  def user_moved_message(redirect_route, user)
    "User '#{redirect_route.path}' was moved to '#{user.full_path}'. Please update any links and bookmarks that may still have the old path."
  end
326
end