BigW Consortium Gitlab

u2f_spec.rb 10.3 KB
Newer Older
1 2 3
require 'spec_helper'

feature 'Using U2F (Universal 2nd Factor) Devices for Authentication', feature: true, js: true do
4 5
  include WaitForAjax

6 7
  before { allow_any_instance_of(U2fHelper).to receive(:inject_u2f_api?).and_return(true) }

8 9 10 11 12 13
  def manage_two_factor_authentication
    click_on 'Manage Two-Factor Authentication'
    expect(page).to have_content("Setup New U2F Device")
    wait_for_ajax
  end

14
  def register_u2f_device(u2f_device = nil)
15 16
    name = FFaker::Name.first_name
    u2f_device ||= FakeU2fDevice.new(page, name)
17 18 19
    u2f_device.respond_to_u2f_registration
    click_on 'Setup New U2F Device'
    expect(page).to have_content('Your device was successfully set up')
20
    fill_in "Pick a name", with: name
21 22 23 24 25 26 27
    click_on 'Register U2F Device'
    u2f_device
  end

  describe "registration" do
    let(:user) { create(:user) }

28 29 30 31
    before do
      login_as(user)
      user.update_attribute(:otp_required_for_login, true)
    end
32

33 34
    describe 'when 2FA via OTP is disabled' do
      before { user.update_attribute(:otp_required_for_login, false) }
35

36
      it 'does not allow registering a new device' do
37 38 39
        visit profile_account_path
        click_on 'Enable Two-Factor Authentication'

40
        expect(page).to have_button('Setup New U2F Device', disabled: true)
41 42 43 44
      end
    end

    describe 'when 2FA via OTP is enabled' do
45
      it 'allows registering a new device with a name' do
46
        visit profile_account_path
47
        manage_two_factor_authentication
48 49
        expect(page.body).to match("You've already enabled two-factor authentication using mobile")

50
        u2f_device = register_u2f_device
51

52
        expect(page.body).to match(u2f_device.name)
53 54 55 56 57 58 59
        expect(page.body).to match('Your U2F device was registered')
      end

      it 'allows registering more than one device' do
        visit profile_account_path

        # First device
60
        manage_two_factor_authentication
61
        first_device = register_u2f_device
62 63 64
        expect(page.body).to match('Your U2F device was registered')

        # Second device
65
        second_device = register_u2f_device
66
        expect(page.body).to match('Your U2F device was registered')
67 68 69 70 71 72 73 74

        expect(page.body).to match(first_device.name)
        expect(page.body).to match(second_device.name)
        expect(U2fRegistration.count).to eq(2)
      end

      it 'allows deleting a device' do
        visit profile_account_path
75
        manage_two_factor_authentication
76 77 78 79 80 81 82 83 84 85
        expect(page.body).to match("You've already enabled two-factor authentication using mobile")

        first_u2f_device = register_u2f_device
        second_u2f_device = register_u2f_device

        click_on "Delete", match: :first

        expect(page.body).to match('Successfully deleted')
        expect(page.body).not_to match(first_u2f_device.name)
        expect(page.body).to match(second_u2f_device.name)
86 87 88 89 90 91
      end
    end

    it 'allows the same device to be registered for multiple users' do
      # First user
      visit profile_account_path
92
      manage_two_factor_authentication
93 94 95 96 97
      u2f_device = register_u2f_device
      expect(page.body).to match('Your U2F device was registered')
      logout

      # Second user
98 99
      user = login_as(:user)
      user.update_attribute(:otp_required_for_login, true)
100
      visit profile_account_path
101
      manage_two_factor_authentication
102 103 104 105 106 107 108 109 110
      register_u2f_device(u2f_device)
      expect(page.body).to match('Your U2F device was registered')

      expect(U2fRegistration.count).to eq(2)
    end

    context "when there are form errors" do
      it "doesn't register the device if there are errors" do
        visit profile_account_path
111
        manage_two_factor_authentication
112 113 114 115 116 117 118 119 120 121 122 123 124 125

        # Have the "u2f device" respond with bad data
        page.execute_script("u2f.register = function(_,_,_,callback) { callback('bad response'); };")
        click_on 'Setup New U2F Device'
        expect(page).to have_content('Your device was successfully set up')
        click_on 'Register U2F Device'

        expect(U2fRegistration.count).to eq(0)
        expect(page.body).to match("The form contains the following error")
        expect(page.body).to match("did not send a valid JSON response")
      end

      it "allows retrying registration" do
        visit profile_account_path
126
        manage_two_factor_authentication
127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149

        # Failed registration
        page.execute_script("u2f.register = function(_,_,_,callback) { callback('bad response'); };")
        click_on 'Setup New U2F Device'
        expect(page).to have_content('Your device was successfully set up')
        click_on 'Register U2F Device'
        expect(page.body).to match("The form contains the following error")

        # Successful registration
        register_u2f_device

        expect(page.body).to match('Your U2F device was registered')
        expect(U2fRegistration.count).to eq(1)
      end
    end
  end

  describe "authentication" do
    let(:user) { create(:user) }

    before do
      # Register and logout
      login_as(user)
150
      user.update_attribute(:otp_required_for_login, true)
151
      visit profile_account_path
152
      manage_two_factor_authentication
153 154 155 156 157 158
      @u2f_device = register_u2f_device
      logout
    end

    describe "when 2FA via OTP is disabled" do
      it "allows logging in with the U2F device" do
159
        user.update_attribute(:otp_required_for_login, false)
160 161 162 163 164 165 166 167 168 169 170 171 172
        login_with(user)

        @u2f_device.respond_to_u2f_authentication
        click_on "Login Via U2F Device"
        expect(page.body).to match('We heard back from your U2F device')
        click_on "Authenticate via U2F Device"

        expect(page.body).to match('Signed in successfully')
      end
    end

    describe "when 2FA via OTP is enabled" do
      it "allows logging in with the U2F device" do
173
        user.update_attribute(:otp_required_for_login, true)
174 175 176 177 178 179 180 181 182 183 184
        login_with(user)

        @u2f_device.respond_to_u2f_authentication
        click_on "Login Via U2F Device"
        expect(page.body).to match('We heard back from your U2F device')
        click_on "Authenticate via U2F Device"

        expect(page.body).to match('Signed in successfully')
      end
    end

185 186 187 188 189 190 191 192 193 194 195 196 197
    it 'persists remember_me value via hidden field' do
      login_with(user, remember: true)

      @u2f_device.respond_to_u2f_authentication
      click_on "Login Via U2F Device"
      expect(page.body).to match('We heard back from your U2F device')

      within 'div#js-authenticate-u2f' do
        field = first('input#user_remember_me', visible: false)
        expect(field.value).to eq '1'
      end
    end

198 199 200 201 202
    describe "when a given U2F device has already been registered by another user" do
      describe "but not the current user" do
        it "does not allow logging in with that particular device" do
          # Register current user with the different U2F device
          current_user = login_as(:user)
203
          current_user.update_attribute(:otp_required_for_login, true)
204
          visit profile_account_path
205
          manage_two_factor_authentication
206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
          register_u2f_device
          logout

          # Try authenticating user with the old U2F device
          login_as(current_user)
          @u2f_device.respond_to_u2f_authentication
          click_on "Login Via U2F Device"
          expect(page.body).to match('We heard back from your U2F device')
          click_on "Authenticate via U2F Device"

          expect(page.body).to match('Authentication via U2F device failed')
        end
      end

      describe "and also the current user" do
        it "allows logging in with that particular device" do
          # Register current user with the same U2F device
          current_user = login_as(:user)
224
          current_user.update_attribute(:otp_required_for_login, true)
225
          visit profile_account_path
226
          manage_two_factor_authentication
227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243
          register_u2f_device(@u2f_device)
          logout

          # Try authenticating user with the same U2F device
          login_as(current_user)
          @u2f_device.respond_to_u2f_authentication
          click_on "Login Via U2F Device"
          expect(page.body).to match('We heard back from your U2F device')
          click_on "Authenticate via U2F Device"

          expect(page.body).to match('Signed in successfully')
        end
      end
    end

    describe "when a given U2F device has not been registered" do
      it "does not allow logging in with that particular device" do
244
        unregistered_device = FakeU2fDevice.new(page, FFaker::Name.first_name)
245 246 247 248 249 250 251 252 253 254
        login_as(user)
        unregistered_device.respond_to_u2f_authentication
        click_on "Login Via U2F Device"
        expect(page.body).to match('We heard back from your U2F device')
        click_on "Authenticate via U2F Device"

        expect(page.body).to match('Authentication via U2F device failed')
      end
    end

255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276
    describe "when more than one device has been registered by the same user" do
      it "allows logging in with either device" do
        # Register first device
        user = login_as(:user)
        user.update_attribute(:otp_required_for_login, true)
        visit profile_two_factor_auth_path
        expect(page).to have_content("Your U2F device needs to be set up.")
        first_device = register_u2f_device

        # Register second device
        visit profile_two_factor_auth_path
        expect(page).to have_content("Your U2F device needs to be set up.")
        second_device = register_u2f_device
        logout

        # Authenticate as both devices
        [first_device, second_device].each do |device|
          login_as(user)
          device.respond_to_u2f_authentication
          click_on "Login Via U2F Device"
          expect(page.body).to match('We heard back from your U2F device')
          click_on "Authenticate via U2F Device"
277

278 279 280 281 282
          expect(page.body).to match('Signed in successfully')

          logout
        end
      end
283 284
    end

285 286 287 288 289 290 291
    describe "when two-factor authentication is disabled" do
      let(:user) { create(:user) }

      before do
        user = login_as(:user)
        user.update_attribute(:otp_required_for_login, true)
        visit profile_account_path
292
        manage_two_factor_authentication
293 294 295 296 297
        expect(page).to have_content("Your U2F device needs to be set up.")
        register_u2f_device
      end

      it "deletes u2f registrations" do
298
        visit profile_account_path
299 300
        expect { click_on "Disable" }.to change { U2fRegistration.count }.by(-1)
      end
301 302 303
    end
  end
end