BigW Consortium Gitlab

issues_spec.rb 18.9 KB
Newer Older
gitlabhq committed
1 2
require 'spec_helper'

3
describe 'Issues', feature: true do
4
  include IssueHelpers
Dmitriy Zaporozhets committed
5
  include SortingHelper
6
  include WaitForAjax
Dmitriy Zaporozhets committed
7

8
  let(:project) { create(:project) }
gitlabhq committed
9

Nihad Abbasov committed
10
  before do
gitlabhq committed
11
    login_as :user
Riyad Preukschas committed
12
    user2 = create(:user)
gitlabhq committed
13

14
    project.team << [[@user, user2], :developer]
gitlabhq committed
15 16
  end

17
  describe 'Edit issue' do
Riyad Preukschas committed
18 19 20 21 22 23 24
    let!(:issue) do
      create(:issue,
             author: @user,
             assignee: @user,
             project: project)
    end

Nihad Abbasov committed
25
    before do
26
      visit edit_namespace_project_issue_path(project.namespace, project, issue)
Jacob Schatz committed
27
      find('.js-zen-enter').click
gitlabhq committed
28 29
    end

30
    it 'opens new issue popup' do
31
      expect(page).to have_content("Issue ##{issue.iid}")
gitlabhq committed
32 33
    end

34
    describe 'fill in' do
gitlabhq committed
35
      before do
36 37
        fill_in 'issue_title', with: 'bug 345'
        fill_in 'issue_description', with: 'bug description'
gitlabhq committed
38 39
      end
    end
40 41
  end

42
  describe 'Editing issue assignee' do
43 44 45 46 47 48 49
    let!(:issue) do
      create(:issue,
             author: @user,
             assignee: @user,
             project: project)
    end

50
    it 'allows user to select unassigned', js: true do
Vinnie Okada committed
51
      visit edit_namespace_project_issue_path(project.namespace, project, issue)
52

53
      expect(page).to have_content "Assignee #{@user.name}"
54

55 56
      first('.js-user-search').click
      click_link 'Unassigned'
57

58
      click_button 'Save changes'
59

60
      page.within('.assignee') do
61
        expect(page).to have_content 'No assignee - assign yourself'
62 63
      end

64
      expect(issue.reload.assignee).to be_nil
65
    end
gitlabhq committed
66
  end
67

Phil Hughes committed
68 69 70 71 72 73
  describe 'due date', js: true do
    context 'on new form' do
      before do
        visit new_namespace_project_issue_path(project.namespace, project)
      end

74
      it 'saves with due date' do
Phil Hughes committed
75 76 77 78
        date = Date.today.at_beginning_of_month

        fill_in 'issue_title', with: 'bug 345'
        fill_in 'issue_description', with: 'bug description'
Phil Hughes committed
79
        find('#issuable-due-date').click
Phil Hughes committed
80

Phil Hughes committed
81
        page.within '.ui-datepicker' do
Phil Hughes committed
82 83 84
          click_link date.day
        end

Phil Hughes committed
85
        expect(find('#issuable-due-date').value).to eq date.to_s
Phil Hughes committed
86 87 88 89 90 91 92 93 94 95

        click_button 'Submit issue'

        page.within '.issuable-sidebar' do
          expect(page).to have_content date.to_s(:medium)
        end
      end
    end

    context 'on edit form' do
96
      let(:issue) { create(:issue, author: @user, project: project, due_date: Date.today.at_beginning_of_month.to_s) }
Phil Hughes committed
97 98 99 100 101

      before do
        visit edit_namespace_project_issue_path(project.namespace, project, issue)
      end

102
      it 'saves with due date' do
Phil Hughes committed
103 104
        date = Date.today.at_beginning_of_month

Phil Hughes committed
105
        expect(find('#issuable-due-date').value).to eq date.to_s
Phil Hughes committed
106 107 108 109 110

        date = date.tomorrow

        fill_in 'issue_title', with: 'bug 345'
        fill_in 'issue_description', with: 'bug description'
Phil Hughes committed
111
        find('#issuable-due-date').click
Phil Hughes committed
112

Phil Hughes committed
113
        page.within '.ui-datepicker' do
Phil Hughes committed
114 115 116
          click_link date.day
        end

Phil Hughes committed
117
        expect(find('#issuable-due-date').value).to eq date.to_s
Phil Hughes committed
118 119 120 121 122 123 124

        click_button 'Save changes'

        page.within '.issuable-sidebar' do
          expect(page).to have_content date.to_s(:medium)
        end
      end
125 126 127 128 129 130 131 132 133 134 135

      it 'warns about version conflict' do
        issue.update(title: "New title")

        fill_in 'issue_title', with: 'bug 345'
        fill_in 'issue_description', with: 'bug description'

        click_button 'Save changes'

        expect(page).to have_content 'Someone edited the issue the same time you did'
      end
Phil Hughes committed
136 137 138
    end
  end

139 140 141
  describe 'Issue info' do
    it 'excludes award_emoji from comment count' do
      issue = create(:issue, author: @user, assignee: @user, project: project, title: 'foobar')
142
      create(:award_emoji, awardable: issue)
143 144 145 146

      visit namespace_project_issues_path(project.namespace, project, assignee_id: @user.id)

      expect(page).to have_content 'foobar'
147
      expect(page.all('.no-comments').first.text).to eq "0"
148 149 150
    end
  end

151
  describe 'Filter issue' do
152 153
    before do
      ['foobar', 'barbaz', 'gitlab'].each do |title|
Riyad Preukschas committed
154 155 156 157 158
        create(:issue,
               author: @user,
               assignee: @user,
               project: project,
               title: title)
159 160
      end

Dmitriy Zaporozhets committed
161
      @issue = Issue.find_by(title: 'foobar')
162 163 164
      @issue.milestone = create(:milestone, project: project)
      @issue.assignee = nil
      @issue.save
165 166
    end

167
    let(:issue) { @issue }
Riyad Preukschas committed
168

169
    it 'allows filtering by issues with no specified assignee' do
170
      visit namespace_project_issues_path(project.namespace, project, assignee_id: IssuableFinder::NONE)
171

172 173 174
      expect(page).to have_content 'foobar'
      expect(page).not_to have_content 'barbaz'
      expect(page).not_to have_content 'gitlab'
175 176
    end

177
    it 'allows filtering by a specified assignee' do
Vinnie Okada committed
178
      visit namespace_project_issues_path(project.namespace, project, assignee_id: @user.id)
179

180 181 182
      expect(page).not_to have_content 'foobar'
      expect(page).to have_content 'barbaz'
      expect(page).to have_content 'gitlab'
183
    end
184
  end
185 186

  describe 'filter issue' do
Rémy Coutable committed
187
    titles = %w[foo bar baz]
188
    titles.each_with_index do |title, index|
189 190 191 192 193
      let!(title.to_sym) do
        create(:issue, title: title,
                       project: project,
                       created_at: Time.now - (index * 60))
      end
194
    end
195 196
    let(:newer_due_milestone) { create(:milestone, due_date: '2013-12-11') }
    let(:later_due_milestone) { create(:milestone, due_date: '2013-12-12') }
197 198

    it 'sorts by newest' do
Vinnie Okada committed
199
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_recently_created)
200

201 202
      expect(first_issue).to include('foo')
      expect(last_issue).to include('baz')
203 204 205
    end

    it 'sorts by oldest' do
Vinnie Okada committed
206
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_oldest_created)
207

208 209
      expect(first_issue).to include('baz')
      expect(last_issue).to include('foo')
210 211 212 213 214
    end

    it 'sorts by most recently updated' do
      baz.updated_at = Time.now + 100
      baz.save
Vinnie Okada committed
215
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_recently_updated)
216

217
      expect(first_issue).to include('baz')
218 219 220 221 222
    end

    it 'sorts by least recently updated' do
      baz.updated_at = Time.now - 100
      baz.save
Vinnie Okada committed
223
      visit namespace_project_issues_path(project.namespace, project, sort: sort_value_oldest_updated)
224

225
      expect(first_issue).to include('baz')
226 227
    end

228
    describe 'sorting by due date' do
229
      before do
Rémy Coutable committed
230 231
        foo.update(due_date: 1.day.from_now)
        bar.update(due_date: 6.days.from_now)
232 233 234 235
      end

      it 'sorts by recently due date' do
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_soon)
Rémy Coutable committed
236

237 238 239 240 241
        expect(first_issue).to include('foo')
      end

      it 'sorts by least recently due date' do
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_later)
Rémy Coutable committed
242

243 244 245 246 247
        expect(first_issue).to include('bar')
      end

      it 'sorts by least recently due date by excluding nil due dates' do
        bar.update(due_date: nil)
Rémy Coutable committed
248

249
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_later)
Rémy Coutable committed
250

251 252
        expect(first_issue).to include('foo')
      end
253 254 255 256 257 258 259 260 261 262 263 264 265

      context 'with a filter on labels' do
        let(:label) { create(:label, project: project) }
        before { create(:label_link, label: label, target: foo) }

        it 'sorts by least recently due date by excluding nil due dates' do
          bar.update(due_date: nil)

          visit namespace_project_issues_path(project.namespace, project, label_names: [label.name], sort: sort_value_due_date_later)

          expect(first_issue).to include('foo')
        end
      end
266 267 268
    end

    describe 'filtering by due date' do
Rémy Coutable committed
269 270 271
      before do
        foo.update(due_date: 1.day.from_now)
        bar.update(due_date: 6.days.from_now)
272 273 274
      end

      it 'filters by none' do
275
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::NoDueDate.name)
Rémy Coutable committed
276 277 278 279

        expect(page).not_to have_content('foo')
        expect(page).not_to have_content('bar')
        expect(page).to have_content('baz')
280 281 282
      end

      it 'filters by any' do
283
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::AnyDueDate.name)
Rémy Coutable committed
284 285 286 287

        expect(page).to have_content('foo')
        expect(page).to have_content('bar')
        expect(page).to have_content('baz')
288 289
      end

290 291 292 293
      it 'filters by due this week' do
        foo.update(due_date: Date.today.beginning_of_week + 2.days)
        bar.update(due_date: Date.today.end_of_week)
        baz.update(due_date: Date.today - 8.days)
Rémy Coutable committed
294

295
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::DueThisWeek.name)
Rémy Coutable committed
296 297 298 299

        expect(page).to have_content('foo')
        expect(page).to have_content('bar')
        expect(page).not_to have_content('baz')
300 301
      end

302 303 304 305
      it 'filters by due this month' do
        foo.update(due_date: Date.today.beginning_of_month + 2.days)
        bar.update(due_date: Date.today.end_of_month)
        baz.update(due_date: Date.today - 50.days)
Rémy Coutable committed
306

307
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::DueThisMonth.name)
Rémy Coutable committed
308 309 310 311

        expect(page).to have_content('foo')
        expect(page).to have_content('bar')
        expect(page).not_to have_content('baz')
312 313
      end

314 315 316 317 318
      it 'filters by overdue' do
        foo.update(due_date: Date.today + 2.days)
        bar.update(due_date: Date.today + 20.days)
        baz.update(due_date: Date.yesterday)

Rémy Coutable committed
319 320 321 322 323 324
        visit namespace_project_issues_path(project.namespace, project, due_date: Issue::Overdue.name)

        expect(page).not_to have_content('foo')
        expect(page).not_to have_content('bar')
        expect(page).to have_content('baz')
      end
325 326
    end

327
    describe 'sorting by milestone' do
Rémy Coutable committed
328
      before do
329 330 331 332 333 334 335
        foo.milestone = newer_due_milestone
        foo.save
        bar.milestone = later_due_milestone
        bar.save
      end

      it 'sorts by recently due milestone' do
Vinnie Okada committed
336
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_milestone_soon)
337

338
        expect(first_issue).to include('foo')
339
        expect(last_issue).to include('baz')
340 341 342
      end

      it 'sorts by least recently due milestone' do
Vinnie Okada committed
343
        visit namespace_project_issues_path(project.namespace, project, sort: sort_value_milestone_later)
344

345
        expect(first_issue).to include('bar')
346
        expect(last_issue).to include('baz')
347 348 349 350 351 352
      end
    end

    describe 'combine filter and sort' do
      let(:user2) { create(:user) }

Rémy Coutable committed
353
      before do
354 355 356 357 358 359 360
        foo.assignee = user2
        foo.save
        bar.assignee = user2
        bar.save
      end

      it 'sorts with a filter applied' do
Vinnie Okada committed
361 362 363
        visit namespace_project_issues_path(project.namespace, project,
                                            sort: sort_value_oldest_created,
                                            assignee_id: user2.id)
364

365 366
        expect(first_issue).to include('bar')
        expect(last_issue).to include('foo')
367
        expect(page).not_to have_content 'baz'
368 369 370
      end
    end
  end
371

372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
  describe 'when I want to reset my incoming email token' do
    let(:project1) { create(:project, namespace: @user.namespace) }

    before do
      allow(Gitlab.config.incoming_email).to receive(:enabled).and_return(true)
      project1.team << [@user, :master]
      visit namespace_project_issues_path(@user.namespace, project1)
    end

    it 'changes incoming email address token', js: true do
      find('.issue-email-modal-btn').click
      previous_token = find('input#issue_email').value

      find('.incoming-email-token-reset').click
      wait_for_ajax

      expect(find('input#issue_email').value).not_to eq(previous_token)
    end
  end

392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409
  describe 'update labels from issue#show', js: true do
    let(:issue) { create(:issue, project: project, author: @user, assignee: @user) }
    let!(:label) { create(:label, project: project) }

    before do
      visit namespace_project_issue_path(project.namespace, project, issue)
    end

    it 'will not send ajax request when no data is changed' do
      page.within '.labels' do
        click_link 'Edit'
        first('.dropdown-menu-close').click

        expect(page).not_to have_selector('.block-loading')
      end
    end
  end

410
  describe 'update assignee from issue#show' do
411
    let(:issue) { create(:issue, project: project, author: @user, assignee: @user) }
412

413
    context 'by authorized user' do
414
      it 'allows user to select unassigned', js: true do
Vinnie Okada committed
415
        visit namespace_project_issue_path(project.namespace, project, issue)
416

417 418 419
        page.within('.assignee') do
          expect(page).to have_content "#{@user.name}"

Phil Hughes committed
420 421
          click_link 'Edit'
          click_link 'Unassigned'
422 423
          expect(page).to have_content 'No assignee'
        end
424

425
        expect(issue.reload.assignee).to be_nil
426
      end
427 428 429 430 431 432 433 434 435 436 437 438

      it 'allows user to select an assignee', js: true do
        issue2 = create(:issue, project: project, author: @user)
        visit namespace_project_issue_path(project.namespace, project, issue2)

        page.within('.assignee') do
          expect(page).to have_content "No assignee"
        end

        page.within '.assignee' do
          click_link 'Edit'
        end
Phil Hughes committed
439

440 441 442 443 444 445 446 447
        page.within '.dropdown-menu-user' do
          click_link @user.name
        end

        page.within('.assignee') do
          expect(page).to have_content @user.name
        end
      end
448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468

      it 'allows user to unselect themselves', js: true do
        issue2 = create(:issue, project: project, author: @user)
        visit namespace_project_issue_path(project.namespace, project, issue2)

        page.within '.assignee' do
          click_link 'Edit'
          click_link @user.name

          page.within '.value' do
            expect(page).to have_content @user.name
          end

          click_link 'Edit'
          click_link @user.name

          page.within '.value' do
            expect(page).to have_content "No assignee"
          end
        end
      end
469 470 471 472
    end

    context 'by unauthorized user' do
      let(:guest) { create(:user) }
Dmitriy Zaporozhets committed
473

Rémy Coutable committed
474
      before do
475 476 477
        project.team << [[guest], :guest]
      end

478
      it 'shows assignee text', js: true do
479 480 481
        logout
        login_with guest

Vinnie Okada committed
482
        visit namespace_project_issue_path(project.namespace, project, issue)
483
        expect(page).to have_content issue.assignee.name
484 485 486 487 488 489 490 491 492
      end
    end
  end

  describe 'update milestone from issue#show' do
    let!(:issue) { create(:issue, project: project, author: @user) }
    let!(:milestone) { create(:milestone, project: project) }

    context 'by authorized user' do
493 494
      it 'allows user to select unassigned', js: true do
        visit namespace_project_issue_path(project.namespace, project, issue)
495

496 497 498
        page.within('.milestone') do
          expect(page).to have_content "None"
        end
499

500 501 502 503
        find('.block.milestone .edit-link').click
        sleep 2 # wait for ajax stuff to complete
        first('.dropdown-content li').click
        sleep 2
504
        page.within('.milestone') do
505
          expect(page).to have_content 'None'
506 507
        end

508
        expect(issue.reload.milestone).to be_nil
509
      end
510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529

      it 'allows user to de-select milestone', js: true do
        visit namespace_project_issue_path(project.namespace, project, issue)

        page.within('.milestone') do
          click_link 'Edit'
          click_link milestone.title

          page.within '.value' do
            expect(page).to have_content milestone.title
          end

          click_link 'Edit'
          click_link milestone.title

          page.within '.value' do
            expect(page).to have_content 'None'
          end
        end
      end
530 531 532 533
    end

    context 'by unauthorized user' do
      let(:guest) { create(:user) }
Dmitriy Zaporozhets committed
534

Rémy Coutable committed
535
      before do
Dmitriy Zaporozhets committed
536
        project.team << [guest, :guest]
537 538 539 540
        issue.milestone = milestone
        issue.save
      end

541
      it 'shows milestone text', js: true do
542 543 544
        logout
        login_with guest

Vinnie Okada committed
545
        visit namespace_project_issue_path(project.namespace, project, issue)
546
        expect(page).to have_content milestone.title
547 548
      end
    end
549 550 551 552

    describe 'removing assignee' do
      let(:user2) { create(:user) }

Rémy Coutable committed
553
      before do
554 555 556 557
        issue.assignee = user2
        issue.save
      end
    end
558 559
  end

560 561 562 563 564 565
  describe 'new issue' do
    context 'dropzone upload file', js: true do
      before do
        visit new_namespace_project_issue_path(project.namespace, project)
      end

566
      it 'uploads file when dragging into textarea' do
567 568 569 570 571 572 573 574 575 576
        drop_in_dropzone test_image_file

        # Wait for the file to upload
        sleep 1

        expect(page.find_field("issue_description").value).to have_content 'banana_sample'
      end
    end
  end

577
  describe 'new issue by email' do
578
    shared_examples 'show the email in the modal' do
579 580 581 582 583 584 585
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")

        visit namespace_project_issues_path(project.namespace, project)
        click_button('Email a new issue')
      end

586
      it 'click the button to show modal for the new email' do
587 588 589 590 591 592 593
        page.within '#issue-email-modal' do
          email = project.new_issue_address(@user)

          expect(page).to have_selector("input[value='#{email}']")
        end
      end
    end
594 595 596 597 598 599 600 601 602 603

    context 'with existing issues' do
      let!(:issue) { create(:issue, project: project, author: @user) }

      it_behaves_like 'show the email in the modal'
    end

    context 'without existing issues' do
      it_behaves_like 'show the email in the modal'
    end
604 605
  end

Phil Hughes committed
606 607 608 609 610 611 612 613
  describe 'due date' do
    context 'update due on issue#show', js: true do
      let(:issue) { create(:issue, project: project, author: @user, assignee: @user) }

      before do
        visit namespace_project_issue_path(project.namespace, project, issue)
      end

614
      it 'adds due date to issue' do
Phil Hughes committed
615 616 617 618 619 620 621 622 623 624 625
        page.within '.due_date' do
          click_link 'Edit'

          page.within '.ui-datepicker-calendar' do
            first('.ui-state-default').click
          end

          expect(page).to have_no_content 'None'
        end
      end

626
      it 'removes due date from issue' do
Phil Hughes committed
627 628 629 630 631 632 633
        page.within '.due_date' do
          click_link 'Edit'

          page.within '.ui-datepicker-calendar' do
            first('.ui-state-default').click
          end

Phil Hughes committed
634
          expect(page).to have_no_content 'No due date'
Phil Hughes committed
635 636

          click_link 'remove due date'
Phil Hughes committed
637
          expect(page).to have_content 'No due date'
Phil Hughes committed
638 639 640 641 642
        end
      end
    end
  end

643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662
  def drop_in_dropzone(file_path)
    # Generate a fake input selector
    page.execute_script <<-JS
      var fakeFileInput = window.$('<input/>').attr(
        {id: 'fakeFileInput', type: 'file'}
      ).appendTo('body');
    JS
    # Attach the file to the fake input selector with Capybara
    attach_file("fakeFileInput", file_path)
    # Add the file to a fileList array and trigger the fake drop event
    page.execute_script <<-JS
      var fileList = [$('#fakeFileInput')[0].files[0]];
      var e = jQuery.Event('drop', { dataTransfer : { files : fileList } });
      $('.div-dropzone')[0].dropzone.listeners[0].events.drop(e);
    JS
  end

  def test_image_file
    File.join(Rails.root, 'spec', 'fixtures', 'banana_sample.gif')
  end
Dmitriy Zaporozhets committed
663
end