BigW Consortium Gitlab

merge_request_spec.rb 49.5 KB
Newer Older
1 2
require 'spec_helper'

Douwe Maan committed
3
describe MergeRequest, models: true do
4 5
  include RepoHelpers

6 7
  subject { create(:merge_request) }

8
  describe 'associations' do
9 10
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
11
    it { is_expected.to belong_to(:merge_user).class_name("User") }
12
    it { is_expected.to belong_to(:assignee) }
13
    it { is_expected.to have_many(:merge_request_diffs).dependent(:destroy) }
14 15
  end

16 17 18 19 20 21 22 23 24 25
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

26 27 28 29 30
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

31
  describe 'validation' do
32 33
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
34

35
    context "Validation of merge user with Merge When Pipeline Succeeds" do
36 37 38 39 40
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
41
        subject.merge_when_pipeline_succeeds = true
42 43 44 45
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
46
        subject.merge_when_pipeline_succeeds = true
47 48 49 50 51
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
52 53
  end

54
  describe 'respond to' do
55 56 57
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
58
    it { is_expected.to respond_to(:merge_params) }
59
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
60
  end
61

62 63 64 65 66 67
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

68
  describe '#target_branch_sha' do
69
    let(:project) { create(:project, :repository) }
70

71
    subject { create(:merge_request, source_project: project, target_project: project) }
72

73
    context 'when the target branch does not exist' do
74 75 76
      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
      end
77 78

      it 'returns nil' do
79
        expect(subject.target_branch_sha).to be_nil
80 81
      end
    end
82 83 84 85 86 87

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
88 89
  end

90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(nil)

      expect(subject.card_attributes).
        to eq({ 'Author' => 'Robert', 'Assignee' => nil })
    end

    it 'includes the assignee name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(double(name: 'Douwe'))

      expect(subject.card_attributes).
        to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
    end
  end

  describe '#assignee_or_author?' do
    let(:user) { create(:user) }

    it 'returns true for a user that is assigned to a merge request' do
      subject.assignee = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns true for a user that is the author of a merge request' do
      subject.author = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(subject.assignee_or_author?(user)).to eq(false)
    end
  end

128 129 130 131 132 133 134 135 136 137 138
  describe '#cache_merge_request_closes_issues!' do
    before do
      subject.project.team << [subject.author, :developer]
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

139
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
140 141 142 143 144 145 146 147
    end

    it 'does not cache issues from external trackers' do
      subject.project.update_attribute(:has_external_issue_tracker, true)
      issue  = ExternalIssue.new('JIRA-123', subject.project)
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

148
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
149 150 151
    end
  end

152
  describe '#source_branch_sha' do
153 154 155 156 157
    let(:last_branch_commit) { subject.source_project.repository.commit(subject.source_branch) }

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
158
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
159 160 161
      end
    end

162 163 164
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
165
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
166 167 168
      end
    end

169 170 171
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
172
        expect(subject.source_branch_sha).to be_nil
173 174
      end
    end
175 176 177 178 179 180

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
181 182
  end

183
  describe '#to_reference' do
184 185 186
    let(:project) { build(:empty_project, name: 'sample-project') }
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

187
    it 'returns a String reference to the object' do
188
      expect(merge_request.to_reference).to eq "!1"
189 190 191
    end

    it 'supports a cross-project reference' do
192
      another_project = build(:empty_project, name: 'another-project', namespace: project.namespace)
193
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
194
    end
195 196 197 198

    it 'returns a String reference with the full path' do
      expect(merge_request.to_reference(full: true)).to eq(project.path_with_namespace + '!1')
    end
199
  end
200

201
  describe '#raw_diffs' do
202 203 204 205 206 207 208
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

209
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
210

211 212 213 214 215 216 217 218 219 220 221 222 223 224 225
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

226 227 228 229 230 231
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
232
        merge_request.save
233

234
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
235 236 237 238 239 240

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
241
      it 'delegates to the compare object, setting expanded: true' do
242 243
        merge_request.compare = double(:compare)

244
        expect(merge_request.compare).to receive(:diffs).with(options.merge(expanded: true))
245 246 247 248 249 250

        merge_request.diffs(options)
      end
    end
  end

251 252 253 254 255 256
  describe '#diff_size' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    context 'when there are MR diffs' do
257
      it 'returns the correct count' do
258
        merge_request.save
259 260

        expect(merge_request.diff_size).to eq('105')
261 262
      end

263 264 265 266 267
      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        merge_request.save

        expect(merge_request.diff_size).to eq('2+')
268 269 270
      end

      it 'does not perform highlighting' do
271 272
        merge_request.save

273 274 275 276 277 278 279
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
280
      def set_compare(merge_request)
281 282 283 284 285 286 287 288 289 290
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
291 292 293 294 295 296 297 298 299 300
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('105')
      end

      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('2+')
301 302 303
      end

      it 'does not perform highlighting' do
304 305
        set_compare(merge_request)

306 307 308 309 310 311 312
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

313
  describe "#related_notes" do
314
    let!(:merge_request) { create(:merge_request) }
315 316

    before do
317
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
318 319
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
320
      create(:note, noteable: merge_request, project: merge_request.project)
321 322
    end

323
    it "includes notes for commits" do
324
      expect(merge_request.commits).not_to be_empty
325
      expect(merge_request.related_notes.count).to eq(2)
326
    end
327

328
    it "includes notes for commits from target project as well" do
329 330 331
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

332
      expect(merge_request.commits).not_to be_empty
333
      expect(merge_request.related_notes.count).to eq(3)
334
    end
335
  end
336

337 338
  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
339 340
      subject.source_project = build_stubbed(:empty_project, namespace: create(:group))
      subject.target_project = build_stubbed(:empty_project, namespace: create(:group))
341

342
      expect(subject.for_fork?).to be_truthy
343
    end
Dmitriy Zaporozhets committed
344

345
    it 'returns false if is not for a fork' do
346
      expect(subject.for_fork?).to be_falsey
347 348 349
    end
  end

350
  describe '#closes_issues' do
351 352
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
353 354 355 356

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
357 358

    before do
359
      subject.project.team << [subject.author, :developer]
360
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
361 362
    end

363 364 365
    it 'accesses the set of issues that will be closed on acceptance' do
      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)
366

367
      closed = subject.closes_issues
368

369 370
      expect(closed).to include(issue0, issue1)
    end
371

372 373 374
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
375

376
      expect(subject.closes_issues).to be_empty
377
    end
378
  end
379

380
  describe '#issues_mentioned_but_not_closing' do
381 382 383 384
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }

    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
385

386
    it 'detects issues mentioned in description but not closed' do
387
      subject.project.team << [subject.author, :developer]
388
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
389

390
      allow(subject).to receive(:commits).and_return([commit])
391 392
      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)
393

394
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
395
    end
396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412

    context 'when the project has an external issue tracker' do
      before do
        subject.project.team << [subject.author, :developer]
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
413 414
  end

415
  describe "#work_in_progress?" do
416 417 418
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
419
        expect(subject.work_in_progress?).to eq true
420
      end
421 422
    end

423 424
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
425
      expect(subject.work_in_progress?).to eq false
426 427
    end

428 429
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
430
      expect(subject.work_in_progress?).to eq false
431 432
    end

433
    it "doesn't detect WIP by default" do
434
      expect(subject.work_in_progress?).to eq false
435 436 437
    end
  end

438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
461
    end
462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Zeger-Jan van de Weg committed
478
  describe '#can_remove_source_branch?' do
479 480
    let(:user) { create(:user) }
    let(:user2) { create(:user) }
481 482 483 484

    before do
      subject.source_project.team << [user, :master]

485 486 487 488
      subject.source_branch = "feature"
      subject.target_branch = "master"
      subject.save!
    end
489

490
    it "can't be removed when its a protected branch" do
491
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
492 493 494
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

495
    it "can't remove a root ref" do
496 497
      subject.source_branch = "master"
      subject.target_branch = "feature"
498 499 500 501

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

502 503 504 505
    it "is unable to remove the source branch for a project the user cannot push to" do
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

506
    it "can be removed if the last commit is the head of the source branch" do
507
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
508

509
      expect(subject.can_remove_source_branch?(user)).to be_truthy
510
    end
511 512

    it "cannot be removed if the last commit is not also the head of the source branch" do
513 514
      subject.source_branch = "lfs"

515 516
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
517 518
  end

519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

534
    it 'includes its closed issues in the body' do
535
      issue = create(:issue, project: subject.project)
536

537
      subject.project.team << [subject.author, :developer]
538
      subject.description = "This issue Closes #{issue.to_reference}"
539 540 541 542 543

      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)

      expect(subject.merge_commit_message)
544
        .to match("Closes #{issue.to_reference}")
545 546 547 548 549 550 551 552 553 554 555 556 557 558
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
        .to match("See merge request #{request.to_reference}")
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
559 560 561 562 563 564 565 566 567 568 569 570 571 572

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message(include_description: true))
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message)
        .not_to match("By removing all code\n\n")
    end
573 574
  end

575
  describe "#reset_merge_when_pipeline_succeeds" do
576
    let(:merge_if_green) do
577
      create :merge_request, merge_when_pipeline_succeeds: true, merge_user: create(:user),
578 579
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
580

581
    it "sets the item to false" do
582
      merge_if_green.reset_merge_when_pipeline_succeeds
583 584
      merge_if_green.reload

585
      expect(merge_if_green.merge_when_pipeline_succeeds).to be_falsey
586 587
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
588 589 590
    end
  end

591
  describe "#hook_attrs" do
592
    let(:attrs_hash) { subject.hook_attrs }
593 594 595 596 597 598 599 600 601 602

    [:source, :target].each do |key|
      describe "#{key} key" do
        include_examples 'project hook data', project_key: key do
          let(:data)    { attrs_hash }
          let(:project) { subject.send("#{key}_project") }
        end
      end
    end

603
    it "has all the required keys" do
604 605 606 607
      expect(attrs_hash).to include(:source)
      expect(attrs_hash).to include(:target)
      expect(attrs_hash).to include(:last_commit)
      expect(attrs_hash).to include(:work_in_progress)
608 609 610 611
      expect(attrs_hash).to include(:total_time_spent)
      expect(attrs_hash).to include(:human_time_estimate)
      expect(attrs_hash).to include(:human_total_time_spent)
      expect(attrs_hash).to include('time_estimate')
612
    end
613 614 615
  end

  describe '#diverged_commits_count' do
616 617
    let(:project)      { create(:project, :repository) }
    let(:fork_project) { create(:project, :repository, forked_from_project: project) }
618

619
    context 'when the target branch does not exist anymore' do
620 621 622 623 624 625
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
        subject.reload
      end
626 627 628 629 630 631 632 633 634 635

      it 'does not crash' do
        expect{ subject.diverged_commits_count }.not_to raise_error
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

636 637 638 639
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
640
        expect(subject.diverged_commits_count).to eq(29)
641 642 643 644 645 646 647
      end
    end

    context 'diverged on fork' do
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
648
        expect(subject.diverged_commits_count).to eq(29)
649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679
      end
    end

    context 'rebased on fork' do
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
      before(:example) do
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
        expect(subject).to receive(:compute_diverged_commits_count).
          once.
          and_return(2)

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
        expect(subject).to receive(:compute_diverged_commits_count).
          twice.
          and_return(2)

        subject.diverged_commits_count
680
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
681 682 683 684 685 686 687 688 689
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
        expect(subject).to receive(:compute_diverged_commits_count).
          twice.
          and_return(2)

        subject.diverged_commits_count
690
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
691 692 693
        subject.diverged_commits_count
      end
    end
694 695
  end

696
  it_behaves_like 'an editable mentionable' do
697
    subject { create(:merge_request, :simple) }
698

699 700
    let(:backref_text) { "merge request #{subject.to_reference}" }
    let(:set_mentionable_text) { ->(txt){ subject.description = txt } }
701
  end
Vinnie Okada committed
702 703

  it_behaves_like 'a Taskable' do
704
    subject { create :merge_request, :simple }
Vinnie Okada committed
705
  end
706

707 708
  describe '#commits_sha' do
    before do
709 710
      allow(subject.merge_request_diff).to receive(:commits_sha).
        and_return(['sha1'])
711 712
    end

713 714
    it 'delegates to merge request diff' do
      expect(subject.commits_sha).to eq ['sha1']
715 716 717
    end
  end

718
  describe '#head_pipeline' do
719
    describe 'when the source project exists' do
720
      it 'returns the latest pipeline' do
721
        pipeline = create(:ci_empty_pipeline, project: subject.source_project, ref: 'master', status: 'running', sha: "123abc", head_pipeline_of: subject)
722

723
        expect(subject.head_pipeline).to eq(pipeline)
724 725 726 727 728 729 730
      end
    end

    describe 'when the source project does not exist' do
      it 'returns nil' do
        allow(subject).to receive(:source_project).and_return(nil)

731
        expect(subject.head_pipeline).to be_nil
732 733 734
      end
    end
  end
Yorick Peterse committed
735

736
  describe '#all_pipelines' do
737
    shared_examples 'returning pipelines with proper ordering' do
738 739 740 741 742 743
      let!(:all_pipelines) do
        subject.all_commits_sha.map do |sha|
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
744 745 746 747 748
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
749
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
750
      end
751 752
    end

753 754 755 756 757 758
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
759
        subject.update(target_branch: 'v1.0.0')
760 761 762
      end

      it_behaves_like 'returning pipelines with proper ordering'
763
    end
764 765

    context 'with unsaved merge request' do
766
      subject { build(:merge_request) }
767 768 769

      let!(:pipeline) do
        create(:ci_empty_pipeline,
770
               project: subject.project,
771 772
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
773
      end
774 775 776 777 778

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
779 780
  end

781
  describe '#all_commits_sha' do
782 783 784 785
    context 'when merge request is persisted' do
      let(:all_commits_sha) do
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
786

787 788 789 790 791
      shared_examples 'returning all SHA' do
        it 'returns all SHA from all merge_request_diffs' do
          expect(subject.merge_request_diffs.size).to eq(2)
          expect(subject.all_commits_sha).to eq(all_commits_sha)
        end
792 793
      end

794 795 796 797 798 799
      context 'with a completely different branch' do
        before do
          subject.update(target_branch: 'v1.0.0')
        end

        it_behaves_like 'returning all SHA'
800 801
      end

802 803 804 805 806 807 808 809
      context 'with a branch having no difference' do
        before do
          subject.update(target_branch: 'v1.1.0')
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
810 811
    end

812 813 814 815 816 817 818 819 820 821 822
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
          expect(subject.all_commits_sha).to eq [commit, commit]
        end
823 824
      end

825 826 827 828 829 830 831
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
          expect(subject.all_commits_sha).to eq [subject.diff_head_sha]
        end
      end
832 833 834
    end
  end

Yorick Peterse committed
835
  describe '#participants' do
836
    let(:project) { create(:empty_project, :public) }
Yorick Peterse committed
837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
858 859 860 861 862 863

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)
864 865
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
866

867 868
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
869 870 871 872

      mr.assignee = user2
      mr.save

873 874
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
875 876
    end
  end
877 878

  describe '#check_if_can_be_merged' do
879
    let(:project) { create(:empty_project, only_allow_merge_if_pipeline_succeeds: true) }
880 881 882 883

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
884
      before do
885
        allow(subject).to receive(:broken?) { false }
886
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
887
      end
888

889
      it 'is marked as mergeable' do
890 891 892 893 894 895 896 897 898 899 900 901 902 903 904
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
      before { allow(subject).to receive(:broken?) { true } }

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
905
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
906 907 908 909 910 911 912 913 914
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
915
    let(:project) { create(:empty_project) }
916 917 918

    subject { create(:merge_request, source_project: project) }

919 920
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
921

922
      expect(subject.mergeable?).to be_falsey
923 924
    end

925
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
926 927
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
928
      expect(subject).to receive(:can_be_merged?) { true }
929 930 931 932 933 934

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
935
    let(:project) { create(:project, :repository) }
936 937 938

    subject { create(:merge_request, source_project: project) }

939
    it 'checks if merge request can be merged' do
940
      allow(subject).to receive(:mergeable_ci_state?) { true }
941 942 943 944 945 946 947 948 949
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
      before { subject.close }

      it 'returns false' do
950
        expect(subject.mergeable_state?).to be_falsey
951 952 953 954 955 956 957
      end
    end

    context 'when working in progress' do
      before { subject.title = 'WIP MR' }

      it 'returns false' do
958
        expect(subject.mergeable_state?).to be_falsey
959 960 961 962 963 964 965
      end
    end

    context 'when broken' do
      before { allow(subject).to receive(:broken?) { true } }

      it 'returns false' do
966
        expect(subject.mergeable_state?).to be_falsey
967 968 969 970
      end
    end

    context 'when failed' do
971
      context 'when #mergeable_ci_state? is false' do
972
        before do
973
          allow(subject).to receive(:mergeable_ci_state?) { false }
974 975 976 977
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
978 979
        end
      end
980

981
      context 'when #mergeable_discussions_state? is false' do
982 983 984 985 986 987 988 989
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
      end
990 991 992
    end
  end

993
  describe '#mergeable_ci_state?' do
994
    let(:project) { create(:empty_project, only_allow_merge_if_pipeline_succeeds: true) }
995
    let(:pipeline) { create(:ci_empty_pipeline) }
996 997 998

    subject { build(:merge_request, target_project: project) }

999
    context 'when it is only allowed to merge when build is green' do
1000
      context 'and a failed pipeline is associated' do
1001
        before do
1002
          pipeline.update(status: 'failed')
1003
          allow(subject).to receive(:head_pipeline) { pipeline }
1004
        end
1005

1006
        it { expect(subject.mergeable_ci_state?).to be_falsey }
1007 1008
      end

1009 1010 1011
      context 'and a successful pipeline is associated' do
        before do
          pipeline.update(status: 'success')
1012
          allow(subject).to receive(:head_pipeline) { pipeline }
1013 1014 1015 1016 1017 1018 1019 1020
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
          pipeline.update(status: 'skipped')
1021
          allow(subject).to receive(:head_pipeline) { pipeline }
1022 1023 1024 1025 1026
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

1027
      context 'when no pipeline is associated' do
1028
        before do
1029
          allow(subject).to receive(:head_pipeline) { nil }
1030 1031 1032
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1033 1034 1035
      end
    end

1036
    context 'when merges are not restricted to green builds' do
1037
      subject { build(:merge_request, target_project: build(:empty_project, only_allow_merge_if_pipeline_succeeds: false)) }
1038

1039
      context 'and a failed pipeline is associated' do
1040
        before do
1041
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
1042
          allow(subject).to receive(:head_pipeline) { pipeline }
1043 1044 1045 1046 1047
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

1048
      context 'when no pipeline is associated' do
1049
        before do
1050
          allow(subject).to receive(:head_pipeline) { nil }
1051 1052 1053
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1054 1055 1056
      end
    end
  end
1057

1058
  describe '#mergeable_discussions_state?' do
1059
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
1060

1061
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
1062
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
1063

1064
      context 'with all discussions resolved' do
1065
        before do
1066
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
1067 1068 1069
        end

        it 'returns true' do
1070
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1071 1072 1073
        end
      end

1074
      context 'with unresolved discussions' do
1075
        before do
1076
          merge_request.discussions.each(&:unresolve!)
1077 1078 1079
        end

        it 'returns false' do
1080
          expect(merge_request.mergeable_discussions_state?).to be_falsey
1081 1082
        end
      end
1083 1084 1085 1086 1087 1088 1089 1090 1091 1092

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
1093 1094
    end

1095
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
1096
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
1097

1098
      context 'with unresolved discussions' do
1099
        before do
1100
          merge_request.discussions.each(&:unresolve!)
1101 1102 1103
        end

        it 'returns true' do
1104
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1105 1106 1107 1108 1109
        end
      end
    end
  end

Douwe Maan committed
1110
  describe "#environments_for" do
1111
    let(:project)       { create(:project, :repository) }
Douwe Maan committed
1112
    let(:user)          { project.creator }
Z.J. van de Weg committed
1113 1114
    let(:merge_request) { create(:merge_request, source_project: project) }

Douwe Maan committed
1115 1116 1117 1118 1119
    before do
      merge_request.source_project.add_master(user)
      merge_request.target_project.add_master(user)
    end

1120 1121
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
1122

1123 1124 1125 1126 1127 1128
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
Douwe Maan committed
1129
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
1130 1131 1132 1133 1134
      end
    end

    context 'with environments on source project' do
      let(:source_project) do
1135
        create(:project, :repository) do |fork_project|
1136 1137 1138
          fork_project.create_forked_project_link(forked_to_project_id: fork_project.id, forked_from_project_id: project.id)
        end
      end
Kamil Trzcinski committed
1139

1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
Douwe Maan committed
1153
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
1154 1155 1156 1157 1158 1159 1160 1161 1162 1163
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
Douwe Maan committed
1164
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
1165 1166
        end
      end
1167 1168 1169 1170 1171 1172 1173 1174
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
Douwe Maan committed
1175
        expect(merge_request.environments_for(user)).to be_empty
1176
      end
Z.J. van de Weg committed
1177 1178 1179
    end
  end

1180
  describe "#reload_diff" do
1181
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
1182 1183 1184

    let(:commit) { subject.project.commit(sample_commit.id) }

1185
    it "does not change existing merge request diff" do
1186
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1187 1188 1189
      subject.reload_diff
    end

1190 1191 1192 1193
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1194 1195 1196 1197 1198 1199
    it "executs diff cache service" do
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject)

      subject.reload_diff
    end

1200
    it "updates diff discussion positions" do
1201 1202 1203
      old_diff_refs = subject.diff_refs

      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1204 1205 1206 1207 1208 1209
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1210 1211

        subject.merge_request_diff(true)
1212 1213
      end

1214
      expect(Discussions::UpdateDiffPositionService).to receive(:new).with(
1215
        subject.project,
1216
        subject.author,
1217 1218
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
1219
        paths: discussion.position.paths
1220 1221
      ).and_call_original

1222
      expect_any_instance_of(Discussions::UpdateDiffPositionService).to receive(:execute).with(discussion).and_call_original
1223 1224
      expect_any_instance_of(DiffNote).to receive(:save).once

1225
      subject.reload_diff(subject.author)
1226 1227
    end
  end
1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
        subject.project.repository.raw_repository.delete_branch(subject.target_branch)
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1242 1243 1244 1245
      end
    end
  end

1246
  describe "#diff_refs" do
1247 1248 1249 1250 1251 1252 1253 1254
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1255
        subject.diff_refs
1256 1257 1258 1259 1260 1261 1262 1263 1264
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1265
        expect(subject.diff_refs).to eq(expected_diff_refs)
1266 1267 1268
      end
    end
  end
1269

1270
  describe "#source_project_missing?" do
1271 1272
    let(:project)      { create(:empty_project) }
    let(:fork_project) { create(:empty_project, forked_from_project: project) }
1273 1274 1275
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

Katarzyna Kobierska committed
1276
    context "when the fork exists" do
1277 1278 1279 1280 1281 1282
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

1283
      it { expect(merge_request.source_project_missing?).to be_falsey }
1284 1285
    end

Katarzyna Kobierska committed
1286
    context "when the source project is the same as the target project" do
1287 1288
      let(:merge_request) { create(:merge_request, source_project: project) }

1289
      it { expect(merge_request.source_project_missing?).to be_falsey }
1290 1291
    end

Katarzyna Kobierska committed
1292
    context "when the fork does not exist" do
1293 1294 1295 1296 1297 1298
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

Katarzyna Kobierska committed
1299
      it "returns true" do
1300 1301 1302
        unlink_project.execute
        merge_request.reload

1303
        expect(merge_request.source_project_missing?).to be_truthy
1304 1305 1306 1307 1308
      end
    end
  end

  describe "#closed_without_fork?" do
1309 1310
    let(:project)      { create(:empty_project) }
    let(:fork_project) { create(:empty_project, forked_from_project: project) }
1311 1312 1313
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

Katarzyna Kobierska committed
1314
    context "when the merge request is closed" do
1315 1316 1317 1318 1319 1320
      let(:closed_merge_request) do
        create(:closed_merge_request,
          source_project: fork_project,
          target_project: project)
      end

Katarzyna Kobierska committed
1321
      it "returns false if the fork exist" do
1322 1323 1324
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

Katarzyna Kobierska committed
1325
      it "returns true if the fork does not exist" do
1326 1327 1328 1329 1330 1331
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
Katarzyna Kobierska committed
1332

Katarzyna Kobierska committed
1333
    context "when the merge request is open" do
Katarzyna Kobierska committed
1334 1335 1336 1337 1338 1339 1340 1341 1342 1343
      let(:open_merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1344
  end
1345

1346
  describe '#reopenable?' do
1347 1348 1349
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
Katarzyna Kobierska committed
1350

1351
        expect(subject.reopenable?).to be_truthy
1352 1353 1354
      end

      context 'forked project' do
1355
        let(:project)      { create(:empty_project) }
1356
        let(:user)         { create(:user) }
1357
        let(:fork_project) { create(:empty_project, forked_from_project: project, namespace: user.namespace) }
1358 1359

        let!(:merge_request) do
1360 1361 1362 1363 1364 1365 1366 1367
          create(:closed_merge_request,
            source_project: fork_project,
            target_project: project)
        end

        it 'returns false if unforked' do
          Projects::UnlinkForkService.new(fork_project, user).execute

1368
          expect(merge_request.reload.reopenable?).to be_falsey
1369 1370 1371
        end

        it 'returns false if the source project is deleted' do
1372
          Projects::DestroyService.new(fork_project, user).execute
1373

1374
          expect(merge_request.reload.reopenable?).to be_falsey
1375 1376
        end

Katarzyna Kobierska committed
1377
        it 'returns false if the merge request is merged' do
1378 1379
          merge_request.update_attributes(state: 'merged')

1380
          expect(merge_request.reload.reopenable?).to be_falsey
1381 1382
        end
      end
Katarzyna Kobierska committed
1383 1384
    end

Katarzyna Kobierska committed
1385
    context 'when the merge request is opened' do
1386
      it 'returns false' do
1387
        expect(subject.reopenable?).to be_falsey
1388
      end
Katarzyna Kobierska committed
1389 1390
    end
  end
1391

1392 1393
  describe '#mergeable_with_slash_command?' do
    def create_pipeline(status)
Felipe Artur committed
1394
      pipeline = create(:ci_pipeline_with_one_job,
1395 1396 1397
        project: project,
        ref:     merge_request.source_branch,
        sha:     merge_request.diff_head_sha,
1398 1399
        status:  status,
        head_pipeline_of: merge_request)
Felipe Artur committed
1400 1401

      pipeline
1402 1403
    end

1404
    let(:project)       { create(:project, :public, :repository, only_allow_merge_if_pipeline_succeeds: true) }
1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458
    let(:developer)     { create(:user) }
    let(:user)          { create(:user) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let(:mr_sha)        { merge_request.diff_head_sha }

    before do
      project.team << [developer, :developer]
    end

    context 'when autocomplete_precheck is set to true' do
      it 'is mergeable by developer' do
        expect(merge_request.mergeable_with_slash_command?(developer, autocomplete_precheck: true)).to be_truthy
      end

      it 'is not mergeable by normal user' do
        expect(merge_request.mergeable_with_slash_command?(user, autocomplete_precheck: true)).to be_falsey
      end
    end

    context 'when autocomplete_precheck is set to false' do
      it 'is mergeable by developer' do
        expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_truthy
      end

      it 'is not mergeable by normal user' do
        expect(merge_request.mergeable_with_slash_command?(user, last_diff_sha: mr_sha)).to be_falsey
      end

      context 'closed MR'  do
        before do
          merge_request.update_attribute(:state, :closed)
        end

        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_falsey
        end
      end

      context 'MR with WIP'  do
        before do
          merge_request.update_attribute(:title, 'WIP: some MR')
        end

        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_falsey
        end
      end

      context 'sha differs from the MR diff_head_sha'  do
        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: 'some other sha')).to be_falsey
        end
      end

Jarka Kadlecova committed
1459 1460 1461 1462 1463 1464
      context 'sha is not provided'  do
        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer)).to be_falsey
        end
      end

1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486
      context 'with pipeline ok'  do
        before do
          create_pipeline(:success)
        end

        it 'is mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_truthy
        end
      end

      context 'with failing pipeline'  do
        before do
          create_pipeline(:failed)
        end

        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_falsey
        end
      end

      context 'with running pipeline'  do
        before do
Felipe Artur committed
1487
          create_pipeline(:running)
1488 1489 1490 1491 1492 1493 1494 1495 1496
        end

        it 'is mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_truthy
        end
      end
    end
  end

1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517
  describe '#has_commits?' do
    before do
      allow(subject.merge_request_diff).to receive(:commits_count).
        and_return(2)
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
      allow(subject.merge_request_diff).to receive(:commits_count).
        and_return(0)
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536

  describe '#merge_request_diff_for' do
    subject { create(:merge_request, importing: true) }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'with diff refs' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff1.diff_refs)).to eq(merge_request_diff1)
      end
    end

    context 'with a commit SHA' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff3.head_commit_sha)).to eq(merge_request_diff3)
      end
    end
  end
1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568

  describe '#version_params_for' do
    subject { create(:merge_request, importing: true) }
    let(:project) { subject.project }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'when the diff refs are for an older merge request version' do
      let(:diff_refs) { merge_request_diff1.diff_refs }

      it 'returns the diff ID for the version to show' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff1.id)
      end
    end

    context 'when the diff refs are for a comparison between merge request versions' do
      let(:diff_refs) { merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs }

      it 'returns the diff ID and start sha of the versions to compare' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff3.id, start_sha: merge_request_diff1.head_commit_sha)
      end
    end

    context 'when the diff refs are not for a merge request version' do
      let(:diff_refs) { project.commit(sample_commit.id).diff_refs }

      it 'returns nil' do
        expect(subject.version_params_for(diff_refs)).to be_nil
      end
    end
  end
1569
end