BigW Consortium Gitlab

pipeline_schedules_controller_spec.rb 12.9 KB
Newer Older
1 2 3
require 'spec_helper'

describe Projects::PipelineSchedulesController do
4 5
  include AccessMatchersForController

6
  set(:project) { create(:project, :public) }
7 8 9 10 11 12 13 14 15 16 17 18 19 20 21
  let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project) }

  describe 'GET #index' do
    let(:scope) { nil }
    let!(:inactive_pipeline_schedule) do
      create(:ci_pipeline_schedule, :inactive, project: project)
    end

    it 'renders the index view' do
      visit_pipelines_schedules

      expect(response).to have_http_status(:ok)
      expect(response).to render_template(:index)
    end

22 23 24 25 26 27 28 29
    it 'avoids N + 1 queries' do
      control_count = ActiveRecord::QueryRecorder.new { visit_pipelines_schedules }.count

      create_list(:ci_pipeline_schedule, 2, project: project)

      expect { visit_pipelines_schedules }.not_to exceed_query_limit(control_count)
    end

30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48
    context 'when the scope is set to active' do
      let(:scope) { 'active' }

      before do
        visit_pipelines_schedules
      end

      it 'only shows active pipeline schedules' do
        expect(response).to have_http_status(:ok)
        expect(assigns(:schedules)).to include(pipeline_schedule)
        expect(assigns(:schedules)).not_to include(inactive_pipeline_schedule)
      end
    end

    def visit_pipelines_schedules
      get :index, namespace_id: project.namespace.to_param, project_id: project, scope: scope
    end
  end

49
  describe 'GET #new' do
Shinya Maeda committed
50 51
    set(:user) { create(:user) }

52
    before do
Shinya Maeda committed
53 54
      project.add_developer(user)
      sign_in(user)
55
    end
56

57 58 59 60 61 62 63 64 65
    it 'initializes a pipeline schedule model' do
      get :new, namespace_id: project.namespace.to_param, project_id: project

      expect(response).to have_http_status(:ok)
      expect(assigns(:schedule)).to be_a_new(Ci::PipelineSchedule)
    end
  end

  describe 'POST #create' do
66
    describe 'functionality' do
Shinya Maeda committed
67 68
      set(:user) { create(:user) }

69
      before do
Shinya Maeda committed
70 71
        project.add_developer(user)
        sign_in(user)
72 73
      end

74
      let(:basic_param) do
Shinya Maeda committed
75
        attributes_for(:ci_pipeline_schedule)
76 77
      end

78 79 80
      context 'when variables_attributes has one variable' do
        let(:schedule) do
          basic_param.merge({
Shinya Maeda committed
81
            variables_attributes: [{ key: 'AAA', value: 'AAA123' }]
82 83
          })
        end
84

85
        it 'creates a new schedule' do
Shinya Maeda committed
86
          expect { go }
87 88
            .to change { Ci::PipelineSchedule.count }.by(1)
            .and change { Ci::PipelineScheduleVariable.count }.by(1)
89

90
          expect(response).to have_http_status(:found)
Shinya Maeda committed
91 92 93 94 95

          Ci::PipelineScheduleVariable.last.tap do |v|
            expect(v.key).to eq("AAA")
            expect(v.value).to eq("AAA123")
          end
96
        end
97 98
      end

99 100 101 102 103 104 105 106 107 108 109 110
      context 'when variables_attributes has two variables and duplicted' do
        let(:schedule) do
          basic_param.merge({
            variables_attributes: [{ key: 'AAA', value: 'AAA123' }, { key: 'AAA', value: 'BBB123' }]
          })
        end

        it 'returns an error that the keys of variable are duplicated' do
          expect { go }
            .to change { Ci::PipelineSchedule.count }.by(0)
            .and change { Ci::PipelineScheduleVariable.count }.by(0)

111
          expect(assigns(:schedule).errors['variables']).not_to be_empty
112 113
        end
      end
114 115
    end

116
    describe 'security' do
Shinya Maeda committed
117
      let(:schedule) { attributes_for(:ci_pipeline_schedule) }
118

Shinya Maeda committed
119 120 121 122 123 124 125 126 127
      it { expect { go }.to be_allowed_for(:admin) }
      it { expect { go }.to be_allowed_for(:owner).of(project) }
      it { expect { go }.to be_allowed_for(:master).of(project) }
      it { expect { go }.to be_allowed_for(:developer).of(project) }
      it { expect { go }.to be_denied_for(:reporter).of(project) }
      it { expect { go }.to be_denied_for(:guest).of(project) }
      it { expect { go }.to be_denied_for(:user) }
      it { expect { go }.to be_denied_for(:external) }
      it { expect { go }.to be_denied_for(:visitor) }
128
    end
Shinya Maeda committed
129

130 131
    def go
      post :create, namespace_id: project.namespace.to_param, project_id: project, schedule: schedule
132 133
    end
  end
134

135 136
  describe 'PUT #update' do
    describe 'functionality' do
Shinya Maeda committed
137
      set(:user) { create(:user) }
138
      let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: user) }
139

140 141 142
      before do
        project.add_developer(user)
        sign_in(user)
143
      end
144

145 146
      context 'when a pipeline schedule has no variables' do
        let(:basic_param) do
Shinya Maeda committed
147
          { description: 'updated_desc', cron: '0 1 * * *', cron_timezone: 'UTC', ref: 'patch-x', active: true }
148 149 150
        end

        context 'when params include one variable' do
151 152
          let(:schedule) do
            basic_param.merge({
Shinya Maeda committed
153
              variables_attributes: [{ key: 'AAA', value: 'AAA123' }]
154 155 156
            })
          end

157
          it 'inserts new variable to the pipeline schedule' do
Shinya Maeda committed
158
            expect { go }.to change { Ci::PipelineScheduleVariable.count }.by(1)
159

160 161
            pipeline_schedule.reload
            expect(response).to have_http_status(:found)
162
            expect(pipeline_schedule.variables.last.key).to eq('AAA')
163
            expect(pipeline_schedule.variables.last.value).to eq('AAA123')
164 165 166
          end
        end

167 168 169 170 171 172 173 174
        context 'when params include two duplicated variables' do
          let(:schedule) do
            basic_param.merge({
              variables_attributes: [{ key: 'AAA', value: 'AAA123' }, { key: 'AAA', value: 'BBB123' }]
            })
          end

          it 'returns an error that variables are duplciated' do
175
            go
176

177
            expect(assigns(:schedule).errors['variables']).not_to be_empty
178 179
          end
        end
180 181
      end

182 183
      context 'when a pipeline schedule has one variable' do
        let(:basic_param) do
Shinya Maeda committed
184
          { description: 'updated_desc', cron: '0 1 * * *', cron_timezone: 'UTC', ref: 'patch-x', active: true }
185
        end
186

187
        let!(:pipeline_schedule_variable) do
188 189
          create(:ci_pipeline_schedule_variable,
            key: 'CCC', pipeline_schedule: pipeline_schedule)
190
        end
191

192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218
        context 'when adds a new variable' do
          let(:schedule) do
            basic_param.merge({
              variables_attributes: [{ key: 'AAA', value: 'AAA123' }]
            })
          end

          it 'adds the new variable' do
            expect { go }.to change { Ci::PipelineScheduleVariable.count }.by(1)

            pipeline_schedule.reload
            expect(pipeline_schedule.variables.last.key).to eq('AAA')
          end
        end

        context 'when adds a new duplicated variable' do
          let(:schedule) do
            basic_param.merge({
              variables_attributes: [{ key: 'CCC', value: 'AAA123' }]
            })
          end

          it 'returns an error' do
            expect { go }.not_to change { Ci::PipelineScheduleVariable.count }

            pipeline_schedule.reload
            expect(assigns(:schedule).errors['variables']).not_to be_empty
219
          end
220
        end
221

222 223 224 225 226 227
        context 'when updates a variable' do
          let(:schedule) do
            basic_param.merge({
              variables_attributes: [{ id: pipeline_schedule_variable.id, value: 'new_value' }]
            })
          end
228

229 230
          it 'updates the variable' do
            expect { go }.not_to change { Ci::PipelineScheduleVariable.count }
231

232 233
            pipeline_schedule_variable.reload
            expect(pipeline_schedule_variable.value).to eq('new_value')
234
          end
235
        end
236

237 238 239 240 241 242
        context 'when deletes a variable' do
          let(:schedule) do
            basic_param.merge({
              variables_attributes: [{ id: pipeline_schedule_variable.id, _destroy: true }]
            })
          end
243

244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
          it 'delete the existsed variable' do
            expect { go }.to change { Ci::PipelineScheduleVariable.count }.by(-1)
          end
        end

        context 'when deletes and creates a same key simultaneously' do
          let(:schedule) do
            basic_param.merge({
              variables_attributes: [{ id: pipeline_schedule_variable.id, _destroy: true },
                                     { key: 'CCC', value: 'CCC123' }]
            })
          end

          it 'updates the variable' do
            expect { go }.not_to change { Ci::PipelineScheduleVariable.count }

            pipeline_schedule.reload
            expect(pipeline_schedule.variables.last.key).to eq('CCC')
            expect(pipeline_schedule.variables.last.value).to eq('CCC123')
263 264
          end
        end
265 266
      end
    end
267

268
    describe 'security' do
269 270 271 272 273
      let(:schedule) { { description: 'updated_desc' } }

      it { expect { go }.to be_allowed_for(:admin) }
      it { expect { go }.to be_allowed_for(:owner).of(project) }
      it { expect { go }.to be_allowed_for(:master).of(project) }
Shinya Maeda committed
274
      it { expect { go }.to be_allowed_for(:developer).of(project).own(pipeline_schedule) }
275 276 277 278 279 280
      it { expect { go }.to be_denied_for(:reporter).of(project) }
      it { expect { go }.to be_denied_for(:guest).of(project) }
      it { expect { go }.to be_denied_for(:user) }
      it { expect { go }.to be_denied_for(:external) }
      it { expect { go }.to be_denied_for(:visitor) }

281 282 283 284 285 286
      context 'when a developer created a pipeline schedule' do
        let(:developer_1) { create(:user) }
        let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: developer_1) }

        before do
          project.add_developer(developer_1)
287
        end
288

289 290 291
        it { expect { go }.to be_allowed_for(developer_1) }
        it { expect { go }.to be_denied_for(:developer).of(project) }
        it { expect { go }.to be_allowed_for(:master).of(project) }
292
      end
293

294 295 296 297 298 299 300 301
      context 'when a master created a pipeline schedule' do
        let(:master_1) { create(:user) }
        let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: master_1) }

        before do
          project.add_master(master_1)
        end

302 303 304
        it { expect { go }.to be_allowed_for(master_1) }
        it { expect { go }.to be_allowed_for(:master).of(project) }
        it { expect { go }.to be_denied_for(:developer).of(project) }
305
      end
306
    end
Shinya Maeda committed
307 308 309 310

    def go
      put :update, namespace_id: project.namespace.to_param,
                   project_id: project, id: pipeline_schedule,
311
                   schedule: schedule
Shinya Maeda committed
312
    end
313
  end
314

315 316 317
  describe 'GET #edit' do
    describe 'functionality' do
      let(:user) { create(:user) }
318

319 320 321 322 323 324 325 326 327 328 329 330
      before do
        project.add_master(user)
        sign_in(user)
      end

      it 'loads the pipeline schedule' do
        get :edit, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id

        expect(response).to have_http_status(:ok)
        expect(assigns(:schedule)).to eq(pipeline_schedule)
      end
    end
331

332 333 334 335
    describe 'security' do
      it { expect { go }.to be_allowed_for(:admin) }
      it { expect { go }.to be_allowed_for(:owner).of(project) }
      it { expect { go }.to be_allowed_for(:master).of(project) }
Shinya Maeda committed
336
      it { expect { go }.to be_allowed_for(:developer).of(project).own(pipeline_schedule) }
337 338 339 340 341
      it { expect { go }.to be_denied_for(:reporter).of(project) }
      it { expect { go }.to be_denied_for(:guest).of(project) }
      it { expect { go }.to be_denied_for(:user) }
      it { expect { go }.to be_denied_for(:external) }
      it { expect { go }.to be_denied_for(:visitor) }
342 343
    end

344
    def go
345
      get :edit, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
346 347
    end
  end
348

349 350 351 352 353
  describe 'GET #take_ownership' do
    describe 'security' do
      it { expect { go }.to be_allowed_for(:admin) }
      it { expect { go }.to be_allowed_for(:owner).of(project) }
      it { expect { go }.to be_allowed_for(:master).of(project) }
Shinya Maeda committed
354
      it { expect { go }.to be_allowed_for(:developer).of(project).own(pipeline_schedule) }
355 356 357 358 359 360 361 362 363
      it { expect { go }.to be_denied_for(:reporter).of(project) }
      it { expect { go }.to be_denied_for(:guest).of(project) }
      it { expect { go }.to be_denied_for(:user) }
      it { expect { go }.to be_denied_for(:external) }
      it { expect { go }.to be_denied_for(:visitor) }
    end

    def go
      post :take_ownership, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
364 365 366
    end
  end

367 368
  describe 'DELETE #destroy' do
    set(:user) { create(:user) }
369

370 371 372 373
    context 'when a developer makes the request' do
      before do
        project.add_developer(user)
        sign_in(user)
374

375
        delete :destroy, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
376
      end
Shinya Maeda committed
377

378
      it 'does not delete the pipeline schedule' do
Shinya Maeda committed
379
        expect(response).to have_http_status(:not_found)
380
      end
Shinya Maeda committed
381
    end
382

383
    context 'when a master makes the request' do
384 385 386 387 388
      before do
        project.add_master(user)
        sign_in(user)
      end

389 390 391 392
      it 'destroys the pipeline schedule' do
        expect do
          delete :destroy, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
        end.to change { project.pipeline_schedules.count }.by(-1)
393

394
        expect(response).to have_http_status(302)
395 396
      end
    end
397
  end
398
end