BigW Consortium Gitlab

issue_spec.rb 17.3 KB
Newer Older
gitlabhq committed
1 2
require 'spec_helper'

Douwe Maan committed
3
describe Issue, models: true do
gitlabhq committed
4
  describe "Associations" do
5
    it { is_expected.to belong_to(:milestone) }
gitlabhq committed
6 7
  end

8
  describe 'modules' do
9 10 11
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
12
    it { is_expected.to include_module(Issuable) }
13 14 15
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
16 17
  end

18
  subject { create(:issue) }
19

20 21 22 23 24
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

25
  describe '.visible_to_user' do
26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44
    let(:user) { create(:user) }
    let(:authorized_user) { create(:user) }
    let(:project) { create(:project, namespace: authorized_user.namespace) }
    let!(:public_issue) { create(:issue, project: project) }
    let!(:confidential_issue) { create(:issue, project: project, confidential: true) }

    it 'returns non confidential issues for nil user' do
      expect(Issue.visible_to_user(nil).count).to be(1)
    end

    it 'returns non confidential issues for user not authorized for the issues projects' do
      expect(Issue.visible_to_user(user).count).to be(1)
    end

    it 'returns all issues for user authorized for the issues projects' do
      expect(Issue.visible_to_user(authorized_user).count).to be(2)
    end
  end

45 46 47 48 49 50 51 52 53 54 55 56
  describe '#to_reference' do
    it 'returns a String reference to the object' do
      expect(subject.to_reference).to eq "##{subject.iid}"
    end

    it 'supports a cross-project reference' do
      cross = double('project')
      expect(subject.to_reference(cross)).
        to eq "#{subject.project.to_reference}##{subject.iid}"
    end
  end

57 58
  describe '#is_being_reassigned?' do
    it 'returns true if the issue assignee has changed' do
59
      subject.assignee = create(:user)
60
      expect(subject.is_being_reassigned?).to be_truthy
61 62
    end
    it 'returns false if the issue assignee has not changed' do
63
      expect(subject.is_being_reassigned?).to be_falsey
64 65
    end
  end
66 67

  describe '#is_being_reassigned?' do
Johannes Schleifenbaum committed
68
    it 'returns issues assigned to user' do
69 70
      user = create(:user)
      create_list(:issue, 2, assignee: user)
71

72
      expect(Issue.open_for(user).count).to eq 2
73 74
    end
  end
75

76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102
  describe '#closed_by_merge_requests' do
    let(:project) { create(:project) }
    let(:issue)   { create(:issue, project: project, state: "opened")}
    let(:closed_issue) { build(:issue, project: project, state: "closed")}

    let(:mr) do
      opts = {
        title: 'Awesome merge_request',
        description: "Fixes #{issue.to_reference}",
        source_branch: 'feature',
        target_branch: 'master'
      }
      MergeRequests::CreateService.new(project, project.owner, opts).execute
    end

    let(:closed_mr) do
      opts = {
        title: 'Awesome merge_request 2',
        description: "Fixes #{issue.to_reference}",
        source_branch: 'feature',
        target_branch: 'master',
        state: 'closed'
      }
      MergeRequests::CreateService.new(project, project.owner, opts).execute
    end

    it 'returns the merge request to close this issue' do
103
      mr
104

105
      expect(issue.closed_by_merge_requests(mr.author)).to eq([mr])
106 107
    end

108 109 110
    it "returns an empty array when the merge request is closed already" do
      closed_mr

111
      expect(issue.closed_by_merge_requests(closed_mr.author)).to eq([])
112 113
    end

114
    it "returns an empty array when the current issue is closed already" do
115
      expect(closed_issue.closed_by_merge_requests(closed_issue.author)).to eq([])
116 117 118
    end
  end

119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143
  describe '#referenced_merge_requests' do
    it 'returns the referenced merge requests' do
      project = create(:project, :public)

      mr1 = create(:merge_request,
                   source_project: project,
                   source_branch:  'master',
                   target_branch:  'feature')

      mr2 = create(:merge_request,
                   source_project: project,
                   source_branch:  'feature',
                   target_branch:  'master')

      issue = create(:issue, description: mr1.to_reference, project: project)

      create(:note_on_issue,
             noteable:   issue,
             note:       mr2.to_reference,
             project_id: project.id)

      expect(issue.referenced_merge_requests).to eq([mr1, mr2])
    end
  end

144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
  describe '#can_move?' do
    let(:user) { create(:user) }
    let(:issue) { create(:issue) }
    subject { issue.can_move?(user) }

    context 'user is not a member of project issue belongs to' do
      it { is_expected.to eq false}
    end

    context 'user is reporter in project issue belongs to' do
      let(:project) { create(:project) }
      let(:issue) { create(:issue, project: project) }

      before { project.team << [user, :reporter] }

      it { is_expected.to eq true }

161 162 163 164 165
      context 'issue not persisted' do
        let(:issue) { build(:issue, project: project) }
        it { is_expected.to eq false }
      end

166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198
      context 'checking destination project also' do
        subject { issue.can_move?(user, to_project) }
        let(:to_project) { create(:project) }

        context 'destination project allowed' do
          before { to_project.team << [user, :reporter] }
          it { is_expected.to eq true }
        end

        context 'destination project not allowed' do
          before { to_project.team << [user, :guest] }
          it { is_expected.to eq false }
        end
      end
    end
  end

  describe '#moved?' do
    let(:issue) { create(:issue) }
    subject { issue.moved? }

    context 'issue not moved' do
      it { is_expected.to eq false }
    end

    context 'issue already moved' do
      let(:moved_to_issue) { create(:issue) }
      let(:issue) { create(:issue, moved_to: moved_to_issue) }

      it { is_expected.to eq true }
    end
  end

199
  describe '#related_branches' do
200
    let(:user) { build(:admin) }
201

202
    before do
203
      allow(subject.project.repository).to receive(:branch_names).
204
                                            and_return(["mpempe", "#{subject.iid}mepmep", subject.to_branch_name, "#{subject.iid}-branch"])
205 206 207 208 209 210 211 212

      # Without this stub, the `create(:merge_request)` above fails because it can't find
      # the source branch. This seems like a reasonable compromise, in comparison with
      # setting up a full repo here.
      allow_any_instance_of(MergeRequest).to receive(:create_merge_request_diff)
    end

    it "selects the right branches when there are no referenced merge requests" do
213
      expect(subject.related_branches(user)).to eq([subject.to_branch_name, "#{subject.iid}-branch"])
214
    end
215

216
    it "selects the right branches when there is a referenced merge request" do
217 218
      merge_request = create(:merge_request, { description: "Closes ##{subject.iid}",
                                               source_project: subject.project,
219
                                               source_branch: "#{subject.iid}-branch" })
220
      merge_request.create_cross_references!(user)
221
      expect(subject.referenced_merge_requests(user)).not_to be_empty
222
      expect(subject.related_branches(user)).to eq([subject.to_branch_name])
223
    end
224 225 226 227 228

    it 'excludes stable branches from the related branches' do
      allow(subject.project.repository).to receive(:branch_names).
        and_return(["#{subject.iid}-0-stable"])

229
      expect(subject.related_branches(user)).to eq []
230
    end
231 232
  end

233
  it_behaves_like 'an editable mentionable' do
Douwe Maan committed
234
    subject { create(:issue) }
235

236
    let(:backref_text) { "issue #{subject.to_reference}" }
237 238
    let(:set_mentionable_text) { ->(txt){ subject.description = txt } }
  end
Vinnie Okada committed
239 240 241 242

  it_behaves_like 'a Taskable' do
    let(:subject) { create :issue }
  end
243 244

  describe "#to_branch_name" do
245
    let(:issue) { create(:issue, title: 'testing-issue') }
246

247
    it 'starts with the issue iid' do
248
      expect(issue.to_branch_name).to match /\A#{issue.iid}-[A-Za-z\-]+\z/
249
    end
250 251

    it "contains the issue title if not confidential" do
252
      expect(issue.to_branch_name).to match /testing-issue\z/
253 254 255 256
    end

    it "does not contain the issue title if confidential" do
      issue = create(:issue, title: 'testing-issue', confidential: true)
257
      expect(issue.to_branch_name).to match /confidential-issue\z/
258
    end
259
  end
Yorick Peterse committed
260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297

  describe '#participants' do
    context 'using a public project' do
      let(:project) { create(:project, :public) }
      let(:issue) { create(:issue, project: project) }

      let!(:note1) do
        create(:note_on_issue, noteable: issue, project: project, note: 'a')
      end

      let!(:note2) do
        create(:note_on_issue, noteable: issue, project: project, note: 'b')
      end

      it 'includes the issue author' do
        expect(issue.participants).to include(issue.author)
      end

      it 'includes the authors of the notes' do
        expect(issue.participants).to include(note1.author, note2.author)
      end
    end

    context 'using a private project' do
      it 'does not include mentioned users that do not have access to the project' do
        project = create(:project)
        user = create(:user)
        issue = create(:issue, project: project)

        create(:note_on_issue,
               noteable: issue,
               project: project,
               note: user.to_reference)

        expect(issue.participants).not_to include(user)
      end
    end
  end
298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      issue = create(:issue, assignee: user1)

      expect(user1.assigned_open_issues_count).to eq(1)
      expect(user2.assigned_open_issues_count).to eq(0)

      issue.assignee = user2
      issue.save

      expect(user1.assigned_open_issues_count).to eq(0)
      expect(user2.assigned_open_issues_count).to eq(1)
    end
  end
315 316

  describe '#visible_to_user?' do
317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332
    context 'without a user' do
      let(:issue) { build(:issue) }

      it 'returns true when the issue is publicly visible' do
        expect(issue).to receive(:publicly_visible?).and_return(true)

        expect(issue.visible_to_user?).to eq(true)
      end

      it 'returns false when the issue is not publicly visible' do
        expect(issue).to receive(:publicly_visible?).and_return(false)

        expect(issue.visible_to_user?).to eq(false)
      end
    end

333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348
    context 'with a user' do
      let(:user) { build(:user) }
      let(:issue) { build(:issue) }

      it 'returns true when the issue is readable' do
        expect(issue).to receive(:readable_by?).with(user).and_return(true)

        expect(issue.visible_to_user?(user)).to eq(true)
      end

      it 'returns false when the issue is not readable' do
        expect(issue).to receive(:readable_by?).with(user).and_return(false)

        expect(issue.visible_to_user?(user)).to eq(false)
      end

349 350
      it 'returns false when feature is disabled' do
        expect(issue).not_to receive(:readable_by?)
351

352
        issue.project.project_feature.update_attribute(:issues_access_level, ProjectFeature::DISABLED)
353

354
        expect(issue.visible_to_user?(user)).to eq(false)
355 356
      end

357 358
      it 'returns false when restricted for members' do
        expect(issue).not_to receive(:readable_by?)
359

360 361 362
        issue.project.project_feature.update_attribute(:issues_access_level, ProjectFeature::PRIVATE)

        expect(issue.visible_to_user?(user)).to eq(false)
363 364 365 366 367 368 369 370 371 372 373 374
      end
    end

    describe 'with a regular user that is not a team member' do
      let(:user) { create(:user) }

      context 'using a public project' do
        let(:project) { create(:empty_project, :public) }

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

375
          expect(issue.visible_to_user?(user)).to eq(true)
376 377 378 379 380
        end

        it 'returns false for a confidential issue' do
          issue = build(:issue, project: project, confidential: true)

381
          expect(issue.visible_to_user?(user)).to eq(false)
382 383 384 385 386 387 388 389 390 391
        end
      end

      context 'using an internal project' do
        let(:project) { create(:empty_project, :internal) }

        context 'using an internal user' do
          it 'returns true for a regular issue' do
            issue = build(:issue, project: project)

392
            expect(issue.visible_to_user?(user)).to eq(true)
393 394 395 396 397
          end

          it 'returns false for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

398
            expect(issue.visible_to_user?(user)).to eq(false)
399 400 401 402 403 404 405 406 407 408 409
          end
        end

        context 'using an external user' do
          before do
            allow(user).to receive(:external?).and_return(true)
          end

          it 'returns false for a regular issue' do
            issue = build(:issue, project: project)

410
            expect(issue.visible_to_user?(user)).to eq(false)
411 412 413 414 415
          end

          it 'returns false for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

416
            expect(issue.visible_to_user?(user)).to eq(false)
417 418 419 420 421 422 423 424 425 426
          end
        end
      end

      context 'using a private project' do
        let(:project) { create(:empty_project, :private) }

        it 'returns false for a regular issue' do
          issue = build(:issue, project: project)

427
          expect(issue.visible_to_user?(user)).to eq(false)
428 429 430 431 432
        end

        it 'returns false for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

433
          expect(issue.visible_to_user?(user)).to eq(false)
434 435 436
        end

        context 'when the user is the project owner' do
437 438
          before { project.team << [user, :master] }

439 440 441
          it 'returns true for a regular issue' do
            issue = build(:issue, project: project)

442
            expect(issue.visible_to_user?(user)).to eq(true)
443 444 445 446 447
          end

          it 'returns true for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

448
            expect(issue.visible_to_user?(user)).to eq(true)
449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465
          end
        end
      end
    end

    context 'with a regular user that is a team member' do
      let(:user) { create(:user) }
      let(:project) { create(:empty_project, :public) }

      context 'using a public project' do
        before do
          project.team << [user, Gitlab::Access::DEVELOPER]
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

466
          expect(issue.visible_to_user?(user)).to eq(true)
467 468 469 470 471
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

472
          expect(issue.visible_to_user?(user)).to eq(true)
473 474 475 476 477 478 479 480 481 482 483 484 485
        end
      end

      context 'using an internal project' do
        let(:project) { create(:empty_project, :internal) }

        before do
          project.team << [user, Gitlab::Access::DEVELOPER]
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

486
          expect(issue.visible_to_user?(user)).to eq(true)
487 488 489 490 491
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

492
          expect(issue.visible_to_user?(user)).to eq(true)
493 494 495 496 497 498 499 500 501 502 503 504 505
        end
      end

      context 'using a private project' do
        let(:project) { create(:empty_project, :private) }

        before do
          project.team << [user, Gitlab::Access::DEVELOPER]
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

506
          expect(issue.visible_to_user?(user)).to eq(true)
507 508 509 510 511
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

512
          expect(issue.visible_to_user?(user)).to eq(true)
513 514 515 516 517 518
        end
      end
    end

    context 'with an admin user' do
      let(:project) { create(:empty_project) }
519
      let(:user) { create(:admin) }
520 521 522 523

      it 'returns true for a regular issue' do
        issue = build(:issue, project: project)

524
        expect(issue.visible_to_user?(user)).to eq(true)
525 526 527 528 529
      end

      it 'returns true for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

530
        expect(issue.visible_to_user?(user)).to eq(true)
531 532 533 534 535 536 537 538 539 540 541
      end
    end
  end

  describe '#publicly_visible?' do
    context 'using a public project' do
      let(:project) { create(:empty_project, :public) }

      it 'returns true for a regular issue' do
        issue = build(:issue, project: project)

542
        expect(issue).to be_truthy
543 544 545 546 547
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

548
        expect(issue).not_to be_falsy
549 550 551 552 553 554 555 556 557
      end
    end

    context 'using an internal project' do
      let(:project) { create(:empty_project, :internal) }

      it 'returns false for a regular issue' do
        issue = build(:issue, project: project)

558
        expect(issue).not_to be_falsy
559 560 561 562 563
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

564
        expect(issue).not_to be_falsy
565 566 567 568 569 570 571 572 573
      end
    end

    context 'using a private project' do
      let(:project) { create(:empty_project, :private) }

      it 'returns false for a regular issue' do
        issue = build(:issue, project: project)

574
        expect(issue).not_to be_falsy
575 576 577 578 579
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

580
        expect(issue).not_to be_falsy
581 582 583
      end
    end
  end
gitlabhq committed
584
end