BigW Consortium Gitlab

repository_spec.rb 55.5 KB
Newer Older
1 2
require 'spec_helper'

Douwe Maan committed
3
describe Repository, models: true do
4
  include RepoHelpers
5
  TestBlob = Struct.new(:name)
6

7
  let(:project) { create(:project, :repository) }
8
  let(:repository) { project.repository }
9
  let(:user) { create(:user) }
10

11 12 13 14
  let(:commit_options) do
    author = repository.user_to_committer(user)
    { message: 'Test message', committer: author, author: author }
  end
15

16
  let(:merge_commit) do
17
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
18 19 20 21 22 23

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
                                       commit_options)

24
    repository.commit(merge_commit_id)
25
  end
26

27 28
  let(:author_email) { 'user@example.org' }
  let(:author_name) { 'John Doe' }
29

30
  describe '#branch_names_contains' do
31 32
    subject { repository.branch_names_contains(sample_commit.id) }

33 34 35
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
36
  end
37

38
  describe '#tag_names_contains' do
39
    subject { repository.tag_names_contains(sample_commit.id) }
40

41 42
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
43 44
  end

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
  describe 'tags_sorted_by' do
    context 'name' do
      subject { repository.tags_sorted_by('name').map(&:name) }

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

63 64
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
65
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
66 67 68 69 70 71 72 73 74 75 76 77
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

78 79
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
80
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
81 82 83 84
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
          repository.rugged.tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', options)

          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0', annotated_tag_name]) }

        after do
          repository.rugged.tags.delete(annotated_tag_name)
        end
      end
109 110 111
    end
  end

112 113 114
  describe '#ref_name_for_sha' do
    context 'ref found' do
      it 'returns the ref' do
115 116
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["b8d95eb4969eefacb0a58f6a28f6803f8070e7b9 commit\trefs/environments/production/77\n", 0])
117 118 119 120 121 122 123

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
      end
    end

    context 'ref not found' do
      it 'returns nil' do
124 125
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["", 0])
126 127 128 129 130 131

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq nil
      end
    end
  end

132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

152
  describe '#last_commit_for_path' do
153
    subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
154

155
    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
156
  end
157

Hiroyuki Sato committed
158 159 160
  describe '#last_commit_id_for_path' do
    subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }

Hiroyuki Sato committed
161 162 163
    it "returns last commit id for a given path" do
      is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
    end
Hiroyuki Sato committed
164

Hiroyuki Sato committed
165
    it "caches last commit id for a given path" do
Hiroyuki Sato committed
166 167
      cache = repository.send(:cache)
      key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"
168

Hiroyuki Sato committed
169
      expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
Hiroyuki Sato committed
170
      is_expected.to eq('c1acaa5')
Hiroyuki Sato committed
171 172 173
    end
  end

174
  describe '#find_commits_by_message' do
175 176
    it 'returns commits with messages containing a given string' do
      commit_ids = repository.find_commits_by_message('submodule').map(&:id)
177

178 179 180 181 182 183 184 185 186 187 188
      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      expect(commit_ids).to include('6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9')
      expect(commit_ids).to include('cfe32cf61b73a0d5e9f13e774abde7ff789b1660')
      expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
    end

    it 'is case insensitive' do
      commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)

      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
    end
189 190
  end

191
  describe '#blob_at' do
192 193 194 195 196 197
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
  end
198

199
  describe '#merged_to_root_ref?' do
200
    context 'merged branch without ff' do
201
      subject { repository.merged_to_root_ref?('branch-merged') }
202 203 204

      it { is_expected.to be_truthy }
    end
205

206 207
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
208 209 210 211
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
212

213 214 215 216 217
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
218 219 220 221 222 223

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
224 225
  end

226
  describe '#can_be_merged?' do
227 228 229 230 231 232 233 234 235 236 237
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }

      it { is_expected.to be_truthy }
    end

    context 'non-mergeable branches' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }

      it { is_expected.to be_falsey }
    end
238 239 240 241 242 243 244 245 246 247 248 249

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
250 251
  end

252 253 254
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
255 256
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

Douwe Maan committed
281
  describe "#create_dir" do
282 283
    it "commits a change that creates a new directory" do
      expect do
284
        repository.create_dir(user, 'newdir',
285
          message: 'Create newdir', branch_name: 'master')
286 287 288 289 290 291
      end.to change { repository.commits('master').count }.by(1)

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

292 293 294 295 296
    context "when committing to another project" do
      let(:forked_project) { create(:project) }

      it "creates a fork and commit to the forked project" do
        expect do
297
          repository.create_dir(user, 'newdir',
298
            message: 'Create newdir', branch_name: 'patch',
Lin Jen-Shin committed
299
            start_branch_name: 'master', start_project: forked_project)
300 301 302 303 304 305 306 307 308 309
        end.to change { repository.commits('master').count }.by(0)

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

310 311 312
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
313
          repository.create_dir(user, 'newdir',
314 315 316
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
317 318 319 320 321 322 323 324 325 326
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

327 328
  describe "#create_file" do
    it 'commits new file successfully' do
329
      expect do
330 331 332
        repository.create_file(user, 'NEWCHANGELOG', 'Changelog!',
                               message: 'Create changelog',
                               branch_name: 'master')
333 334
      end.to change { repository.commits('master').count }.by(1)

335
      blob = repository.blob_at('master', 'NEWCHANGELOG')
336

337
      expect(blob.data).to eq('Changelog!')
338
    end
339

340
    it 'respects the autocrlf setting' do
341
      repository.create_file(user, 'hello.txt', "Hello,\r\nWorld",
342
                             message: 'Add hello world',
343
                             branch_name: 'master')
344 345 346 347 348 349

      blob = repository.blob_at('master', 'hello.txt')

      expect(blob.data).to eq("Hello,\nWorld")
    end

350 351 352
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
353
          repository.create_file(user, 'NEWREADME', 'README!',
354 355 356 357
                                 message: 'Add README',
                                 branch_name: 'master',
                                 author_email: author_email,
                                 author_name: author_name)
358 359 360 361 362 363 364 365
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
366 367
  end

368
  describe "#update_file" do
369 370 371 372 373 374 375 376 377 378 379 380
    it 'updates file successfully' do
      expect do
        repository.update_file(user, 'CHANGELOG', 'Changelog!',
                               message: 'Update changelog',
                               branch_name: 'master')
      end.to change { repository.commits('master').count }.by(1)

      blob = repository.blob_at('master', 'CHANGELOG')

      expect(blob.data).to eq('Changelog!')
    end

381
    it 'updates filename successfully' do
382 383
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
384
                                     branch_name: 'master',
385
                                     previous_path: 'LICENSE',
386 387
                                     message: 'Changes filename')
      end.to change { repository.commits('master').count }.by(1)
388 389 390 391 392 393

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
394 395 396 397

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
398 399 400 401 402 403
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
404 405 406 407 408 409 410 411 412 413
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

Douwe Maan committed
414
  describe "#delete_file" do
415 416
    it 'removes file successfully' do
      expect do
417
        repository.delete_file(user, 'README',
418
          message: 'Remove README', branch_name: 'master')
419 420 421 422 423 424 425 426
      end.to change { repository.commits('master').count }.by(1)

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
427
          repository.delete_file(user, 'README',
428 429
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe '#get_committer_and_author' do
    it 'returns the committer and author data' do
      options = repository.get_committer_and_author(user)
      expect(options[:committer][:email]).to eq(user.email)
      expect(options[:author][:email]).to eq(user.email)
    end

    context 'when the email/name are given' do
      it 'returns an object containing the email/name' do
        options = repository.get_committer_and_author(user, email: author_email, name: author_name)
        expect(options[:author][:email]).to eq(author_email)
        expect(options[:author][:name]).to eq(author_name)
      end
    end

    context 'when the email is given but the name is not' do
      it 'returns the committer as the author' do
        options = repository.get_committer_and_author(user, email: author_email)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end

    context 'when the name is given but the email is not' do
      it 'returns nil' do
        options = repository.get_committer_and_author(user, name: author_name)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end
470 471
  end

472 473
  describe "search_files_by_content" do
    let(:results) { repository.search_files_by_content('feature', 'master') }
474 475 476 477
    subject { results }

    it { is_expected.to be_an Array }

478
    it 'regex-escapes the query string' do
479
      results = repository.search_files_by_content("test\\", 'master')
480 481 482 483

      expect(results.first).not_to start_with('fatal:')
    end

484
    it 'properly handles an unmatched parenthesis' do
485
      results = repository.search_files_by_content("test(", 'master')
486 487 488 489

      expect(results.first).not_to start_with('fatal:')
    end

Valery Sizov committed
490
    it 'properly handles when query is not present' do
491
      results = repository.search_files_by_content('', 'master')
Valery Sizov committed
492 493 494 495 496 497

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository
498
      results = repository.search_files_by_content('test', 'master')
Valery Sizov committed
499 500 501 502

      expect(results).to match_array([])
    end

503 504 505 506
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
507
      it { expect(subject.lines[2]).to eq("master:CHANGELOG:190:  - Feature: Replace teams with group membership\n") }
508 509
    end
  end
510

511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532
  describe "search_files_by_name" do
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
  end

533 534 535 536 537 538 539 540 541 542
  describe '#create_ref' do
    it 'redirects the call to fetch_ref' do
      ref, ref_path = '1', '2'

      expect(repository).to receive(:fetch_ref).with(repository.path_to_repo, ref, ref_path)

      repository.create_ref(ref, ref_path)
    end
  end

543
  describe "#changelog", caching: true do
544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

      expect(repository.changelog.name).to eq('changelog')
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

      expect(repository.changelog.name).to eq('news')
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

      expect(repository.changelog.name).to eq('history')
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

      expect(repository.changelog.name).to eq('changes')
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

      expect(repository.changelog.name).to eq('CHANGELOG')
    end
  end

575
  describe "#license_blob", caching: true do
576
    before do
577
      repository.delete_file(
578
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
579 580
    end

581
    it 'handles when HEAD points to non-existent ref' do
582
      repository.create_file(
583
        user, 'LICENSE', 'Copyright!',
584
        message: 'Add LICENSE', branch_name: 'master')
585

586 587
      allow(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
588 589 590 591

      expect(repository.license_blob).to be_nil
    end

592
    it 'looks in the root_ref only' do
593
      repository.delete_file(user, 'LICENSE',
594
        message: 'Remove LICENSE', branch_name: 'markdown')
595
      repository.create_file(user, 'LICENSE',
596
        Licensee::License.new('mit').content,
597
        message: 'Add LICENSE', branch_name: 'markdown')
598 599 600 601

      expect(repository.license_blob).to be_nil
    end

602
    it 'detects license file with no recognizable open-source license content' do
603 604
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
605 606 607 608

      expect(repository.license_blob.name).to eq('LICENSE')
    end

609 610
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
611
        repository.create_file(user, filename,
612
          Licensee::License.new('mit').content,
613
          message: "Add #{filename}", branch_name: 'master')
614

615 616
        expect(repository.license_blob.name).to eq(filename)
      end
617 618 619
    end
  end

620
  describe '#license_key', caching: true do
621
    before do
622
      repository.delete_file(user, 'LICENSE',
623
        message: 'Remove LICENSE', branch_name: 'master')
624
    end
625

626
    it 'returns nil when no license is detected' do
627 628 629
      expect(repository.license_key).to be_nil
    end

630 631 632
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

633 634 635 636
      expect(repository.license_key).to be_nil
    end

    it 'detects license file with no recognizable open-source license content' do
637 638
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
639 640

      expect(repository.license_key).to be_nil
641
    end
642

643
    it 'returns the license key' do
644
      repository.create_file(user, 'LICENSE',
645
        Licensee::License.new('mit').content,
646
        message: 'Add LICENSE', branch_name: 'master')
647

648
      expect(repository.license_key).to eq('mit')
649
    end
650
  end
651

652
  describe "#gitlab_ci_yml", caching: true do
653 654 655 656 657 658 659 660 661 662 663 664 665
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

      expect(repository.gitlab_ci_yml.name).to eq('.gitlab-ci.yml')
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
666
      allow(repository).to receive(:file_on_head).and_raise(Rugged::ReferenceError)
667 668 669 670
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

671
  describe '#add_branch' do
672
    context 'when pre hooks were successful' do
673
      it 'runs without errors' do
674
        hook = double(trigger: [true, nil])
675
        expect(Gitlab::Git::Hook).to receive(:new).exactly(3).times.and_return(hook)
676 677 678 679

        expect { repository.add_branch(user, 'new_feature', 'master') }.not_to raise_error
      end

680
      it 'creates the branch' do
681
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
682 683 684 685 686

        branch = repository.add_branch(user, 'new_feature', 'master')

        expect(branch.name).to eq('new_feature')
      end
687 688 689 690 691 692

      it 'calls the after_create_branch hook' do
        expect(repository).to receive(:after_create_branch)

        repository.add_branch(user, 'new_feature', 'master')
      end
693 694 695
    end

    context 'when pre hooks failed' do
696
      it 'gets an error' do
697
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
698 699 700 701 702 703

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
      end

704
      it 'does not create the branch' do
705
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
706 707 708 709 710 711 712 713 714

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('new_feature')).to be_nil
      end
    end
  end

715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732
  describe '#find_branch' do
    it 'loads a branch with a fresh repo' do
      expect(Gitlab::Git::Repository).to receive(:new).twice.and_call_original

      2.times do
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end

    it 'loads a branch with a cached repo' do
      expect(Gitlab::Git::Repository).to receive(:new).once.and_call_original

      2.times do
        expect(repository.find_branch('feature', fresh_repo: false)).not_to be_nil
      end
    end
  end

733
  describe '#rm_branch' do
734 735 736
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
    let(:blank_sha) { '0000000000000000000000000000000000000000' }

737
    context 'when pre hooks were successful' do
738
      it 'runs without errors' do
739 740
        expect_any_instance_of(GitHooksService).to receive(:execute).
          with(user, project.repository.path_to_repo, old_rev, blank_sha, 'refs/heads/feature')
741 742 743 744

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error
      end

745
      it 'deletes the branch' do
746
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
747 748 749 750 751 752 753 754

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error

        expect(repository.find_branch('feature')).to be_nil
      end
    end

    context 'when pre hooks failed' do
755
      it 'gets an error' do
756
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
757 758

        expect do
759
          repository.rm_branch(user, 'feature')
760 761 762
        end.to raise_error(GitHooksService::PreReceiveError)
      end

763
      it 'does not delete the branch' do
764
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
765 766 767 768 769 770 771 772 773

        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end
  end

774
  describe '#update_branch_with_hooks' do
775
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
776
    let(:new_rev) { 'a74ae73c1ccde9b974a70e82b901588071dc142a' } # commit whose parent is old_rev
777

778
    context 'when pre hooks were successful' do
779
      before do
780 781
        service = GitHooksService.new
        expect(GitHooksService).to receive(:new).and_return(service)
782 783
        expect(service).to receive(:execute).
          with(
784 785 786
            user,
            repository.path_to_repo,
            old_rev,
787
            new_rev,
788 789
            'refs/heads/feature').
          and_yield(service).and_return(true)
790
      end
791

792
      it 'runs without errors' do
793
        expect do
794 795 796
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
797 798
        end.not_to raise_error
      end
799

800
      it 'ensures the autocrlf Git option is set to :input' do
801 802 803
        service = GitOperationService.new(user, repository)

        expect(service).to receive(:update_autocrlf_option)
804

805
        service.with_branch('feature') { new_rev }
806
      end
807 808 809

      context "when the branch wasn't empty" do
        it 'updates the head' do
810
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(old_rev)
811 812 813 814 815

          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end

816
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(new_rev)
817 818
        end
      end
819 820
    end

821
    context 'when the update adds more than one commit' do
822
      let(:old_rev) { '33f3729a45c02fc67d00adb1b8bca394b0e761d9' }
823

824
      it 'runs without errors' do
825 826 827 828 829 830
        # old_rev is an ancestor of new_rev
        expect(repository.rugged.merge_base(old_rev, new_rev)).to eq(old_rev)

        # old_rev is not a direct ancestor (parent) of new_rev
        expect(repository.rugged.lookup(new_rev).parent_ids).not_to include(old_rev)

831 832 833
        branch = 'feature-ff-target'
        repository.add_branch(user, branch, old_rev)

834 835 836 837 838
        expect do
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
        end.not_to raise_error
839 840 841 842
      end
    end

    context 'when the update would remove commits from the target branch' do
843 844
      let(:branch) { 'master' }
      let(:old_rev) { repository.find_branch(branch).dereferenced_target.sha }
845

846
      it 'raises an exception' do
847 848 849 850 851 852
        # The 'master' branch is NOT an ancestor of new_rev.
        expect(repository.rugged.merge_base(old_rev, new_rev)).not_to eq(old_rev)

        # Updating 'master' to new_rev would lose the commits on 'master' that
        # are not contained in new_rev. This should not be allowed.
        expect do
853 854 855
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
856
        end.to raise_error(Repository::CommitError)
857 858 859
      end
    end

860
    context 'when pre hooks failed' do
861
      it 'gets an error' do
862
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
863 864

        expect do
865 866 867
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
868 869 870
        end.to raise_error(GitHooksService::PreReceiveError)
      end
    end
871 872 873 874 875 876 877 878 879 880 881 882

    context 'when target branch is different from source branch' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires branch cache' do
        expect(repository).not_to receive(:expire_exists_cache)
        expect(repository).not_to receive(:expire_root_ref_cache)
        expect(repository).not_to receive(:expire_emptiness_caches)
        expect(repository).to     receive(:expire_branches_cache)

883 884
        GitOperationService.new(user, repository).
          with_branch('new-feature') do
885 886
            new_rev
          end
887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902
      end
    end

    context 'when repository is empty' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires creation and branch cache' do
        empty_repository = create(:empty_project, :empty_repo).repository

        expect(empty_repository).to receive(:expire_exists_cache)
        expect(empty_repository).to receive(:expire_root_ref_cache)
        expect(empty_repository).to receive(:expire_emptiness_caches)
        expect(empty_repository).to receive(:expire_branches_cache)

903
        empty_repository.create_file(user, 'CHANGELOG', 'Changelog!',
904
                                     message: 'Updates file content',
905
                                     branch_name: 'master')
906 907
      end
    end
908
  end
909

910 911 912 913 914 915
  describe '#exists?' do
    it 'returns true when a repository exists' do
      expect(repository.exists?).to eq(true)
    end

    it 'returns false when a repository does not exist' do
916
      allow(repository).to receive(:refs_directory_exists?).and_return(false)
917 918 919

      expect(repository.exists?).to eq(false)
    end
920 921 922 923 924 925

    it 'returns false when there is no namespace' do
      allow(repository).to receive(:path_with_namespace).and_return(nil)

      expect(repository.exists?).to eq(false)
    end
926 927
  end

928 929 930 931 932
  describe '#has_visible_content?' do
    subject { repository.has_visible_content? }

    describe 'when there are no branches' do
      before do
933
        allow(repository).to receive(:branch_count).and_return(0)
934 935 936 937 938 939
      end

      it { is_expected.to eq(false) }
    end

    describe 'when there are branches' do
940
      it 'returns true' do
941
        expect(repository).to receive(:branch_count).and_return(3)
942 943 944 945 946 947

        expect(subject).to eq(true)
      end
    end
  end

948 949 950 951 952 953 954
  describe '#update_autocrlf_option' do
    describe 'when autocrlf is not already set to :input' do
      before do
        repository.raw_repository.autocrlf = true
      end

      it 'sets autocrlf to :input' do
955
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
956 957 958 959 960 961 962 963 964 965 966

        expect(repository.raw_repository.autocrlf).to eq(:input)
      end
    end

    describe 'when autocrlf is already set to :input' do
      before do
        repository.raw_repository.autocrlf = :input
      end

      it 'does nothing' do
967 968
        expect(repository.raw_repository).not_to receive(:autocrlf=).
          with(:input)
969

970
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
971 972 973 974
      end
    end
  end

975 976 977 978 979 980 981 982 983 984 985 986
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
      expect(empty_repository.empty?).to eq(true)
    end

    it 'returns false for a non-empty repository' do
      expect(repository.empty?).to eq(false)
    end

    it 'caches the output' do
987 988 989
      expect(repository.raw_repository).to receive(:empty?).
        once.
        and_return(false)
990 991 992 993 994 995 996 997 998 999 1000 1001

      repository.empty?
      repository.empty?
    end
  end

  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
1002 1003 1004
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('master')
1005 1006 1007 1008 1009 1010 1011 1012 1013 1014

      repository.root_ref
      repository.root_ref
    end
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

1015 1016 1017
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('foo')
1018 1019 1020 1021 1022 1023 1024

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

1025
  describe '#expire_branch_cache' do
1026 1027 1028 1029 1030
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
1031
      expect(cache).to receive(:expire).
1032
        at_least(repository.branches.length * 2).
1033
        times
1034 1035 1036 1037 1038

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
1039
      expect(cache).to receive(:expire).
1040
        at_least(repository.branches.length * 2).
1041
        times
1042 1043 1044 1045 1046

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
1047
      expect(cache).to receive(:expire).twice
1048 1049 1050 1051

      repository.expire_branch_cache('foo')
    end
  end
1052

1053 1054 1055
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1056 1057 1058
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1059 1060 1061 1062
      expect(cache).to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1063 1064 1065 1066 1067 1068 1069 1070

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

      expect(cache).not_to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1071 1072
  end

1073
  describe 'skip_merges option' do
1074
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map{ |k| k.id } }
1075 1076 1077

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1078 1079

  describe '#merge' do
1080
    it 'merges the code and return the commit id' do
1081 1082
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
1083
    end
1084 1085 1086

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
1087 1088 1089 1090 1091

      merge_commit_id = repository.merge(user,
                                         merge_request.diff_head_sha,
                                         merge_request,
                                         commit_options)
1092 1093 1094

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
1095 1096
  end

1097 1098 1099
  describe '#revert' do
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
1100

1101
    context 'when there is a conflict' do
1102 1103
      it 'raises an error' do
        expect { repository.revert(user, new_image_commit, 'master') }.to raise_error(/Failed to/)
1104 1105 1106 1107
      end
    end

    context 'when commit was already reverted' do
1108
      it 'raises an error' do
1109 1110
        repository.revert(user, update_image_commit, 'master')

1111
        expect { repository.revert(user, update_image_commit, 'master') }.to raise_error(/Failed to/)
1112 1113 1114 1115
      end
    end

    context 'when commit can be reverted' do
1116
      it 'reverts the changes' do
1117 1118 1119 1120 1121
        expect(repository.revert(user, update_image_commit, 'master')).to be_truthy
      end
    end

    context 'reverting a merge commit' do
1122
      it 'reverts the changes' do
1123 1124 1125 1126 1127 1128
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master')
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1129 1130
    end
  end
1131

1132 1133 1134 1135 1136 1137
  describe '#cherry_pick' do
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }

    context 'when there is a conflict' do
1138 1139
      it 'raises an error' do
        expect { repository.cherry_pick(user, conflict_commit, 'master') }.to raise_error(/Failed to/)
1140 1141 1142 1143
      end
    end

    context 'when commit was already cherry-picked' do
1144
      it 'raises an error' do
1145 1146
        repository.cherry_pick(user, pickable_commit, 'master')

1147
        expect { repository.cherry_pick(user, pickable_commit, 'master') }.to raise_error(/Failed to/)
1148 1149 1150 1151
      end
    end

    context 'when commit can be cherry-picked' do
1152
      it 'cherry-picks the changes' do
1153 1154 1155 1156 1157
        expect(repository.cherry_pick(user, pickable_commit, 'master')).to be_truthy
      end
    end

    context 'cherry-picking a merge commit' do
1158
      it 'cherry-picks the changes' do
1159
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
1160

1161 1162
        repository.cherry_pick(user, pickable_merge, 'improve/awesome')
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
1163 1164 1165 1166
      end
    end
  end

1167 1168 1169 1170 1171 1172 1173
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1174
        expect(repository).not_to receive(:expire_cache)
1175 1176 1177 1178

        repository.before_delete
      end

1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1202 1203

      it 'flushes the exists cache' do
1204
        expect(repository).to receive(:expire_exists_cache).twice
1205 1206 1207

        repository.before_delete
      end
1208 1209 1210 1211 1212 1213 1214
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272
  describe '#after_change_head' do
    it 'flushes the readme cache' do
      expect(repository).to receive(:expire_method_caches).with([
        :readme,
        :changelog,
        :license,
        :contributing,
        :version,
        :gitignore,
        :koding,
        :gitlab_ci,
        :avatar
      ])

      repository.after_change_head
    end
  end

1273
  describe '#before_push_tag' do
1274
    it 'flushes the cache' do
1275 1276 1277
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1278

1279
      repository.before_push_tag
1280 1281 1282 1283
    end
  end

  describe '#after_import' do
1284 1285
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1286 1287
      expect(repository).to receive(:expire_tags_cache)
      expect(repository).to receive(:expire_branches_cache)
1288 1289 1290

      repository.after_import
    end
1291 1292 1293
  end

  describe '#after_push_commit' do
1294
    it 'expires statistics caches' do
1295 1296
      expect(repository).to receive(:expire_statistics_caches).
        and_call_original
1297

1298 1299 1300
      expect(repository).to receive(:expire_branch_cache).
        with('master').
        and_call_original
1301

1302
      repository.after_push_commit('master')
1303 1304 1305 1306
    end
  end

  describe '#after_create_branch' do
1307
    it 'expires the branch caches' do
1308
      expect(repository).to receive(:expire_branches_cache)
1309 1310 1311 1312 1313 1314

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1315
    it 'expires the branch caches' do
1316
      expect(repository).to receive(:expire_branches_cache)
1317 1318 1319 1320

      repository.after_remove_branch
    end
  end
1321

1322 1323 1324 1325 1326 1327
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1340 1341
  end

1342 1343 1344 1345 1346 1347 1348 1349 1350 1351
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

1352 1353
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1354 1355
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
1356 1357 1358 1359 1360 1361 1362

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
Douwe Maan committed
1363
      expect(repository.branch_count).to be_an(Integer)
1364 1365 1366 1367 1368
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
Douwe Maan committed
1369
      expect(repository.tag_count).to be_an(Integer)
1370 1371 1372
    end
  end

1373
  describe '#expire_branches_cache' do
1374
    it 'expires the cache' do
1375 1376 1377
      expect(repository).to receive(:expire_method_caches).
        with(%i(branch_names branch_count)).
        and_call_original
1378

1379
      repository.expire_branches_cache
1380 1381 1382
    end
  end

1383
  describe '#expire_tags_cache' do
1384
    it 'expires the cache' do
1385 1386 1387
      expect(repository).to receive(:expire_method_caches).
        with(%i(tag_names tag_count)).
        and_call_original
1388

1389
      repository.expire_tags_cache
1390 1391
    end
  end
1392

1393
  describe '#add_tag' do
1394 1395
    context 'with a valid target' do
      let(:user) { build_stubbed(:user) }
1396

1397
      it 'creates the tag using rugged' do
1398 1399
        expect(repository.rugged.tags).to receive(:create).
          with('8.5', repository.commit('master').id,
1400
            hash_including(message: 'foo',
1401 1402
                           tagger: hash_including(name: user.name, email: user.email))).
          and_call_original
1403

1404 1405 1406 1407 1408 1409 1410 1411
        repository.add_tag(user, '8.5', 'master', 'foo')
      end

      it 'returns a Gitlab::Git::Tag object' do
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        expect(tag).to be_a(Gitlab::Git::Tag)
      end
1412 1413 1414 1415 1416 1417 1418

      it 'passes commit SHA to pre-receive and update hooks,\
        and tag SHA to post-receive hook' do
        pre_receive_hook = Gitlab::Git::Hook.new('pre-receive', repository.path_to_repo)
        update_hook = Gitlab::Git::Hook.new('update', repository.path_to_repo)
        post_receive_hook = Gitlab::Git::Hook.new('post-receive', repository.path_to_repo)

1419 1420
        allow(Gitlab::Git::Hook).to receive(:new).
          and_return(pre_receive_hook, update_hook, post_receive_hook)
1421 1422 1423 1424 1425 1426 1427 1428 1429 1430

        allow(pre_receive_hook).to receive(:trigger).and_call_original
        allow(update_hook).to receive(:trigger).and_call_original
        allow(post_receive_hook).to receive(:trigger).and_call_original

        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        commit_sha = repository.commit('master').id
        tag_sha = tag.target

1431 1432 1433 1434 1435 1436
        expect(pre_receive_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(update_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(post_receive_hook).to have_received(:trigger).
          with(anything, anything, tag_sha, anything)
1437
      end
1438 1439 1440 1441 1442 1443
    end

    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
      end
1444 1445 1446
    end
  end

1447 1448 1449 1450 1451 1452 1453 1454 1455 1456
  describe '#rm_branch' do
    let(:user) { create(:user) }

    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)

      repository.rm_branch(user, 'feature')
    end
  end
1457 1458 1459 1460 1461

  describe '#rm_tag' do
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)

1462 1463 1464
      repository.rm_tag(create(:user), 'v1.1.0')

      expect(repository.find_tag('v1.1.0')).to be_nil
1465 1466
    end
  end
1467 1468

  describe '#avatar' do
1469
    it 'returns nil if repo does not exist' do
1470 1471
      expect(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
1472 1473 1474 1475

      expect(repository.avatar).to eq(nil)
    end

1476
    it 'returns the first avatar file found in the repository' do
1477 1478 1479
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        and_return(double(:tree, path: 'logo.png'))
1480 1481 1482 1483 1484

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1485 1486 1487 1488
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        once.
        and_return(double(:tree, path: 'logo.png'))
1489

1490
      2.times { expect(repository.avatar).to eq('logo.png') }
1491 1492
    end
  end
1493

1494 1495 1496 1497 1498 1499 1500 1501 1502 1503
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
  end

1504
  describe "#keep_around" do
1505 1506 1507 1508
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1509 1510 1511 1512 1513
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
      path = File.join(repository.path, ref)
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
1530
  end
1531

1532
  describe '#update_ref' do
1533
    it 'can create a ref' do
1534
      GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/foobar', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1535 1536 1537 1538 1539 1540

      expect(repository.find_branch('foobar')).not_to be_nil
    end

    it 'raises CommitError when the ref update fails' do
      expect do
1541
        GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/master', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1542 1543 1544
      end.to raise_error(Repository::CommitError)
    end
  end
1545 1546 1547

  describe '#contribution_guide', caching: true do
    it 'returns and caches the output' do
1548 1549 1550 1551
      expect(repository).to receive(:file_on_head).
        with(:contributing).
        and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md')).
        once
1552 1553

      2.times do
1554 1555
        expect(repository.contribution_guide).
          to be_an_instance_of(Gitlab::Git::Tree)
1556 1557 1558 1559
      end
    end
  end

1560
  describe '#gitignore', caching: true do
1561
    it 'returns and caches the output' do
1562 1563 1564 1565
      expect(repository).to receive(:file_on_head).
        with(:gitignore).
        and_return(Gitlab::Git::Tree.new(path: '.gitignore')).
        once
1566 1567

      2.times do
1568
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
1569 1570 1571 1572
      end
    end
  end

1573
  describe '#koding_yml', caching: true do
1574
    it 'returns and caches the output' do
1575 1576 1577 1578
      expect(repository).to receive(:file_on_head).
        with(:koding).
        and_return(Gitlab::Git::Tree.new(path: '.koding.yml')).
        once
1579 1580

      2.times do
1581
        expect(repository.koding_yml).to be_an_instance_of(Gitlab::Git::Tree)
1582 1583 1584 1585
      end
    end
  end

1586 1587 1588 1589
  describe '#readme', caching: true do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)
1590

1591 1592 1593
        expect(repository.readme).to be_nil
      end
    end
1594

1595 1596 1597
    context 'with an existing repository' do
      it 'returns the README' do
        expect(repository.readme).to be_an_instance_of(Gitlab::Git::Blob)
1598 1599 1600 1601
      end
    end
  end

1602 1603
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
1604 1605
      expect(repository).to receive(:expire_method_caches).
        with(%i(size commit_count))
1606

1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621
      repository.expire_statistics_caches
    end
  end

  describe '#expire_method_caches' do
    it 'expires the caches of the given methods' do
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:readme)
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:gitignore)

      repository.expire_method_caches(%i(readme gitignore))
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
1622 1623
      expect(repository).to receive(:expire_method_caches).
        with(Repository::CACHED_METHODS)
1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647

      repository.expire_all_method_caches
    end
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
1648 1649
        expect(repository.file_on_head(:readme)).
          to be_an_instance_of(Gitlab::Git::Tree)
1650 1651 1652 1653
      end
    end
  end

1654 1655 1656 1657 1658 1659
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
1660

1661 1662 1663 1664 1665
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
1666 1667 1668 1669
      end
    end
  end

1670 1671 1672 1673 1674
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
1675

1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
Douwe Maan committed
1719
        expect(repository.commit_count).to be_an(Integer)
1720 1721 1722 1723
      end
    end
  end

1724
  describe '#commit_count_for_ref' do
1725 1726
    let(:project) { create :empty_project }

1727 1728
    context 'with a non-existing repository' do
      it 'returns 0' do
1729 1730 1731 1732 1733 1734 1735 1736
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
      end
    end

    context 'with empty repository' do
      it 'returns 0' do
        project.create_repository
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
1737 1738 1739 1740 1741 1742 1743 1744 1745 1746
      end
    end

    context 'when searching for the root ref' do
      it 'returns the same count as #commit_count' do
        expect(repository.commit_count_for_ref(repository.root_ref)).to eq(repository.commit_count)
      end
    end
  end

1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763
  describe '#cache_method_output', caching: true do
    context 'with a non-existing repository' do
      let(:value) do
        repository.cache_method_output(:cats, fallback: 10) do
          raise Rugged::ReferenceError
        end
      end

      it 'returns a fallback value' do
        expect(value).to eq(10)
      end

      it 'does not cache the data' do
        value

        expect(repository.instance_variable_defined?(:@cats)).to eq(false)
        expect(repository.send(:cache).exist?(:cats)).to eq(false)
1764 1765
      end
    end
1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786

    context 'with an existing repository' do
      it 'caches the output' do
        object = double

        expect(object).to receive(:number).once.and_return(10)

        2.times do
          val = repository.cache_method_output(:cats) { object.number }

          expect(val).to eq(10)
        end

        expect(repository.send(:cache).exist?(:cats)).to eq(true)
        expect(repository.instance_variable_get(:@cats)).to eq(10)
      end
    end
  end

  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
1787 1788
      expect(repository).to receive(:expire_method_caches).
        with(%i(readme license_blob license_key))
1789 1790 1791 1792 1793 1794 1795

      expect(repository).to receive(:readme)
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)

      repository.refresh_method_caches(%i(readme license))
    end
1796
  end
Douwe Maan committed
1797 1798 1799

  describe '#gitlab_ci_yml_for' do
    before do
1800
      repository.create_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master')
Douwe Maan committed
1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
1818
      repository.create_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master')
Douwe Maan committed
1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845

  describe '#is_ancestor?' do
    context 'Gitaly is_ancestor feature enabled' do
      it 'asks Gitaly server if it\'s an ancestor' do
        commit = repository.commit
        allow(Gitlab::GitalyClient).to receive(:feature_enabled?).with(:is_ancestor).and_return(true)
        expect(Gitlab::GitalyClient::Commit).to receive(:is_ancestor).
          with(repository.raw_repository, commit.id, commit.id).and_return(true)

        expect(repository.is_ancestor?(commit.id, commit.id)).to be true
      end
    end
  end
1846
end