BigW Consortium Gitlab

issue_spec.rb 19 KB
Newer Older
gitlabhq committed
1 2
require 'spec_helper'

Douwe Maan committed
3
describe Issue, models: true do
gitlabhq committed
4
  describe "Associations" do
5
    it { is_expected.to belong_to(:milestone) }
gitlabhq committed
6 7
  end

8
  describe 'modules' do
9 10 11
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
12
    it { is_expected.to include_module(Issuable) }
13 14 15
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
16 17
  end

18
  subject { create(:issue) }
19

20 21 22 23 24
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

25
  describe '#to_reference' do
26 27 28 29
    let(:namespace) { build(:namespace, path: 'sample-namespace') }
    let(:project)   { build(:empty_project, name: 'sample-project', namespace: namespace) }
    let(:issue)     { build(:issue, iid: 1, project: project) }
    let(:group)     { create(:group, name: 'Group', path: 'sample-group') }
30

31 32 33 34
    context 'when nil argument' do
      it 'returns issue id' do
        expect(issue.to_reference).to eq "#1"
      end
35 36
    end

37
    context 'when full is true' do
38
      it 'returns complete path to the issue' do
39 40 41
        expect(issue.to_reference(full: true)).to          eq 'sample-namespace/sample-project#1'
        expect(issue.to_reference(project, full: true)).to eq 'sample-namespace/sample-project#1'
        expect(issue.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project#1'
42
      end
43 44
    end

45 46 47 48 49 50 51 52 53 54 55 56
    context 'when same project argument' do
      it 'returns issue id' do
        expect(issue.to_reference(project)).to eq("#1")
      end
    end

    context 'when cross namespace project argument' do
      let(:another_namespace_project) { create(:empty_project, name: 'another-project') }

      it 'returns complete path to the issue' do
        expect(issue.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project#1'
      end
57 58
    end

59
    it 'supports a cross-project reference' do
60
      another_project = build(:empty_project, name: 'another-project', namespace: project.namespace)
61
      expect(issue.to_reference(another_project)).to eq "sample-project#1"
62
    end
63

64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92
    context 'when same namespace / cross-project argument' do
      let(:another_project) { create(:empty_project, namespace: namespace) }

      it 'returns path to the issue with the project name' do
        expect(issue.to_reference(another_project)).to eq 'sample-project#1'
      end
    end

    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace') }
      let(:another_project)   { create(:empty_project, path: 'another-project', namespace: another_namespace) }

      it 'returns full path to the issue' do
        expect(issue.to_reference(another_project)).to eq 'sample-namespace/sample-project#1'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the issue with the project name' do
          expect(issue.to_reference(namespace)).to eq 'sample-project#1'
        end
      end

      context 'with different project path' do
        it 'returns full path to the issue' do
          expect(issue.to_reference(group)).to eq 'sample-namespace/sample-project#1'
        end
      end
93
    end
94 95
  end

96 97
  describe '#is_being_reassigned?' do
    it 'returns true if the issue assignee has changed' do
98
      subject.assignee = create(:user)
99
      expect(subject.is_being_reassigned?).to be_truthy
100 101
    end
    it 'returns false if the issue assignee has not changed' do
102
      expect(subject.is_being_reassigned?).to be_falsey
103 104
    end
  end
105 106

  describe '#is_being_reassigned?' do
Johannes Schleifenbaum committed
107
    it 'returns issues assigned to user' do
108 109
      user = create(:user)
      create_list(:issue, 2, assignee: user)
110

111
      expect(Issue.open_for(user).count).to eq 2
112 113
    end
  end
114

115
  describe '#closed_by_merge_requests' do
116 117 118
    let(:project) { create(:project, :repository) }
    let(:issue) { create(:issue, project: project)}
    let(:closed_issue) { build(:issue, :closed, project: project)}
119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141

    let(:mr) do
      opts = {
        title: 'Awesome merge_request',
        description: "Fixes #{issue.to_reference}",
        source_branch: 'feature',
        target_branch: 'master'
      }
      MergeRequests::CreateService.new(project, project.owner, opts).execute
    end

    let(:closed_mr) do
      opts = {
        title: 'Awesome merge_request 2',
        description: "Fixes #{issue.to_reference}",
        source_branch: 'feature',
        target_branch: 'master',
        state: 'closed'
      }
      MergeRequests::CreateService.new(project, project.owner, opts).execute
    end

    it 'returns the merge request to close this issue' do
142
      mr
143

144
      expect(issue.closed_by_merge_requests(mr.author)).to eq([mr])
145 146
    end

147 148 149
    it "returns an empty array when the merge request is closed already" do
      closed_mr

150
      expect(issue.closed_by_merge_requests(closed_mr.author)).to eq([])
151 152
    end

153
    it "returns an empty array when the current issue is closed already" do
154
      expect(closed_issue.closed_by_merge_requests(closed_issue.author)).to eq([])
155 156 157
    end
  end

158 159
  describe '#referenced_merge_requests' do
    it 'returns the referenced merge requests' do
160
      project = create(:empty_project, :public)
161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182

      mr1 = create(:merge_request,
                   source_project: project,
                   source_branch:  'master',
                   target_branch:  'feature')

      mr2 = create(:merge_request,
                   source_project: project,
                   source_branch:  'feature',
                   target_branch:  'master')

      issue = create(:issue, description: mr1.to_reference, project: project)

      create(:note_on_issue,
             noteable:   issue,
             note:       mr2.to_reference,
             project_id: project.id)

      expect(issue.referenced_merge_requests).to eq([mr1, mr2])
    end
  end

183 184 185 186 187 188 189 190 191 192
  describe '#can_move?' do
    let(:user) { create(:user) }
    let(:issue) { create(:issue) }
    subject { issue.can_move?(user) }

    context 'user is not a member of project issue belongs to' do
      it { is_expected.to eq false}
    end

    context 'user is reporter in project issue belongs to' do
193
      let(:project) { create(:empty_project) }
194 195 196 197 198 199
      let(:issue) { create(:issue, project: project) }

      before { project.team << [user, :reporter] }

      it { is_expected.to eq true }

200 201 202 203 204
      context 'issue not persisted' do
        let(:issue) { build(:issue, project: project) }
        it { is_expected.to eq false }
      end

205 206
      context 'checking destination project also' do
        subject { issue.can_move?(user, to_project) }
207
        let(:to_project) { create(:empty_project) }
208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237

        context 'destination project allowed' do
          before { to_project.team << [user, :reporter] }
          it { is_expected.to eq true }
        end

        context 'destination project not allowed' do
          before { to_project.team << [user, :guest] }
          it { is_expected.to eq false }
        end
      end
    end
  end

  describe '#moved?' do
    let(:issue) { create(:issue) }
    subject { issue.moved? }

    context 'issue not moved' do
      it { is_expected.to eq false }
    end

    context 'issue already moved' do
      let(:moved_to_issue) { create(:issue) }
      let(:issue) { create(:issue, moved_to: moved_to_issue) }

      it { is_expected.to eq true }
    end
  end

238
  describe '#related_branches' do
239
    let(:user) { build(:admin) }
240

241
    before do
242
      allow(subject.project.repository).to receive(:branch_names).
243
                                            and_return(["mpempe", "#{subject.iid}mepmep", subject.to_branch_name, "#{subject.iid}-branch"])
244 245 246 247 248 249 250 251

      # Without this stub, the `create(:merge_request)` above fails because it can't find
      # the source branch. This seems like a reasonable compromise, in comparison with
      # setting up a full repo here.
      allow_any_instance_of(MergeRequest).to receive(:create_merge_request_diff)
    end

    it "selects the right branches when there are no referenced merge requests" do
252
      expect(subject.related_branches(user)).to eq([subject.to_branch_name, "#{subject.iid}-branch"])
253
    end
254

255
    it "selects the right branches when there is a referenced merge request" do
256 257
      merge_request = create(:merge_request, { description: "Closes ##{subject.iid}",
                                               source_project: subject.project,
258
                                               source_branch: "#{subject.iid}-branch" })
259
      merge_request.create_cross_references!(user)
260
      expect(subject.referenced_merge_requests(user)).not_to be_empty
261
      expect(subject.related_branches(user)).to eq([subject.to_branch_name])
262
    end
263 264 265 266 267

    it 'excludes stable branches from the related branches' do
      allow(subject.project.repository).to receive(:branch_names).
        and_return(["#{subject.iid}-0-stable"])

268
      expect(subject.related_branches(user)).to eq []
269
    end
270 271
  end

272
  it_behaves_like 'an editable mentionable' do
273
    subject { create(:issue, project: create(:project, :repository)) }
274

275
    let(:backref_text) { "issue #{subject.to_reference}" }
276 277
    let(:set_mentionable_text) { ->(txt){ subject.description = txt } }
  end
Vinnie Okada committed
278 279 280 281

  it_behaves_like 'a Taskable' do
    let(:subject) { create :issue }
  end
282 283

  describe "#to_branch_name" do
284
    let(:issue) { create(:issue, title: 'testing-issue') }
285

286
    it 'starts with the issue iid' do
287
      expect(issue.to_branch_name).to match /\A#{issue.iid}-[A-Za-z\-]+\z/
288
    end
289 290

    it "contains the issue title if not confidential" do
291
      expect(issue.to_branch_name).to match /testing-issue\z/
292 293 294 295
    end

    it "does not contain the issue title if confidential" do
      issue = create(:issue, title: 'testing-issue', confidential: true)
296
      expect(issue.to_branch_name).to match /confidential-issue\z/
297
    end
298
  end
Yorick Peterse committed
299 300 301

  describe '#participants' do
    context 'using a public project' do
302
      let(:project) { create(:empty_project, :public) }
Yorick Peterse committed
303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323
      let(:issue) { create(:issue, project: project) }

      let!(:note1) do
        create(:note_on_issue, noteable: issue, project: project, note: 'a')
      end

      let!(:note2) do
        create(:note_on_issue, noteable: issue, project: project, note: 'b')
      end

      it 'includes the issue author' do
        expect(issue.participants).to include(issue.author)
      end

      it 'includes the authors of the notes' do
        expect(issue.participants).to include(note1.author, note2.author)
      end
    end

    context 'using a private project' do
      it 'does not include mentioned users that do not have access to the project' do
324
        project = create(:empty_project)
Yorick Peterse committed
325 326 327 328 329 330 331 332 333 334 335 336
        user = create(:user)
        issue = create(:issue, project: project)

        create(:note_on_issue,
               noteable: issue,
               project: project,
               note: user.to_reference)

        expect(issue.participants).not_to include(user)
      end
    end
  end
337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      issue = create(:issue, assignee: user1)

      expect(user1.assigned_open_issues_count).to eq(1)
      expect(user2.assigned_open_issues_count).to eq(0)

      issue.assignee = user2
      issue.save

      expect(user1.assigned_open_issues_count).to eq(0)
      expect(user2.assigned_open_issues_count).to eq(1)
    end
  end
354 355

  describe '#visible_to_user?' do
356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371
    context 'without a user' do
      let(:issue) { build(:issue) }

      it 'returns true when the issue is publicly visible' do
        expect(issue).to receive(:publicly_visible?).and_return(true)

        expect(issue.visible_to_user?).to eq(true)
      end

      it 'returns false when the issue is not publicly visible' do
        expect(issue).to receive(:publicly_visible?).and_return(false)

        expect(issue.visible_to_user?).to eq(false)
      end
    end

372
    context 'with a user' do
373
      let(:user) { create(:user) }
374 375 376 377 378 379 380 381 382 383 384 385 386 387
      let(:issue) { build(:issue) }

      it 'returns true when the issue is readable' do
        expect(issue).to receive(:readable_by?).with(user).and_return(true)

        expect(issue.visible_to_user?(user)).to eq(true)
      end

      it 'returns false when the issue is not readable' do
        expect(issue).to receive(:readable_by?).with(user).and_return(false)

        expect(issue.visible_to_user?(user)).to eq(false)
      end

388 389
      it 'returns false when feature is disabled' do
        expect(issue).not_to receive(:readable_by?)
390

391
        issue.project.project_feature.update_attribute(:issues_access_level, ProjectFeature::DISABLED)
392

393
        expect(issue.visible_to_user?(user)).to eq(false)
394 395
      end

396 397
      it 'returns false when restricted for members' do
        expect(issue).not_to receive(:readable_by?)
398

399 400 401
        issue.project.project_feature.update_attribute(:issues_access_level, ProjectFeature::PRIVATE)

        expect(issue.visible_to_user?(user)).to eq(false)
402 403 404 405 406 407 408 409 410 411 412 413
      end
    end

    describe 'with a regular user that is not a team member' do
      let(:user) { create(:user) }

      context 'using a public project' do
        let(:project) { create(:empty_project, :public) }

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

414
          expect(issue.visible_to_user?(user)).to eq(true)
415 416 417 418 419
        end

        it 'returns false for a confidential issue' do
          issue = build(:issue, project: project, confidential: true)

420
          expect(issue.visible_to_user?(user)).to eq(false)
421 422 423 424 425 426 427 428 429 430
        end
      end

      context 'using an internal project' do
        let(:project) { create(:empty_project, :internal) }

        context 'using an internal user' do
          it 'returns true for a regular issue' do
            issue = build(:issue, project: project)

431
            expect(issue.visible_to_user?(user)).to eq(true)
432 433 434 435 436
          end

          it 'returns false for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

437
            expect(issue.visible_to_user?(user)).to eq(false)
438 439 440 441 442 443 444 445 446 447 448
          end
        end

        context 'using an external user' do
          before do
            allow(user).to receive(:external?).and_return(true)
          end

          it 'returns false for a regular issue' do
            issue = build(:issue, project: project)

449
            expect(issue.visible_to_user?(user)).to eq(false)
450 451 452 453 454
          end

          it 'returns false for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

455
            expect(issue.visible_to_user?(user)).to eq(false)
456 457 458 459 460 461 462 463 464 465
          end
        end
      end

      context 'using a private project' do
        let(:project) { create(:empty_project, :private) }

        it 'returns false for a regular issue' do
          issue = build(:issue, project: project)

466
          expect(issue.visible_to_user?(user)).to eq(false)
467 468 469 470 471
        end

        it 'returns false for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

472
          expect(issue.visible_to_user?(user)).to eq(false)
473 474 475
        end

        context 'when the user is the project owner' do
476 477
          before { project.team << [user, :master] }

478 479 480
          it 'returns true for a regular issue' do
            issue = build(:issue, project: project)

481
            expect(issue.visible_to_user?(user)).to eq(true)
482 483 484 485 486
          end

          it 'returns true for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

487
            expect(issue.visible_to_user?(user)).to eq(true)
488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504
          end
        end
      end
    end

    context 'with a regular user that is a team member' do
      let(:user) { create(:user) }
      let(:project) { create(:empty_project, :public) }

      context 'using a public project' do
        before do
          project.team << [user, Gitlab::Access::DEVELOPER]
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

505
          expect(issue.visible_to_user?(user)).to eq(true)
506 507 508 509 510
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

511
          expect(issue.visible_to_user?(user)).to eq(true)
512 513 514 515 516 517 518 519 520 521 522 523 524
        end
      end

      context 'using an internal project' do
        let(:project) { create(:empty_project, :internal) }

        before do
          project.team << [user, Gitlab::Access::DEVELOPER]
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

525
          expect(issue.visible_to_user?(user)).to eq(true)
526 527 528 529 530
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

531
          expect(issue.visible_to_user?(user)).to eq(true)
532 533 534 535 536 537 538 539 540 541 542 543 544
        end
      end

      context 'using a private project' do
        let(:project) { create(:empty_project, :private) }

        before do
          project.team << [user, Gitlab::Access::DEVELOPER]
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

545
          expect(issue.visible_to_user?(user)).to eq(true)
546 547 548 549 550
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

551
          expect(issue.visible_to_user?(user)).to eq(true)
552 553 554 555 556 557
        end
      end
    end

    context 'with an admin user' do
      let(:project) { create(:empty_project) }
558
      let(:user) { create(:admin) }
559 560 561 562

      it 'returns true for a regular issue' do
        issue = build(:issue, project: project)

563
        expect(issue.visible_to_user?(user)).to eq(true)
564 565 566 567 568
      end

      it 'returns true for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

569
        expect(issue.visible_to_user?(user)).to eq(true)
570 571 572 573 574 575 576 577 578 579 580
      end
    end
  end

  describe '#publicly_visible?' do
    context 'using a public project' do
      let(:project) { create(:empty_project, :public) }

      it 'returns true for a regular issue' do
        issue = build(:issue, project: project)

581
        expect(issue).to be_truthy
582 583 584 585 586
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

587
        expect(issue).not_to be_falsy
588 589 590 591 592 593 594 595 596
      end
    end

    context 'using an internal project' do
      let(:project) { create(:empty_project, :internal) }

      it 'returns false for a regular issue' do
        issue = build(:issue, project: project)

597
        expect(issue).not_to be_falsy
598 599 600 601 602
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

603
        expect(issue).not_to be_falsy
604 605 606 607 608 609 610 611 612
      end
    end

    context 'using a private project' do
      let(:project) { create(:empty_project, :private) }

      it 'returns false for a regular issue' do
        issue = build(:issue, project: project)

613
        expect(issue).not_to be_falsy
614 615 616 617 618
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

619
        expect(issue).not_to be_falsy
620 621 622
      end
    end
  end
gitlabhq committed
623
end