BigW Consortium Gitlab
Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867⚠ - Potentially untested💣 - No test coverage🚥 - Test coverage of some sort exists (a test failed when error raised)🚦 - Test coverage of return value (a test failed when nil used)✅ - Permissions check tested - [x]💣 app/finders/notes_finder.rb:17 - [x]⚠ app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x]💣 app/controllers/concerns/creates_commit.rb:84 - [x]🚥 app/controllers/projects/commits_controller.rb:24 - [x]🚥 app/controllers/projects/compare_controller.rb:56 - [x]🚦 app/controllers/projects/discussions_controller.rb:29 - [x]✅ app/controllers/projects/todos_controller.rb:27 - [x]🚦 app/models/commit.rb:268 - [x]✅ lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
auth | Loading commit data... | |
backend | Loading commit data... | |
badge | Loading commit data... | |
bitbucket_import | Loading commit data... | |
chat_commands | Loading commit data... | |
checks | Loading commit data... | |
ci | Loading commit data... | |
conflict | Loading commit data... | |
cycle_analytics | Loading commit data... | |
data_builder | Loading commit data... | |
database | Loading commit data... | |
diff | Loading commit data... | |
downtime_check | Loading commit data... | |
Loading commit data... | ||
fogbugz_import | Loading commit data... | |
gfm | Loading commit data... | |
git | Loading commit data... | |
github_import | Loading commit data... | |
gitlab_import | Loading commit data... | |
google_code_import | Loading commit data... | |
graphs | Loading commit data... | |
import_export | Loading commit data... | |
ldap | Loading commit data... | |
markdown | Loading commit data... | |
metrics | Loading commit data... | |
middleware | Loading commit data... | |
o_auth | Loading commit data... | |
request_profiler | Loading commit data... | |
saml | Loading commit data... | |
sanitizers | Loading commit data... | |
sherlock | Loading commit data... | |
sidekiq_middleware | Loading commit data... | |
slash_commands | Loading commit data... | |
sql | Loading commit data... | |
template | Loading commit data... | |
access.rb | Loading commit data... | |
app_logger.rb | Loading commit data... | |
asciidoc.rb | Loading commit data... | |
auth.rb | Loading commit data... | |
award_emoji.rb | Loading commit data... | |
bitbucket_import.rb | Loading commit data... | |
blame.rb | Loading commit data... | |
changes_list.rb | Loading commit data... | |
chat_name_token.rb | Loading commit data... | |
closing_issue_extractor.rb | Loading commit data... | |
color_schemes.rb | Loading commit data... | |
config_helper.rb | Loading commit data... | |
contributions_calendar.rb | Loading commit data... | |
contributor.rb | Loading commit data... | |
current_settings.rb | Loading commit data... | |
database.rb | Loading commit data... | |
devise_failure.rb | Loading commit data... | |
downtime_check.rb | Loading commit data... | |
ee_compat_check.rb | Loading commit data... | |
emoji.rb | Loading commit data... | |
environment_logger.rb | Loading commit data... | |
exclusive_lease.rb | Loading commit data... | |
file_detector.rb | Loading commit data... | |
git.rb | Loading commit data... | |
git_access.rb | Loading commit data... | |
git_access_status.rb | Loading commit data... | |
git_access_wiki.rb | Loading commit data... | |
git_logger.rb | Loading commit data... | |
git_post_receive.rb | Loading commit data... | |
git_ref_validator.rb | Loading commit data... | |
gl_id.rb | Loading commit data... | |
gon_helper.rb | Loading commit data... | |
highlight.rb | Loading commit data... | |
identifier.rb | Loading commit data... | |
import_export.rb | Loading commit data... | |
import_formatter.rb | Loading commit data... | |
import_sources.rb | Loading commit data... | |
incoming_email.rb | Loading commit data... | |
issues_labels.rb | Loading commit data... | |
key_fingerprint.rb | Loading commit data... | |
lazy.rb | Loading commit data... | |
lfs_token.rb | Loading commit data... | |
logger.rb | Loading commit data... | |
mail_room.rb | Loading commit data... | |
markup_helper.rb | Loading commit data... | |
metrics.rb | Loading commit data... | |
optimistic_locking.rb | Loading commit data... | |
other_markup.rb | Loading commit data... | |
popen.rb | Loading commit data... | |
project_search_results.rb | Loading commit data... | |
protocol_access.rb | Loading commit data... | |
recaptcha.rb | Loading commit data... | |
redis.rb | Loading commit data... | |
reference_extractor.rb | Loading commit data... | |
regex.rb | Loading commit data... | |
repository_check_logger.rb | Loading commit data... | |
request_profiler.rb | Loading commit data... | |
routing.rb | Loading commit data... | |
search_results.rb | Loading commit data... | |
seeder.rb | Loading commit data... | |
sentry.rb | Loading commit data... | |
sherlock.rb | Loading commit data... | |
sidekiq_logger.rb | Loading commit data... | |
sidekiq_throttler.rb | Loading commit data... | |
snippet_search_results.rb | Loading commit data... | |
themes.rb | Loading commit data... | |
timeless.rb | Loading commit data... | |
upgrader.rb | Loading commit data... | |
uploads_transfer.rb | Loading commit data... | |
url_builder.rb | Loading commit data... | |
url_sanitizer.rb | Loading commit data... | |
user_access.rb | Loading commit data... | |
utils.rb | Loading commit data... | |
version_info.rb | Loading commit data... | |
visibility_level.rb | Loading commit data... | |
workhorse.rb | Loading commit data... |