BigW Consortium Gitlab
Resolve "Destroying a project causes post_decline_request to be executed" ## What does this MR do? Ensure we don't send "access request declined" to access requesters when a project is deleted. ## Are there points in the code the reviewer needs to double check? I've created a service to decouple the notification sending from the AR model. ## Why was this MR needed? Because there was an issue. ## What are the relevant issue numbers? Fixes #18755, #18750. ## Does this MR meet the acceptance criteria? - [x] No CHANGELOG needed. - [x] Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4744
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
application_controller.rb | Loading commit data... | |
artifacts_controller.rb | Loading commit data... | |
avatars_controller.rb | Loading commit data... | |
badges_controller.rb | Loading commit data... | |
blame_controller.rb | Loading commit data... | |
blob_controller.rb | Loading commit data... | |
branches_controller.rb | Loading commit data... | |
builds_controller.rb | Loading commit data... | |
commit_controller.rb | Loading commit data... | |
commits_controller.rb | Loading commit data... | |
compare_controller.rb | Loading commit data... | |
container_registry_controller.rb | Loading commit data... | |
deploy_keys_controller.rb | Loading commit data... | |
environments_controller.rb | Loading commit data... | |
find_file_controller.rb | Loading commit data... | |
forks_controller.rb | Loading commit data... | |
git_http_controller.rb | Loading commit data... | |
graphs_controller.rb | Loading commit data... | |
group_links_controller.rb | Loading commit data... | |
hooks_controller.rb | Loading commit data... | |
imports_controller.rb | Loading commit data... | |
issues_controller.rb | Loading commit data... | |
labels_controller.rb | Loading commit data... | |
merge_requests_controller.rb | Loading commit data... | |
milestones_controller.rb | Loading commit data... | |
network_controller.rb | Loading commit data... | |
notes_controller.rb | Loading commit data... | |
pipelines_controller.rb | Loading commit data... | |
project_members_controller.rb | Loading commit data... | |
protected_branches_controller.rb | Loading commit data... | |
raw_controller.rb | Loading commit data... | |
refs_controller.rb | Loading commit data... | |
releases_controller.rb | Loading commit data... | |
repositories_controller.rb | Loading commit data... | |
runner_projects_controller.rb | Loading commit data... | |
runners_controller.rb | Loading commit data... | |
services_controller.rb | Loading commit data... | |
snippets_controller.rb | Loading commit data... | |
tags_controller.rb | Loading commit data... | |
todos_controller.rb | Loading commit data... | |
tree_controller.rb | Loading commit data... | |
triggers_controller.rb | Loading commit data... | |
uploads_controller.rb | Loading commit data... | |
variables_controller.rb | Loading commit data... | |
wikis_controller.rb | Loading commit data... |