BigW Consortium Gitlab
Make Rack::Request use our trusted proxies when filtering IP addresses ## What does this MR do? This allows us to control the trusted proxies while deployed in a private network. ## Are there points in the code the reviewer needs to double check? If we want to limit what is impacted, we can do this specifically for the rack_attack request object. ## Why was this MR needed? Normally Rack::Request will trust all private IPs as trusted proxies, which can cause problems if your users are connection on you network via private IP ranges. Normally in a rails app this is handled by action_dispatch request, but rack_attack is specifically using the Rack::Request object instead. ## What are the relevant issue numbers? Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17550 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [ ] ~~API support added~~ - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) \cc @stanhu See merge request !4958
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
1_settings.rb | Loading commit data... | |
2_app.rb | Loading commit data... | |
4_ci_app.rb | Loading commit data... | |
5_backend.rb | Loading commit data... | |
6_validations.rb | Loading commit data... | |
active_record_query_trace.rb | Loading commit data... | |
attr_encrypted_no_db_connection.rb | Loading commit data... | |
backtrace_silencers.rb | Loading commit data... | |
bullet.rb | Loading commit data... | |
carrierwave.rb | Loading commit data... | |
chronic_duration.rb | Loading commit data... | |
connection_fix.rb | Loading commit data... | |
cookies_serializer.rb | Loading commit data... | |
date_time_formats.rb | Loading commit data... | |
default_url_options.rb | Loading commit data... | |
devise.rb | Loading commit data... | |
devise_password_length.rb.example | Loading commit data... | |
disable_email_interceptor.rb | Loading commit data... | |
doorkeeper.rb | Loading commit data... | |
gitlab_shell_secret_token.rb | Loading commit data... | |
go_get.rb | Loading commit data... | |
gollum.rb | Loading commit data... | |
hamlit.rb | Loading commit data... | |
health_check.rb | Loading commit data... | |
inflections.rb | Loading commit data... | |
kaminari_config.rb | Loading commit data... | |
metrics.rb | Loading commit data... | |
mime_types.rb | Loading commit data... | |
mysql_ignore_postgresql_options.rb | Loading commit data... | |
omniauth.rb | Loading commit data... | |
postgresql_limit_fix.rb | Loading commit data... | |
postgresql_opclasses_support.rb | Loading commit data... | |
premailer.rb | Loading commit data... | |
public_key.rb | Loading commit data... | |
rack_attack.rb.example | Loading commit data... | |
rack_attack_git_basic_auth.rb | Loading commit data... | |
rack_lineprof.rb | Loading commit data... | |
relative_url.rb.sample | Loading commit data... | |
secret_token.rb | Loading commit data... | |
sentry.rb | Loading commit data... | |
session_store.rb | Loading commit data... | |
sherlock.rb | Loading commit data... | |
sidekiq.rb | Loading commit data... | |
smtp_settings.rb.sample | Loading commit data... | |
static_files.rb | Loading commit data... | |
time_zone.rb | Loading commit data... | |
trusted_proxies.rb | Loading commit data... | |
wrap_parameters.rb | Loading commit data... |