BigW Consortium Gitlab
Issue #13823: random message when all Todos are Done ## What does this MR do? Shows a random message every time the To Do list is empty: https://gitlab.com/gitlab-org/gitlab-ce/issues/13823 ## Are there points in the code the reviewer needs to double check? It's my first contribution to GitLab so I might need some help: - I'm loading a yaml file in the controller. I'm not sure where would be the best place to put it. - I'm also having the error below running the tests but it doesn't seem related to my changes. I think I might have some issue with my config. Could you double check if the tests pass for you? /home/pep/.rvm/gems/ruby-2.3.1/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call': No route matches [GET] "/autocomplete/users/sjobs@apple.com.json" (ActionController::RoutingError) ## Why was this MR needed? https://gitlab.com/gitlab-org/gitlab-ce/issues/13823 ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/13823 See merge request !6818
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
0_post_deployment_migrations.rb | Loading commit data... | |
1_settings.rb | Loading commit data... | |
2_app.rb | Loading commit data... | |
4_ci_app.rb | Loading commit data... | |
5_backend.rb | Loading commit data... | |
6_validations.rb | Loading commit data... | |
7_redis.rb | Loading commit data... | |
active_record_query_trace.rb | Loading commit data... | |
ar5_batching.rb | Loading commit data... | |
ar_monkey_patch.rb | Loading commit data... | |
ar_speed_up_migration_checking.rb | Loading commit data... | |
attr_encrypted_no_db_connection.rb | Loading commit data... | |
backtrace_silencers.rb | Loading commit data... | |
bullet.rb | Loading commit data... | |
carrierwave.rb | Loading commit data... | |
chronic_duration.rb | Loading commit data... | |
connection_fix.rb | Loading commit data... | |
cookies_serializer.rb | Loading commit data... | |
date_time_formats.rb | Loading commit data... | |
default_url_options.rb | Loading commit data... | |
devise.rb | Loading commit data... | |
devise_password_length.rb.example | Loading commit data... | |
disable_email_interceptor.rb | Loading commit data... | |
doorkeeper.rb | Loading commit data... | |
gitlab_shell_secret_token.rb | Loading commit data... | |
gitlab_workhorse_secret.rb | Loading commit data... | |
go_get.rb | Loading commit data... | |
gollum.rb | Loading commit data... | |
hamlit.rb | Loading commit data... | |
health_check.rb | Loading commit data... | |
inflections.rb | Loading commit data... | |
kaminari_config.rb | Loading commit data... | |
metrics.rb | Loading commit data... | |
mime_types.rb | Loading commit data... | |
mysql_ignore_postgresql_options.rb | Loading commit data... | |
omniauth.rb | Loading commit data... | |
postgresql_limit_fix.rb | Loading commit data... | |
postgresql_opclasses_support.rb | Loading commit data... | |
premailer.rb | Loading commit data... | |
public_key.rb | Loading commit data... | |
rack_attack.rb.example | Loading commit data... | |
rack_attack_git_basic_auth.rb | Loading commit data... | |
rack_lineprof.rb | Loading commit data... | |
relative_naming_ci_namespace.rb | Loading commit data... | |
relative_url.rb.sample | Loading commit data... | |
request_profiler.rb | Loading commit data... | |
routing_draw.rb | Loading commit data... | |
secret_token.rb | Loading commit data... | |
sentry.rb | Loading commit data... | |
session_store.rb | Loading commit data... | |
sherlock.rb | Loading commit data... | |
sidekiq.rb | Loading commit data... | |
smtp_settings.rb.sample | Loading commit data... | |
static_files.rb | Loading commit data... | |
time_zone.rb | Loading commit data... | |
trusted_proxies.rb | Loading commit data... | |
wrap_parameters.rb | Loading commit data... |