changelogs/unreleased · b11492c2e36803cf19b175e7d850a72f4e5f9b1f · Forest Godfrey / gitlab-ce

Use cached values to compute total issues count in milestone index pages · b11492c2

authored Jan 10, 2017

Milestoneish#issues_visible_to_user caches only the ActiveRecord relation,
not the actual result.
Introduce Milestoneish#total_issues_count that relies on the cached method
Milestoneish#count_issues_by_state to reduce the number of queries.

b11492c2

Name	Last commit	Last update
..
.gitkeep		Loading commit data...
18786-go-to-a-project-order.yml		Loading commit data...
19086-double-newline.yml		Loading commit data...
19966-api-call-to-move-project-to-different-group-fails-when-using-group-and-project-names-instead-of-id.yml		Loading commit data...
19988-prevent-empty-pagination-when-list-not-empty.yml		Loading commit data...
21135-resolve-these-conflicts-link-is-too-subtle.yml		Loading commit data...
24820-buttons-in-the-branches-page-are-stacking-on-top-of-each-other-depending-on-the-selected-filter.yml		Loading commit data...
24876-page-jumps-to-wrong-position-when-clicking-a-comment-anchor.yml		Loading commit data...
25277-milestone-counter-number-with-delimiter.yml		Loading commit data...
25371-environments-date-created-column-is-not-labeled.yml		Loading commit data...
25430-make-colors-in-runner-status-more-colorblind-friendly.yml		Loading commit data...
25580-trucate-dropdown-for-long-branch.yml		Loading commit data...
25678-remove-user-build.yml		Loading commit data...
25701-standardize-text-colors.yml		Loading commit data...
25705-your-commands-have-been-executed-is-overkill.yml		Loading commit data...
25725-remove-window-object.yml		Loading commit data...
25829-update-username-button-remains-disabled-upon-failure.yml		Loading commit data...
25898-ci-icon-color-mr.yml		Loading commit data...
25941-odd-overflow-behavior-for-long-issue-headers.yml		Loading commit data...
25985-combine-members-and-groups-settings-pages.yml		Loading commit data...
25996-Move-award-emoji-out-of-the-discussion-tab-for-MR.yml		Loading commit data...
26014-fix-update-doc.yml		Loading commit data...
26051-fix-missing-endpoint-route-method.yml		Loading commit data...
26129-add-link-to-branches-page.yml		Loading commit data...
26134-ctrl-enter-does-not-submit-a-new-merge-request.yml		Loading commit data...
26155-merge-request-tabs-don-t-render-when-no-commits-available.yml		Loading commit data...
26192-fixes-too-short-input.yml		Loading commit data...
26226-generate-all-haml-fixtures-within-teaspoon-fixtures-task.yml		Loading commit data...
26238-buttons-not-accessible.yml		Loading commit data...
26261-post-api-v3-projects-idorproject-commits-commits-does-not-work-with-project-path.yml		Loading commit data...
26352-user-dropdown-settings.yml		Loading commit data...
26445-make-icon-buttons-accessible-via-keyboard.yml		Loading commit data...
26446-access-download-artifacts-via-keyboard.yml		Loading commit data...
7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml		Loading commit data...
add_email_password_confirmation.yml		Loading commit data...
additional-award-emoji-repositioning-fixes.yml		Loading commit data...
badge-color-on-white-bg.yml		Loading commit data...
didemacet-ci-lint-page.yml		Loading commit data...
dz-nested-group-misc.yml		Loading commit data...
dz-rename-invalid-users.yml		Loading commit data...
feature-1376-allow-write-access-deploy-keys.yml		Loading commit data...
feature-admin-merge-groups-and-projects.yml		Loading commit data...
feature-log-ldap-to-application-log.yml		Loading commit data...
feature-more-storage-statistics.yml		Loading commit data...
filename-to-file-path.yml		Loading commit data...
fix-api-deprecation.yml		Loading commit data...
fix-blame-500.yml		Loading commit data...
fix-boards-search-typo.yml		Loading commit data...
fix-broken-url-on-group-avatar.yml		Loading commit data...
fix-copy-issues-empty-state.yml		Loading commit data...
fix-light-hr-in-descriptions.yml		Loading commit data...
fix-timezone-due-date-picker.yml		Loading commit data...
get_last_used_date_of_ssh_key.yml		Loading commit data...
issue-boards-animate.yml		Loading commit data...
issue_22664.yml		Loading commit data...
issue_25578.yml		Loading commit data...
issue_25682.yml		Loading commit data...
issues-8081.yml		Loading commit data...
ldap_maint_task.yml		Loading commit data...
login-page-font-size.yml		Loading commit data...
nuke-ugly-spaces-in-changelog-generator.yml		Loading commit data...
pc-add-gitaly-to-architecture.yml		Loading commit data...
pipelines-graph-html-css.yml		Loading commit data...
re-style-issue-new-branch.yml		Loading commit data...
recaptcha_500.yml		Loading commit data...
reduce-queries-milestone-index.yml		Loading commit data...
remove-project-authorizations-id-column.yml		Loading commit data...
remove-successful-pipeline-emails-for-now.yml		Loading commit data...
repository-name-emojis		Loading commit data...
single-edit-comment-widget-2.yml		Loading commit data...
speed-up-group-milestone-index.yml		Loading commit data...
support-google-cloud-storage-backups.yml		Loading commit data...
update-gitlab-markup-gem.yml		Loading commit data...
validate-title-length.yml		Loading commit data...
view-ce-vs-ee.yml		Loading commit data...