BigW Consortium Gitlab
If migrations are pending, make CurrentSettings use existing values and populate missing columns with defaults master was failing because `ApplicationSetting.create_from_defaults` attempted to write to a column that did not exist in the database. This occurred in a `rake db:migrate` task, which was unable to perform the migration that would have added the missing column in the first place. In 9.3 RC2, we also had a bug where password sign-ins were disabled because there were many pending migrations. The problem occurred because `fake_application_settings` was being returned with an OpenStruct that did not include the predicate method `signup_enabled?`. As a result, the value would erroneously return `nil` instead of `true`. This commit uses the values of the defaults to mimic this behavior. This commit also refactors some of the logic to be clearer.
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
ci | Loading commit data... | |
abuse_reports.rb | Loading commit data... | |
appearances.rb | Loading commit data... | |
application_settings.rb | Loading commit data... | |
award_emoji.rb | Loading commit data... | |
boards.rb | Loading commit data... | |
broadcast_messages.rb | Loading commit data... | |
chat_names.rb | Loading commit data... | |
chat_teams.rb | Loading commit data... | |
commit_statuses.rb | Loading commit data... | |
commits.rb | Loading commit data... | |
container_repositories.rb | Loading commit data... | |
conversational_development_index_metrics.rb | Loading commit data... | |
deploy_keys_projects.rb | Loading commit data... | |
deployments.rb | Loading commit data... | |
emails.rb | Loading commit data... | |
environments.rb | Loading commit data... | |
events.rb | Loading commit data... | |
file_uploaders.rb | Loading commit data... | |
forked_project_links.rb | Loading commit data... | |
group_members.rb | Loading commit data... | |
groups.rb | Loading commit data... | |
identities.rb | Loading commit data... | |
issues.rb | Loading commit data... | |
keys.rb | Loading commit data... | |
label_links.rb | Loading commit data... | |
label_priorities.rb | Loading commit data... | |
labels.rb | Loading commit data... | |
lfs_objects.rb | Loading commit data... | |
lfs_objects_projects.rb | Loading commit data... | |
lists.rb | Loading commit data... | |
merge_requests.rb | Loading commit data... | |
merge_requests_closing_issues.rb | Loading commit data... | |
milestones.rb | Loading commit data... | |
namespaces.rb | Loading commit data... | |
notes.rb | Loading commit data... | |
notification_settings.rb | Loading commit data... | |
oauth_access_grants.rb | Loading commit data... | |
oauth_access_tokens.rb | Loading commit data... | |
oauth_applications.rb | Loading commit data... | |
pages_domains.rb | Loading commit data... | |
personal_access_tokens.rb | Loading commit data... | |
personal_snippets.rb | Loading commit data... | |
project_group_links.rb | Loading commit data... | |
project_hooks.rb | Loading commit data... | |
project_members.rb | Loading commit data... | |
project_snippets.rb | Loading commit data... | |
project_statistics.rb | Loading commit data... | |
project_wikis.rb | Loading commit data... | |
projects.rb | Loading commit data... | |
protected_branches.rb | Loading commit data... | |
protected_tags.rb | Loading commit data... | |
releases.rb | Loading commit data... | |
sent_notifications.rb | Loading commit data... | |
sequences.rb | Loading commit data... | |
service_hooks.rb | Loading commit data... | |
services.rb | Loading commit data... | |
snippets.rb | Loading commit data... | |
spam_logs.rb | Loading commit data... | |
subscriptions.rb | Loading commit data... | |
system_hooks.rb | Loading commit data... | |
system_note_metadata.rb | Loading commit data... | |
timelogs.rb | Loading commit data... | |
todos.rb | Loading commit data... | |
trending_project.rb | Loading commit data... | |
u2f_registrations.rb | Loading commit data... | |
uploads.rb | Loading commit data... | |
user_agent_details.rb | Loading commit data... | |
users.rb | Loading commit data... | |
web_hook_log.rb | Loading commit data... | |
wiki_directories.rb | Loading commit data... | |
wiki_pages.rb | Loading commit data... |