BigW Consortium Gitlab
Added performance guidelines for new MRs ## What does this MR do? This MR adds a set of guides that should be followed by merge request authors. ## Are there points in the code the reviewer needs to double check? Spelling, grammar, etc ## Why was this MR needed? There is no set of guidelines one should follow when submitting merge requests. This leads to developers at times disregarding performance. This in turn results in performance specialists having to clean up the mess, or production engineers being woken up in the middle of the night because the database is on fire. ## Does this MR meet the acceptance criteria? - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc @DouweM @rspeicher @pcarranza @dzaporozhets See merge request !5905
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
README.md | Loading commit data... | |
adding_database_indexes.md | Loading commit data... | |
architecture.md | Loading commit data... | |
ci_setup.md | Loading commit data... | |
code_review.md | Loading commit data... | |
db_dump.md | Loading commit data... | |
doc_styleguide.md | Loading commit data... | |
gitlab_architecture_diagram.png | Loading commit data... | |
gitlab_diagram_overview.odg | Loading commit data... | |
gotchas.md | Loading commit data... | |
instrumentation.md | Loading commit data... | |
licensing.md | Loading commit data... | |
merge_request_performance_guidelines.md | Loading commit data... | |
migration_style_guide.md | Loading commit data... | |
newlines_styleguide.md | Loading commit data... | |
omnibus.md | Loading commit data... | |
performance.md | Loading commit data... | |
profiling.md | Loading commit data... | |
rake_tasks.md | Loading commit data... | |
scss_styleguide.md | Loading commit data... | |
shared_files.md | Loading commit data... | |
shell_commands.md | Loading commit data... | |
sidekiq_debugging.md | Loading commit data... | |
sql.md | Loading commit data... | |
testing.md | Loading commit data... | |
ui_guide.md | Loading commit data... | |
what_requires_downtime.md | Loading commit data... |