BigW Consortium Gitlab
Resolve "External statuses not shown correctly on pipeline page" ## What does this MR do? Updates `generic_commit_status/_generic_commit_status.html.haml` template to match the changes made to `ci/builds/_build.html.haml` which had not previously been carried over. ## Testing 1. Ensure updated fixtures are installed (from !7792) so that these changes are made apparent. (check out the !7792 branch if not yet merged into master, then `bundle exec rake db:drop` and `bundle exec rake dev:setup`) 2. Visit a build list page or an individual pipeline page which contains an external build status. 3. The results should look like this: ### Before: ![Screen_Shot_2016-11-28_at_9.11.27_PM](/uploads/ed8c5beb857cd17147dbddf8f5ecab1d/Screen_Shot_2016-11-28_at_9.11.27_PM.png) ### After: ![Screen_Shot_2016-11-28_at_9.12.05_PM](/uploads/9f953a5f14764e336afa4481a917947f/Screen_Shot_2016-11-28_at_9.12.05_PM.png) ## Are there points in the code the reviewer needs to double check? Look for any places where these partials may be rendered to ensure external status match regular build statuses. ## Why was this MR needed? The generic commit status template has been largely overlooked when changes are made to build table rows which should be duplicated in both places. ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [x] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [x] ~~API support added~~ - Tests - [x] ~~Added for this feature/bug~~ - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24710 See merge request !7811
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
artifacts | Loading commit data... | |
badges | Loading commit data... | |
blame | Loading commit data... | |
blob | Loading commit data... | |
boards | Loading commit data... | |
branches | Loading commit data... | |
builds | Loading commit data... | |
buttons | Loading commit data... | |
ci | Loading commit data... | |
commit | Loading commit data... | |
commits | Loading commit data... | |
compare | Loading commit data... | |
container_registry | Loading commit data... | |
cycle_analytics | Loading commit data... | |
deploy_keys | Loading commit data... | |
deployments | Loading commit data... | |
diffs | Loading commit data... | |
environments | Loading commit data... | |
find_file | Loading commit data... | |
forks | Loading commit data... | |
generic_commit_statuses | Loading commit data... | |
graphs | Loading commit data... | |
group_links | Loading commit data... | |
hooks | Loading commit data... | |
imports | Loading commit data... | |
issues | Loading commit data... | |
labels | Loading commit data... | |
merge_requests | Loading commit data... | |
milestones | Loading commit data... | |
network | Loading commit data... | |
notes | Loading commit data... | |
pipelines | Loading commit data... | |
pipelines_settings | Loading commit data... | |
project_members | Loading commit data... | |
protected_branches | Loading commit data... | |
refs | Loading commit data... | |
releases | Loading commit data... | |
repositories | Loading commit data... | |
runners | Loading commit data... | |
services | Loading commit data... | |
snippets | Loading commit data... | |
tags | Loading commit data... | |
tree | Loading commit data... | |
triggers | Loading commit data... | |
variables | Loading commit data... | |
wikis | Loading commit data... | |
_activity.html.haml | Loading commit data... | |
_bitbucket_import_modal.html.haml | Loading commit data... | |
_commit_button.html.haml | Loading commit data... | |
_customize_workflow.html.haml | Loading commit data... | |
_errors.html.haml | Loading commit data... | |
_files.html.haml | Loading commit data... | |
_find_file_link.html.haml | Loading commit data... | |
_gitlab_import_modal.html.haml | Loading commit data... | |
_home_panel.html.haml | Loading commit data... | |
_last_commit.html.haml | Loading commit data... | |
_last_push.html.haml | Loading commit data... | |
_md_preview.html.haml | Loading commit data... | |
_merge_request_settings.html.haml | Loading commit data... | |
_readme.html.haml | Loading commit data... | |
_wiki.html.haml | Loading commit data... | |
_zen.html.haml | Loading commit data... | |
activity.html.haml | Loading commit data... | |
edit.html.haml | Loading commit data... | |
empty.html.haml | Loading commit data... | |
new.html.haml | Loading commit data... | |
no_repo.html.haml | Loading commit data... | |
remove_fork.js.haml | Loading commit data... | |
show.atom.builder | Loading commit data... | |
show.html.haml | Loading commit data... | |
transfer.js.haml | Loading commit data... | |
update.js.haml | Loading commit data... |