BigW Consortium Gitlab
Currently, the way the 'starts_at' and 'ends_at' attributes are set, if the specs are run at one second to midnight, the broadcast message will expire in one second. I have changed it so that we are guaranteed a period of one day until expiration. I believe this is the desired behaviour and it's also consistent with the rest of the factory. This corrects the following three specs that can fail depending upon where and when they are run: ./spec/helpers/broadcast_messages_helper_spec.rb:42 ./spec/models/broadcast_message_spec.rb:26 ./spec/models/broadcast_message_spec.rb:47
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
ci | Loading commit data... | |
abuse_reports.rb | Loading commit data... | |
appearances.rb | Loading commit data... | |
award_emoji.rb | Loading commit data... | |
broadcast_messages.rb | Loading commit data... | |
commit_statuses.rb | Loading commit data... | |
commits.rb | Loading commit data... | |
deploy_keys_projects.rb | Loading commit data... | |
deployments.rb | Loading commit data... | |
emails.rb | Loading commit data... | |
environments.rb | Loading commit data... | |
events.rb | Loading commit data... | |
file_uploader.rb | Loading commit data... | |
forked_project_links.rb | Loading commit data... | |
group_members.rb | Loading commit data... | |
groups.rb | Loading commit data... | |
identities.rb | Loading commit data... | |
issues.rb | Loading commit data... | |
keys.rb | Loading commit data... | |
label_links.rb | Loading commit data... | |
labels.rb | Loading commit data... | |
lfs_objects.rb | Loading commit data... | |
lfs_objects_projects.rb | Loading commit data... | |
merge_requests.rb | Loading commit data... | |
milestones.rb | Loading commit data... | |
namespaces.rb | Loading commit data... | |
notes.rb | Loading commit data... | |
notification_settings.rb | Loading commit data... | |
oauth_access_tokens.rb | Loading commit data... | |
oauth_applications.rb | Loading commit data... | |
personal_access_tokens.rb | Loading commit data... | |
personal_snippets.rb | Loading commit data... | |
project_group_links.rb | Loading commit data... | |
project_hooks.rb | Loading commit data... | |
project_members.rb | Loading commit data... | |
project_snippets.rb | Loading commit data... | |
project_wikis.rb | Loading commit data... | |
projects.rb | Loading commit data... | |
protected_branches.rb | Loading commit data... | |
releases.rb | Loading commit data... | |
sent_notifications.rb | Loading commit data... | |
service_hooks.rb | Loading commit data... | |
services.rb | Loading commit data... | |
snippets.rb | Loading commit data... | |
spam_logs.rb | Loading commit data... | |
system_hooks.rb | Loading commit data... | |
todos.rb | Loading commit data... | |
u2f_registrations.rb | Loading commit data... | |
users.rb | Loading commit data... | |
wiki_pages.rb | Loading commit data... |