BigW Consortium Gitlab
Fix permission checks in member row (backport from gitlab-org/gitlab-ee!460) ## What does this MR do? It improves the check we use to display or not the members' access and controls in the members list. ## Are there points in the code the reviewer needs to double check? No, I replaced an helper with just a permission check so I think it's a better solution. ## Why was this MR needed? There were a spec failure in gitlab-org/gitlab-ee!460 because of the refactor done in the "request access" MR. ## What are the relevant issue numbers? None. ## Does this MR meet the acceptance criteria? - No CHANGELOG needed - [x] Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4670
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
groups | Loading commit data... | |
icons | Loading commit data... | |
issuable | Loading commit data... | |
members | Loading commit data... | |
milestones | Loading commit data... | |
projects | Loading commit data... | |
snippets | Loading commit data... | |
web_hooks | Loading commit data... | |
_choose_group_avatar_button.html.haml | Loading commit data... | |
_clone_panel.html.haml | Loading commit data... | |
_commit_message_container.html.haml | Loading commit data... | |
_confirm_modal.html.haml | Loading commit data... | |
_event_filter.html.haml | Loading commit data... | |
_field.html.haml | Loading commit data... | |
_file_highlight.html.haml | Loading commit data... | |
_group_form.html.haml | Loading commit data... | |
_group_tips.html.haml | Loading commit data... | |
_import_form.html.haml | Loading commit data... | |
_issues.html.haml | Loading commit data... | |
_label_row.html.haml | Loading commit data... | |
_labels_row.html.haml | Loading commit data... | |
_logo.svg | Loading commit data... | |
_merge_requests.html.haml | Loading commit data... | |
_milestone_expired.html.haml | Loading commit data... | |
_milestones_filter.html.haml | Loading commit data... | |
_new_commit_form.html.haml | Loading commit data... | |
_new_project_item_select.html.haml | Loading commit data... | |
_no_password.html.haml | Loading commit data... | |
_no_ssh.html.haml | Loading commit data... | |
_outdated_browser.html.haml | Loading commit data... | |
_project_limit.html.haml | Loading commit data... | |
_promo.html.haml | Loading commit data... | |
_ref_switcher.html.haml | Loading commit data... | |
_service_settings.html.haml | Loading commit data... | |
_show_aside.html.haml | Loading commit data... | |
_sort_dropdown.html.haml | Loading commit data... | |
_visibility_level.html.haml | Loading commit data... | |
_visibility_radios.html.haml | Loading commit data... |