BigW Consortium Gitlab
Clarify blank line rule in newlines_styleguide.md ## What does this MR do? * Corrects a typo in the GitLab Ruby newlines style guide * Makes some vague language in the original guideline more precise ## Are there points in the code the reviewer needs to double check? n/a ## Why was this MR needed? * There was a typo in the original text. * The original text was vague. ## What are the relevant issue numbers? n/a ## Screenshots (if relevant) n/a ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added (Is this recommended for this kind of patch?) - ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - ~~API support added~~ - Tests - ~~Added for this feature/bug~~ - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !6048
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
README.md | Loading commit data... | |
adding_database_indexes.md | Loading commit data... | |
architecture.md | Loading commit data... | |
ci_setup.md | Loading commit data... | |
code_review.md | Loading commit data... | |
db_dump.md | Loading commit data... | |
doc_styleguide.md | Loading commit data... | |
gitlab_architecture_diagram.png | Loading commit data... | |
gitlab_diagram_overview.odg | Loading commit data... | |
gotchas.md | Loading commit data... | |
instrumentation.md | Loading commit data... | |
licensing.md | Loading commit data... | |
migration_style_guide.md | Loading commit data... | |
newlines_styleguide.md | Loading commit data... | |
omnibus.md | Loading commit data... | |
performance.md | Loading commit data... | |
profiling.md | Loading commit data... | |
rake_tasks.md | Loading commit data... | |
scss_styleguide.md | Loading commit data... | |
shared_files.md | Loading commit data... | |
shell_commands.md | Loading commit data... | |
sidekiq_debugging.md | Loading commit data... | |
sql.md | Loading commit data... | |
testing.md | Loading commit data... | |
ui_guide.md | Loading commit data... | |
what_requires_downtime.md | Loading commit data... |