BigW Consortium Gitlab
Resolve "Track the number of new Redis connections per transaction" ## What does this MR do? Add a new metric counter, `new_redis_connections`, that contains the number of calls to `Redis::Client#connect` in the current transaction. ## Are there points in the code the reviewer needs to double check? Not sure. I tested this in kind of a brute-force way: 1. Add a debugger in the monkey-patched `connect` method. 2. With metrics enabled, start the app and load a page. 3. The first Redis connection is created by `Rack::Attack` and isn't in a transaction, but still works fine. 4. The second Redis connection is within a transaction (the page load), and increments the counter. 5. If I reload the page, neither debugger is hit. 6. If I use a Redis client and do `CLIENT KILL` on my two existing clients, then reload the page, I get 3 and 4 again. 7. If I disable metrics collection, the debugger never gets hit. ## Why was this MR needed? We may have a Redis connection leak somewhere, so adding metrics will let us track this. ## What are the relevant issue numbers? Closes #18451. ## Screenshots (if relevant) Hahaha nope, not relevant. ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - [ ] Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc @yorickpeterse See merge request !4649
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
1_settings.rb | Loading commit data... | |
2_app.rb | Loading commit data... | |
4_ci_app.rb | Loading commit data... | |
5_backend.rb | Loading commit data... | |
active_record_query_trace.rb | Loading commit data... | |
attr_encrypted_no_db_connection.rb | Loading commit data... | |
backtrace_silencers.rb | Loading commit data... | |
bullet.rb | Loading commit data... | |
carrierwave.rb | Loading commit data... | |
chronic_duration.rb | Loading commit data... | |
connection_fix.rb | Loading commit data... | |
cookies_serializer.rb | Loading commit data... | |
date_time_formats.rb | Loading commit data... | |
default_url_options.rb | Loading commit data... | |
devise.rb | Loading commit data... | |
devise_password_length.rb.example | Loading commit data... | |
disable_email_interceptor.rb | Loading commit data... | |
doorkeeper.rb | Loading commit data... | |
gitlab_shell_secret_token.rb | Loading commit data... | |
go_get.rb | Loading commit data... | |
gollum.rb | Loading commit data... | |
haml.rb | Loading commit data... | |
health_check.rb | Loading commit data... | |
inflections.rb | Loading commit data... | |
kaminari_config.rb | Loading commit data... | |
metrics.rb | Loading commit data... | |
mime_types.rb | Loading commit data... | |
mysql_ignore_postgresql_options.rb | Loading commit data... | |
omniauth.rb | Loading commit data... | |
postgresql_limit_fix.rb | Loading commit data... | |
postgresql_opclasses_support.rb | Loading commit data... | |
premailer.rb | Loading commit data... | |
public_key.rb | Loading commit data... | |
rack_attack.rb.example | Loading commit data... | |
rack_attack_git_basic_auth.rb | Loading commit data... | |
rack_lineprof.rb | Loading commit data... | |
relative_url.rb.sample | Loading commit data... | |
secret_token.rb | Loading commit data... | |
sentry.rb | Loading commit data... | |
session_store.rb | Loading commit data... | |
sherlock.rb | Loading commit data... | |
sidekiq.rb | Loading commit data... | |
smtp_settings.rb.sample | Loading commit data... | |
static_files.rb | Loading commit data... | |
time_zone.rb | Loading commit data... | |
trusted_proxies.rb | Loading commit data... | |
wrap_parameters.rb | Loading commit data... |