BigW Consortium Gitlab
Resolve "Destroying a project causes post_decline_request to be executed" ## What does this MR do? Ensure we don't send "access request declined" to access requesters when a project is deleted. ## Are there points in the code the reviewer needs to double check? I've created a service to decouple the notification sending from the AR model. ## Why was this MR needed? Because there was an issue. ## What are the relevant issue numbers? Fixes #18755, #18750. ## Does this MR meet the acceptance criteria? - [x] No CHANGELOG needed. - [x] Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4744
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | Loading commit data... | |
ci | Loading commit data... | |
groups | Loading commit data... | |
import | Loading commit data... | |
oauth | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
abuse_reports_controller_spec.rb | Loading commit data... | |
application_controller_spec.rb | Loading commit data... | |
autocomplete_controller_spec.rb | Loading commit data... | |
blob_controller_spec.rb | Loading commit data... | |
commit_controller_spec.rb | Loading commit data... | |
groups_controller_spec.rb | Loading commit data... | |
health_check_controller_spec.rb | Loading commit data... | |
help_controller_spec.rb | Loading commit data... | |
invites_controller_spec.rb | Loading commit data... | |
namespaces_controller_spec.rb | Loading commit data... | |
notification_settings_controller_spec.rb | Loading commit data... | |
projects_controller_spec.rb | Loading commit data... | |
registrations_controller_spec.rb | Loading commit data... | |
root_controller_spec.rb | Loading commit data... | |
sent_notifications_controller_spec.rb | Loading commit data... | |
sessions_controller_spec.rb | Loading commit data... | |
snippets_controller_spec.rb | Loading commit data... | |
uploads_controller_spec.rb | Loading commit data... | |
users_controller_spec.rb | Loading commit data... |