require 'spec_helper' describe API::Variables do let(:user) { create(:user) } let(:user2) { create(:user) } let!(:project) { create(:empty_project, creator_id: user.id) } let!(:master) { create(:project_member, :master, user: user, project: project) } let!(:developer) { create(:project_member, :developer, user: user2, project: project) } let!(:variable) { create(:ci_variable, project: project) } describe 'GET /projects/:id/variables' do context 'authorized user with proper permissions' do it 'returns project variables' do get api("/projects/#{project.id}/variables", user) expect(response).to have_http_status(200) expect(json_response).to be_a(Array) end end context 'authorized user with invalid permissions' do it 'does not return project variables' do get api("/projects/#{project.id}/variables", user2) expect(response).to have_http_status(403) end end context 'unauthorized user' do it 'does not return project variables' do get api("/projects/#{project.id}/variables") expect(response).to have_http_status(401) end end end describe 'GET /projects/:id/variables/:key' do context 'authorized user with proper permissions' do it 'returns project variable details' do get api("/projects/#{project.id}/variables/#{variable.key}", user) expect(response).to have_http_status(200) expect(json_response['value']).to eq(variable.value) end it 'responds with 404 Not Found if requesting non-existing variable' do get api("/projects/#{project.id}/variables/non_existing_variable", user) expect(response).to have_http_status(404) end end context 'authorized user with invalid permissions' do it 'does not return project variable details' do get api("/projects/#{project.id}/variables/#{variable.key}", user2) expect(response).to have_http_status(403) end end context 'unauthorized user' do it 'does not return project variable details' do get api("/projects/#{project.id}/variables/#{variable.key}") expect(response).to have_http_status(401) end end end describe 'POST /projects/:id/variables' do context 'authorized user with proper permissions' do it 'creates variable' do expect do post api("/projects/#{project.id}/variables", user), key: 'TEST_VARIABLE_2', value: 'VALUE_2' end.to change{project.variables.count}.by(1) expect(response).to have_http_status(201) expect(json_response['key']).to eq('TEST_VARIABLE_2') expect(json_response['value']).to eq('VALUE_2') end it 'does not allow to duplicate variable key' do expect do post api("/projects/#{project.id}/variables", user), key: variable.key, value: 'VALUE_2' end.to change{project.variables.count}.by(0) expect(response).to have_http_status(400) end end context 'authorized user with invalid permissions' do it 'does not create variable' do post api("/projects/#{project.id}/variables", user2) expect(response).to have_http_status(403) end end context 'unauthorized user' do it 'does not create variable' do post api("/projects/#{project.id}/variables") expect(response).to have_http_status(401) end end end describe 'PUT /projects/:id/variables/:key' do context 'authorized user with proper permissions' do it 'updates variable data' do initial_variable = project.variables.first value_before = initial_variable.value put api("/projects/#{project.id}/variables/#{variable.key}", user), value: 'VALUE_1_UP' updated_variable = project.variables.first expect(response).to have_http_status(200) expect(value_before).to eq(variable.value) expect(updated_variable.value).to eq('VALUE_1_UP') end it 'responds with 404 Not Found if requesting non-existing variable' do put api("/projects/#{project.id}/variables/non_existing_variable", user) expect(response).to have_http_status(404) end end context 'authorized user with invalid permissions' do it 'does not update variable' do put api("/projects/#{project.id}/variables/#{variable.key}", user2) expect(response).to have_http_status(403) end end context 'unauthorized user' do it 'does not update variable' do put api("/projects/#{project.id}/variables/#{variable.key}") expect(response).to have_http_status(401) end end end describe 'DELETE /projects/:id/variables/:key' do context 'authorized user with proper permissions' do it 'deletes variable' do expect do delete api("/projects/#{project.id}/variables/#{variable.key}", user) expect(response).to have_http_status(204) end.to change{project.variables.count}.by(-1) end it 'responds with 404 Not Found if requesting non-existing variable' do delete api("/projects/#{project.id}/variables/non_existing_variable", user) expect(response).to have_http_status(404) end end context 'authorized user with invalid permissions' do it 'does not delete variable' do delete api("/projects/#{project.id}/variables/#{variable.key}", user2) expect(response).to have_http_status(403) end end context 'unauthorized user' do it 'does not delete variable' do delete api("/projects/#{project.id}/variables/#{variable.key}") expect(response).to have_http_status(401) end end end end