BigW Consortium Gitlab

  1. 08 Jul, 2016 2 commits
  2. 07 Jul, 2016 3 commits
  3. 30 Jun, 2016 1 commit
  4. 24 Jun, 2016 1 commit
    • Fix an information disclosure when requesting access to a group containing private projects · aec3475d
      Rémy Coutable authored
      The issue was with the `User#groups` and `User#projects` associations
      which goes through the `User#group_members` and `User#project_members`.
      
      Initially I chose to use a secure approach by storing the requester's
      user ID in `Member#created_by_id` instead of `Member#user_id` because I
      was aware that there was a security risk since I didn't know the
      codebase well enough.
      
      Then during the review, we decided to change that and directly store the
      requester's user ID into `Member#user_id` (for the sake of simplifying
      the code I believe), meaning that every `group_members` / `project_members`
      association would include the requesters by default...
      
      My bad for not checking that all the `group_members` / `project_members`
      associations and the ones that go through them (e.g. `Group#users` and
      `Project#users`) were made safe with the `where(requested_at: nil)` /
      `where(members: { requested_at: nil })` scopes.
      
      Now they are all secure.
      Signed-off-by: 's avatarRémy Coutable <remy@rymai.me>
  5. 16 Jun, 2016 2 commits
  6. 15 Jun, 2016 1 commit
  7. 14 Jun, 2016 1 commit
  8. 04 May, 2016 1 commit
  9. 20 Apr, 2016 1 commit
  10. 05 Apr, 2016 1 commit
    • Standardize the way we check for and display form errors · 7a2370f7
      Robert Speicher authored
      - Some views had a "Close" button. We've removed this, because we don't
        want users accidentally hiding the validation errors and not knowing
        what needs to be fixed.
      - Some views used `li`, some used `p`, some used `span`. We've
        standardized on `li`.
      - Some views only showed the first error. We've standardized on showing
        all of them.
      - Some views added an `#error_explanation` div, which we've made
        standard.
  11. 14 Mar, 2016 1 commit
  12. 13 Mar, 2016 2 commits
  13. 03 Mar, 2016 1 commit
  14. 28 Jan, 2016 1 commit
  15. 14 Jan, 2016 1 commit
  16. 13 Jan, 2016 2 commits
  17. 12 Jan, 2016 1 commit
  18. 11 Jan, 2016 1 commit
  19. 08 Jan, 2016 2 commits
  20. 07 Jan, 2016 1 commit
  21. 01 Jan, 2016 1 commit
  22. 02 Dec, 2015 2 commits
  23. 25 Nov, 2015 1 commit
  24. 17 Nov, 2015 1 commit
  25. 29 Oct, 2015 1 commit
  26. 16 Oct, 2015 1 commit
  27. 15 Oct, 2015 1 commit
  28. 12 Oct, 2015 1 commit
  29. 10 Oct, 2015 1 commit
  30. 24 Sep, 2015 3 commits