- 02 May, 2018 5 commits
-
-
Zeger-Jan van de Weg authored
Moves the calls to Gitaly, no matter what the feature flag values are.
-
George Tsiolis authored
-
blackst0ne authored
-
Jan Provaznik authored
When an error occurs during merge, the error message is exposed to user and it is also saved in DB. This error message may be user unfriendly (as in !41820) and it could also expose a detailed backend information. Instead of displaying the specific error message, only sanitized generic message is displayed. This is potentially controversial change because disadvantage is that user doesn't get specific reason of failure. Additional changes: * repository.merge including exceptions is is extracted into a separate method to make things clearer * update! is used instead of update so we don't silently ignore an error Related to !41857
-
- 01 May, 2018 5 commits
-
-
George Tsiolis authored
-
Kamil Trzciński authored
-
James Ramsay authored
LFS can be enabled and disabled per project using the API by Masters and Owners, but the UI is only available to Admins. The interface and API should be consistent. LFS can also be enabled and disabled per group using the API by Owners, but the UI is only available to Admins. This interface should also be consistent. Additionally removes an unneeded check if 2FA interface, since the interface is only available to Owners. Closes #33320
-
Jan Provaznik authored
-
Roger Rüttimann authored
-
- 30 Apr, 2018 12 commits
-
-
George Tsiolis authored
-
Oswaldo Ferreira authored
Today, when fetching diffs of a note, we always go to Gitaly in order to diff between commits and return the diff of each discussion note. With this change we avoid doing that for notes on the "current version" of the MR.
-
George Tsiolis authored
-
Constance Okoghenun authored
-
George Tsiolis authored
-
Phil Hughes authored
Sanitize user name to avoid XSS attacks See merge request gitlab/gitlabhq!2373
-
Douwe Maan authored
Serve archive requests with the correct file in all cases (10.7) See merge request gitlab/gitlabhq!2376
-
Phil Hughes authored
Sanitize user name to avoid XSS attacks See merge request gitlab/gitlabhq!2373
-
Douwe Maan authored
Serve archive requests with the correct file in all cases (10.7) See merge request gitlab/gitlabhq!2376
-
Alessio Caiazza authored
-
George Tsiolis authored
-
Bob Van Landuyt authored
Since we only need the `can?` view helpers there, it's better to include those in a separate controller. If we inherit from `ApplicationController` we also need to deal with authentication, that needs to be done in some, but not all doorkeeper controllers.
-
- 27 Apr, 2018 2 commits
-
-
Nick Thomas authored
-
James Ramsay authored
To find the pipeline for a specific sha requires scanning the list of all pipelines for a ref that contains the sha. This makes it hard to find the pipeline id needed to access a trace for a specific job run in the pipeline using the API.
-
- 26 Apr, 2018 5 commits
-
-
Takuya Noguchi authored
-
Winnie Hellmann authored
-
schwedenmut authored
-
Tiago Botelho authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 25 Apr, 2018 6 commits
-
-
Douwe Maan authored
-
Zeger-Jan van de Weg authored
Has been in opt out for 5 months, and within GitLab been in production for longer than that. No code needs to be migrated as this is implemented in GoLang over at Gitaly. Closes https://gitlab.com/gitlab-org/gitaly/issues/314
-
Sean McGivern authored
The NotificationService has to do quite a lot of work to calculate the recipients for an email. Where possible, we should try to avoid doing this in an HTTP request, because the mail are sent by Sidekiq anyway, so there's no need to schedule those emails immediately. This commit creates a generic Sidekiq worker that uses Global ID to serialise and deserialise its arguments, then forwards them to the NotificationService. The NotificationService gains an `#async` method, so you can replace: notification_service.new_issue(issue, current_user) With: notification_service.async.new_issue(issue, current_user) And have everything else work as normal, except that calculating the recipients will be done by Sidekiq, which will then schedule further Sidekiq jobs to send each email.
-
Grzegorz Bizon authored
-
Mark Lapierre authored
Prepare change for internationalization Update locale/gitlab.pot
-
George Tsiolis authored
-
- 24 Apr, 2018 5 commits
-
-
Athar Hameed authored
-
Bob Van Landuyt authored
-
Tomasz Maczukin authored
-
Sean McGivern authored
-
Francisco Javier López authored
-